Guard debug/trace LogMessage calls in hot paths#19253
Open
therepanic wants to merge 1 commit into
Open
Conversation
The main issue is that if we don't use `isDebugEnabled` or `isTraceEnabled` to check, we end up allocating `LogMessage` instances. In this commit, I want to fix what I believe are performance bottlenecks that may occur frequently. Closes: spring-projectsgh-19251 Signed-off-by: Andrey Litvitski <andrey1010102008@gmail.com>
spring-projects-issues
added
the
status: waiting-for-triage
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The main issue is that if we don't use
isDebugEnabledorisTraceEnabledto check, we end up allocatingLogMessageinstances. In this commit, I want to fix what I believe are performance bottlenecks that may occur frequently.If you'd like, we could also create an issue to address the remaining issues of this nature. In that case, we could create an issue and a sub-issue for each module. But for now, I think we should focus on the hot paths.
Closes: gh-19251