Skip to content

Add XML configuration guidance to authorizeRequests deprecation warning #19267

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
s-chan-o wants to merge 1 commit into
base: 6.5.x
Choose a base branch
from
Open

Add XML configuration guidance to authorizeRequests deprecation warning #19267

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion ...g/src/main/java/org/springframework/security/config/http/DefaultFilterChainValidator.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,7 +126,9 @@ private void checkAuthorizationFilters(List<SecurityFilterChain> chains) {
}
if (filterSecurityInterceptor != null) {
this.logger.warn(
"Usage of authorizeRequests is deprecated. Please use authorizeHttpRequests in the configuration");
"Usage of authorizeRequests is deprecated. Please use authorizeHttpRequests in the configuration. "
+ "If you are using XML configuration with <intercept-url>, "
+ "add use-authorization-manager=\"true\" to your <http> element.");
}
authorizationFilter = null;
filterSecurityInterceptor = null;
Expand Down
9 changes: 9 additions & 0 deletions .../test/java/org/springframework/security/config/http/DefaultFilterChainValidatorTests.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,6 +132,15 @@ public void validateCheckLoginPageAllowsAnonymous() {
+ "access to the configured login page. (Simulated access was rejected)");
}

@Test
void validateWhenOnlyFilterSecurityInterceptorThenWarnWithXmlGuidance() {
this.validator.validate(this.chain);
verify(this.logger).warn(
"Usage of authorizeRequests is deprecated. Please use authorizeHttpRequests in the configuration. "
+ "If you are using XML configuration with <intercept-url>, "
+ "add use-authorization-manager=\"true\" to your <http> element.");
}

// SEC-1957
@Test
public void validateCustomMetadataSource() {
Expand Down