Allow anonymous WS-Addressing replies without MessageID#1848
Open
goutamadwant wants to merge 1 commit into
Open
Allow anonymous WS-Addressing replies without MessageID#1848goutamadwant wants to merge 1 commit into
goutamadwant wants to merge 1 commit into
Conversation
Signed-off-by: Goutam Adwant <8672451+goutamadwant@users.noreply.github.com>
spring-projects-issues
added
the
status: waiting-for-triage
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WS-Addressing 1.0 requests may omit
MessageIDwhen replies are sent to the anonymous endpoint or discarded via the none endpoint. Spring WS currently defaults a missingReplyToto anonymous, but still treats the non-null default endpoint as requiringMessageID.This updates the WS-Addressing 1.0 required-property check so
MessageIDis only required whenReplyToorFaultTotargets a non-anonymous, non-none endpoint. The regression coverage includes explicit anonymousReplyTo, missingReplyTo, and noneReplyTorequests withoutMessageID.Closes gh-1427
Testing:
./gradlew :spring-ws-core:test --tests org.springframework.ws.soap.addressing.server.AddressingInterceptor10Tests --max-workers=2./gradlew :spring-ws-core:test --tests 'org.springframework.ws.soap.addressing.*' --max-workers=2./gradlew :spring-ws-core:test --max-workers=2./gradlew :spring-ws-core:check --max-workers=2git diff --check