Skip to content

Center images in sections and add video.js to personalize video controls#420

Merged
ccordoba12 merged 2 commits into
spyder-ide:masterfrom
conradolandia:center-images
May 21, 2026
Merged

Center images in sections and add video.js to personalize video controls#420
ccordoba12 merged 2 commits into
spyder-ide:masterfrom
conradolandia:center-images

Conversation

@conradolandia
Copy link
Copy Markdown
Contributor

@conradolandia conradolandia commented May 19, 2026

Pull Request

Pull Request Checklist

  • Read and followed this repo's Contributing Guidelines
  • Based your PR on the latest version of the master branch
  • Checked your writing carefully for correct English spelling, grammar, etc
  • Described your changes and the motivation for them below
  • Noted what issue(s) this pull request resolves, creating one if needed

Description of Changes

  • Add margin: 1rem auto to section img to center images in sections.
  • Add video.js to improve video controls UI/UX. This adds new control styles to videos that can be further personalized using CSS. Videos can still be added using sphynxcontrib-video markup in rst, but we will need to remember to add :nocontrols: to every video to avoid duplicated controls.

Issue(s) Resolved

  • Images were misaligned.
  • Video controls became hidden when the user moved the pointer away from the video.

@netlify
Copy link
Copy Markdown

netlify Bot commented May 19, 2026

Deploy Preview for spyder-docs-preview ready!

Name Link
🔨 Latest commit f453247
🔍 Latest deploy log https://app.netlify.com/projects/spyder-docs-preview/deploys/6a0f43de105c4a00088d289a
😎 Deploy Preview https://deploy-preview-420--spyder-docs-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@conradolandia conradolandia changed the title Center images in sections Center images in sections and add video.js to personalize video controls May 21, 2026
@ccordoba12 ccordoba12 changed the title Center images in sections and add video.js to personalize video controls Center images in sections and add video.js to personalize video controls May 21, 2026
Copy link
Copy Markdown
Member

@ccordoba12 ccordoba12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks @conradolandia!

@ccordoba12 ccordoba12 merged commit 2f7bbce into spyder-ide:master May 21, 2026
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants