Skip to content

feat: support json schema#909

Merged
nene merged 2 commits into
sql-formatter-org:masterfrom
phoenisx:issues/889
Oct 16, 2025
Merged

feat: support json schema#909
nene merged 2 commits into
sql-formatter-org:masterfrom
phoenisx:issues/889

Conversation

@phoenisx

@phoenisx phoenisx commented Oct 16, 2025

Copy link
Copy Markdown
Contributor

Resolves: #889

Screen.Recording.2025-10-16.at.8.08.23.PM.mov

@codesandbox-ci

codesandbox-ci Bot commented Oct 16, 2025

Copy link
Copy Markdown

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@nene nene left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR.

There are some mistakes though in it. Mainly in descriptions.

Comment thread json-schema/schema.json Outdated
Comment thread json-schema/schema.json Outdated
Comment thread json-schema/schema.json Outdated
Comment thread json-schema/schema.json Outdated

@nene nene left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fixes.

I should point out though that I find it quite annoying to receive fixes through a force-push. It means I can't see a diff of the changes, so I essentially need to re-review everything again.

Comment thread json-schema/schema.json Outdated
@nene

nene commented Oct 16, 2025

Copy link
Copy Markdown
Collaborator

Also, I wonder is there any reason for creating a separate directory for this one JSON file? If no, then I would just place it into the root dir of the repository.

@nene

nene commented Oct 16, 2025

Copy link
Copy Markdown
Collaborator

Also, we should add a few words about the existence of this schema file to README. Or maybe just include the $schema entry inside the config file example in there.

@nene

nene commented Oct 16, 2025

Copy link
Copy Markdown
Collaborator

Thanks.

@nene nene merged commit b9d2db9 into sql-formatter-org:master Oct 16, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Feature Request: $schema for .sql-formatter.json

2 participants