Skip to content

Commit bc21237

Browse files
committed
fix: rename limit/offset narg args to take/skip
LIMIT and OFFSET are reserved SQL keywords, so using them as sqlc.narg() names in the generated List queries produced SQL that failed to parse. Rename the narg parameters to take/skip, which are non-reserved and match the convention used by Prisma/LINQ/EF.
1 parent 59685b3 commit bc21237

1 file changed

Lines changed: 4 additions & 4 deletions

File tree

internal/sqlc/template/template.sql.tmpl

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -288,9 +288,9 @@ ORDER BY
288288
/* query.order , */ {{$query_order}}
289289
{{- end}}
290290
LIMIT
291-
sqlc.narg(limit)::int
291+
sqlc.narg(take)::int
292292
OFFSET
293-
sqlc.narg(offset)::int;
293+
sqlc.narg(skip)::int;
294294

295295
{{range $idx, $key := .Table.GetNonUniqueIndexes}}{{- $query_name := printf "List%s%s" (table_name $.Table.Name "many") (query_index $key)}}
296296
{{- if or (is_fk_index $.Table $key) (should_include $ $query_name)}}
@@ -319,9 +319,9 @@ ORDER BY
319319
/* query.order , */ {{$query_order}}
320320
{{- end}}
321321
LIMIT
322-
sqlc.narg(limit)::int
322+
sqlc.narg(take)::int
323323
OFFSET
324-
sqlc.narg(offset)::int;
324+
sqlc.narg(skip)::int;
325325
{{- end}}
326326

327327
{{- $query_name := printf "Update%s%s" (table_name $.Table.Name "many") (query_index $key)}}

0 commit comments

Comments
 (0)