Commit 0197f96
committed
Add support for dotted paths in JSON type parameters and unwrap SKIP
Two changes for JSON/OBJECT type parsing and explain output:
1. Parser: Parse dotted paths (like a.b.c) for JSON type parameter names
Previously only single identifiers were captured as parameter names.
2. Explain: Unwrap SKIP function calls in ObjectTypeArgument
ClickHouse shows just the path/pattern, not the SKIP wrapper.
Fixes 18 statements across 8 test files:
- 03205_json_syntax (12 statements)
- 03227_json_invalid_regexp (2 statements)
- 03620_json_advanced_shared_data_seek_bug (1 statement)
- Plus metadata updates for other JSON-related tests1 parent 4ceaa25 commit 0197f96
File tree
10 files changed
+34
-47
lines changed- internal/explain
- parser
- testdata
- 03205_json_syntax
- 03207_json_read_subcolumns_1_memory
- 03207_json_read_subcolumns_2_memory
- 03208_array_of_json_read_subcolumns_2_memory
- 03227_json_invalid_regexp
- 03272_json_to_json_cast_1
- 03301_subcolumns_in_mv
10 files changed
+34
-47
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1014 | 1014 | | |
1015 | 1015 | | |
1016 | 1016 | | |
| 1017 | + | |
| 1018 | + | |
| 1019 | + | |
| 1020 | + | |
| 1021 | + | |
| 1022 | + | |
| 1023 | + | |
| 1024 | + | |
| 1025 | + | |
1017 | 1026 | | |
1018 | 1027 | | |
1019 | 1028 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
3689 | 3689 | | |
3690 | 3690 | | |
3691 | 3691 | | |
| 3692 | + | |
3692 | 3693 | | |
3693 | 3694 | | |
| 3695 | + | |
3694 | 3696 | | |
3695 | | - | |
| 3697 | + | |
| 3698 | + | |
3696 | 3699 | | |
| 3700 | + | |
| 3701 | + | |
| 3702 | + | |
| 3703 | + | |
| 3704 | + | |
| 3705 | + | |
| 3706 | + | |
| 3707 | + | |
| 3708 | + | |
| 3709 | + | |
| 3710 | + | |
| 3711 | + | |
| 3712 | + | |
3697 | 3713 | | |
3698 | 3714 | | |
3699 | 3715 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | | - | |
2 | | - | |
3 | | - | |
4 | | - | |
5 | | - | |
6 | | - | |
7 | | - | |
8 | | - | |
9 | | - | |
10 | | - | |
11 | | - | |
12 | | - | |
13 | | - | |
14 | | - | |
15 | | - | |
16 | | - | |
| 1 | + | |
Lines changed: 1 addition & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | 2 | | |
3 | | - | |
4 | | - | |
| 3 | + | |
5 | 4 | | |
6 | 5 | | |
Lines changed: 1 addition & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | 2 | | |
3 | | - | |
4 | | - | |
| 3 | + | |
5 | 4 | | |
6 | 5 | | |
Lines changed: 1 addition & 5 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | | - | |
2 | | - | |
3 | | - | |
4 | | - | |
5 | | - | |
| 1 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | | - | |
2 | | - | |
3 | | - | |
4 | | - | |
5 | | - | |
6 | | - | |
| 1 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | | - | |
2 | | - | |
3 | | - | |
4 | | - | |
5 | | - | |
| 1 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | | - | |
2 | | - | |
3 | | - | |
4 | | - | |
5 | | - | |
| 1 | + | |
Lines changed: 1 addition & 5 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | | - | |
2 | | - | |
3 | | - | |
4 | | - | |
5 | | - | |
| 1 | + | |
0 commit comments