Commit 0855448
Parse dictionary SETTINGS clause and output as Dictionary settings
Add proper parsing for SETTINGS clause in CREATE DICTIONARY statements.
Handle SETTINGS as a keyword token (not IDENT).
Changes:
- Add SETTINGS keyword handling in dictionary definition parsing
- Parse settings with or without parentheses
- Output as "Dictionary settings" (not "Set") in explain
- Update condition to include Settings in dictionary definition check
- Fixes 01268_dictionary_direct_layout stmt25, stmt26
- Also fixes: 01259_dictionary_custom_settings_ddl stmt6,
01676_range_hashed_dictionary stmt5, 01681_cache_dictionary_simple_key stmt7,
01760_polygon_dictionaries stmt17, 01765_hashed_dictionary_simple_key stmt7
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>1 parent 28717df commit 0855448
File tree
8 files changed
+28
-36
lines changed- internal/explain
- parser
- testdata
- 01259_dictionary_custom_settings_ddl
- 01268_dictionary_direct_layout
- 01676_range_hashed_dictionary
- 01681_cache_dictionary_simple_key
- 01760_polygon_dictionaries
- 01765_hashed_dictionary_simple_key
8 files changed
+28
-36
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
92 | 92 | | |
93 | 93 | | |
94 | 94 | | |
95 | | - | |
| 95 | + | |
96 | 96 | | |
97 | 97 | | |
98 | 98 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
3850 | 3850 | | |
3851 | 3851 | | |
3852 | 3852 | | |
| 3853 | + | |
| 3854 | + | |
| 3855 | + | |
| 3856 | + | |
| 3857 | + | |
| 3858 | + | |
| 3859 | + | |
| 3860 | + | |
| 3861 | + | |
| 3862 | + | |
| 3863 | + | |
| 3864 | + | |
| 3865 | + | |
3853 | 3866 | | |
3854 | 3867 | | |
3855 | 3868 | | |
| |||
3873 | 3886 | | |
3874 | 3887 | | |
3875 | 3888 | | |
3876 | | - | |
3877 | | - | |
3878 | | - | |
| 3889 | + | |
| 3890 | + | |
| 3891 | + | |
| 3892 | + | |
| 3893 | + | |
| 3894 | + | |
| 3895 | + | |
3879 | 3896 | | |
3880 | 3897 | | |
3881 | 3898 | | |
| |||
3892 | 3909 | | |
3893 | 3910 | | |
3894 | 3911 | | |
3895 | | - | |
| 3912 | + | |
3896 | 3913 | | |
3897 | 3914 | | |
3898 | 3915 | | |
| |||
Lines changed: 1 addition & 5 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | | - | |
2 | | - | |
3 | | - | |
4 | | - | |
5 | | - | |
| 1 | + | |
Lines changed: 1 addition & 6 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | | - | |
2 | | - | |
3 | | - | |
4 | | - | |
5 | | - | |
6 | | - | |
| 1 | + | |
Lines changed: 1 addition & 5 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | | - | |
2 | | - | |
3 | | - | |
4 | | - | |
5 | | - | |
| 1 | + | |
Lines changed: 1 addition & 5 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | | - | |
2 | | - | |
3 | | - | |
4 | | - | |
5 | | - | |
| 1 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | | - | |
2 | | - | |
3 | | - | |
4 | | - | |
5 | | - | |
| 1 | + | |
Lines changed: 1 addition & 5 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | | - | |
2 | | - | |
3 | | - | |
4 | | - | |
5 | | - | |
| 1 | + | |
0 commit comments