Add ViewTargets support for MATERIALIZED VIEW with TO clause

claude · claude · commit 1079b4ec5240 · 2025-12-30T22:02:23.000Z
- Add hasStorageChild check for counting ViewTargets as a child
- Output ViewTargets when MATERIALIZED VIEW has TO clause but no storage
- This matches ClickHouse's EXPLAIN AST format for MATERIALIZED VIEW
diff --git a/internal/explain/statements.go b/internal/explain/statements.go
@@ -140,9 +140,14 @@ func explainCreateQuery(sb *strings.Builder, n *ast.CreateQuery, indent string,
 	if len(n.Columns) > 0 || len(n.Indexes) > 0 || len(n.Projections) > 0 || len(n.Constraints) > 0 {
 		children++
 	}
-	if n.Engine != nil || len(n.OrderBy) > 0 || len(n.PrimaryKey) > 0 || n.PartitionBy != nil {
+	hasStorageChild := n.Engine != nil || len(n.OrderBy) > 0 || len(n.PrimaryKey) > 0 || n.PartitionBy != nil || n.SampleBy != nil || n.TTL != nil || len(n.Settings) > 0
+	if hasStorageChild {
 		children++
 	}
+	// For materialized views with TO clause but no storage, count ViewTargets as a child
+	if n.Materialized && n.To != "" && !hasStorageChild {
+		children++ // ViewTargets
+	}
 	if n.AsSelect != nil {
 		children++
 	}
@@ -381,6 +386,10 @@ func explainCreateQuery(sb *strings.Builder, n *ast.CreateQuery, indent string,
 		if len(n.Settings) > 0 {
 			fmt.Fprintf(sb, "%s Set\n", storageIndent)
 		}
+	} else if n.Materialized && n.To != "" {
+		// For materialized views with TO clause but no storage definition,
+		// output just ViewTargets without children
+		fmt.Fprintf(sb, "%s ViewTargets\n", indent)
 	}
 	// For non-materialized views, output AsSelect after storage
 	if n.AsSelect != nil && !n.Materialized {
diff --git a/parser/testdata/00508_materialized_view_to/metadata.json b/parser/testdata/00508_materialized_view_to/metadata.json
@@ -1,5 +1 @@
-{
-  "explain_todo": {
-    "stmt3": true
-  }
-}
+{}
diff --git a/parser/testdata/00943_mv_rename_without_inner_table/metadata.json b/parser/testdata/00943_mv_rename_without_inner_table/metadata.json
@@ -1 +1,5 @@
-{"explain_todo":{"stmt10":true,"stmt7":true}}
+{
+  "explain_todo": {
+    "stmt10": true
+  }
+}
diff --git a/parser/testdata/00975_recursive_materialized_view/metadata.json b/parser/testdata/00975_recursive_materialized_view/metadata.json
@@ -1,5 +1 @@
-{
-  "explain_todo": {
-    "stmt7": true
-  }
-}
+{}
diff --git a/parser/testdata/00982_low_cardinality_setting_in_mv/metadata.json b/parser/testdata/00982_low_cardinality_setting_in_mv/metadata.json
@@ -1 +1 @@
-{"explain_todo":{"stmt6":true}}
+{}
diff --git a/parser/testdata/00986_materialized_view_stack_overflow/metadata.json b/parser/testdata/00986_materialized_view_stack_overflow/metadata.json
@@ -1 +1 @@
-{"explain_todo":{"stmt7":true,"stmt8":true}}
+{}
diff --git a/parser/testdata/01019_alter_materialized_view_query/metadata.json b/parser/testdata/01019_alter_materialized_view_query/metadata.json
@@ -1,6 +1,5 @@
 {
   "explain_todo": {
-    "stmt6": true,
     "stmt9": true
   }
 }
diff --git a/parser/testdata/01019_materialized_view_select_extra_columns/metadata.json b/parser/testdata/01019_materialized_view_select_extra_columns/metadata.json
@@ -1,5 +1 @@
-{
-  "explain_todo": {
-    "stmt7": true
-  }
-}
+{}
diff --git a/parser/testdata/01023_materialized_view_query_context/metadata.json b/parser/testdata/01023_materialized_view_query_context/metadata.json
@@ -1,6 +1,5 @@
 {
   "explain_todo": {
-    "stmt12": true,
     "stmt6": true
   }
 }
diff --git a/parser/testdata/01064_incremental_streaming_from_2_src_with_feedback/metadata.json b/parser/testdata/01064_incremental_streaming_from_2_src_with_feedback/metadata.json
@@ -1,7 +1,5 @@
 {
   "explain_todo": {
-    "stmt14": true,
-    "stmt16": true,
     "stmt17": true,
     "stmt18": true,
     "stmt19": true
diff --git a/parser/testdata/01069_materialized_view_alter_target_table/metadata.json b/parser/testdata/01069_materialized_view_alter_target_table/metadata.json
@@ -1,5 +1 @@
-{
-  "explain_todo": {
-    "stmt6": true
-  }
-}
+{}
diff --git a/parser/testdata/01069_materialized_view_alter_target_table_with_default_expression/metadata.json b/parser/testdata/01069_materialized_view_alter_target_table_with_default_expression/metadata.json
@@ -1,5 +1 @@
-{
-  "explain_todo": {
-    "stmt6": true
-  }
-}
+{}
diff --git a/parser/testdata/01268_mv_scalars/metadata.json b/parser/testdata/01268_mv_scalars/metadata.json
@@ -1,5 +1 @@
-{
-  "explain_todo": {
-    "stmt19": true
-  }
-}
+{}
diff --git a/parser/testdata/01277_buffer_column_order/metadata.json b/parser/testdata/01277_buffer_column_order/metadata.json
@@ -1,6 +1 @@
-{
-  "explain_todo": {
-    "stmt10": true,
-    "stmt9": true
-  }
-}
+{}
diff --git a/parser/testdata/01361_buffer_table_flush_with_materialized_view/metadata.json b/parser/testdata/01361_buffer_table_flush_with_materialized_view/metadata.json
@@ -1,5 +1 @@
-{
-  "explain_todo": {
-    "stmt7": true
-  }
-}
+{}
diff --git a/parser/testdata/01527_materialized_view_stack_overflow/metadata.json b/parser/testdata/01527_materialized_view_stack_overflow/metadata.json
@@ -1 +1 @@
-{"explain_todo":{"stmt13":true,"stmt14":true,"stmt5":true,"stmt6":true}}
+{}
diff --git a/parser/testdata/01836_date_time_keep_default_timezone_on_operations_den_crane/metadata.json b/parser/testdata/01836_date_time_keep_default_timezone_on_operations_den_crane/metadata.json
@@ -1,5 +1 @@
-{
-  "explain_todo": {
-    "stmt12": true
-  }
-}
+{}
diff --git a/parser/testdata/01927_query_views_log_current_database/metadata.json b/parser/testdata/01927_query_views_log_current_database/metadata.json
@@ -1,7 +1 @@
-{
-  "explain_todo": {
-    "stmt10": true,
-    "stmt11": true,
-    "stmt9": true
-  }
-}
+{}
diff --git a/parser/testdata/01947_mv_subquery/metadata.json b/parser/testdata/01947_mv_subquery/metadata.json
@@ -1,8 +1,6 @@
 {
   "explain_todo": {
-    "stmt15": true,
     "stmt17": true,
-    "stmt6": true,
     "stmt8": true
   }
 }
diff --git a/parser/testdata/02125_query_views_log/metadata.json b/parser/testdata/02125_query_views_log/metadata.json
@@ -1,6 +1 @@
-{
-  "explain_todo": {
-    "stmt8": true,
-    "stmt9": true
-  }
-}
+{}
diff --git a/parser/testdata/02137_mv_into_join/metadata.json b/parser/testdata/02137_mv_into_join/metadata.json
@@ -1,6 +1 @@
-{
-  "explain_todo": {
-    "stmt4": true,
-    "stmt5": true
-  }
-}
+{}
diff --git a/parser/testdata/02139_MV_with_scalar_subquery/metadata.json b/parser/testdata/02139_MV_with_scalar_subquery/metadata.json
@@ -1,6 +1 @@
-{
-  "explain_todo": {
-    "stmt4": true,
-    "stmt5": true
-  }
-}
+{}
diff --git a/parser/testdata/02174_cte_scalar_cache_mv/metadata.json b/parser/testdata/02174_cte_scalar_cache_mv/metadata.json
@@ -1,7 +1 @@
-{
-  "explain_todo": {
-    "stmt19": true,
-    "stmt33": true,
-    "stmt4": true
-  }
-}
+{}
diff --git a/parser/testdata/02184_default_table_engine/metadata.json b/parser/testdata/02184_default_table_engine/metadata.json
@@ -1,6 +1,5 @@
 {
   "explain_todo": {
-    "stmt106": true,
     "stmt107": true,
     "stmt114": true,
     "stmt26": true,
diff --git a/parser/testdata/02187_insert_values_with_mv/metadata.json b/parser/testdata/02187_insert_values_with_mv/metadata.json
@@ -1,9 +1 @@
-{
-  "explain_todo": {
-    "stmt3": true,
-    "stmt4": true,
-    "stmt5": true,
-    "stmt6": true,
-    "stmt7": true
-  }
-}
+{}
diff --git a/parser/testdata/02231_buffer_aggregate_states_leak/metadata.json b/parser/testdata/02231_buffer_aggregate_states_leak/metadata.json
@@ -1,5 +1 @@
-{
-  "explain_todo": {
-    "stmt8": true
-  }
-}
+{}
diff --git a/parser/testdata/02345_implicit_transaction/metadata.json b/parser/testdata/02345_implicit_transaction/metadata.json
@@ -5,7 +5,6 @@
     "stmt32": true,
     "stmt35": true,
     "stmt38": true,
-    "stmt41": true,
-    "stmt6": true
+    "stmt41": true
   }
 }
diff --git a/parser/testdata/02420_final_setting/metadata.json b/parser/testdata/02420_final_setting/metadata.json
@@ -1,6 +1,5 @@
 {
   "explain_todo": {
-    "stmt1": true,
-    "stmt23": true
+    "stmt1": true
   }
 }
diff --git a/parser/testdata/02420_final_setting_analyzer/metadata.json b/parser/testdata/02420_final_setting_analyzer/metadata.json
@@ -1,6 +1,5 @@
 {
   "explain_todo": {
-    "stmt2": true,
-    "stmt24": true
+    "stmt2": true
   }
 }
diff --git a/parser/testdata/02459_materialized_view_default_value/metadata.json b/parser/testdata/02459_materialized_view_default_value/metadata.json
@@ -1,5 +1 @@
-{
-  "explain_todo": {
-    "stmt6": true
-  }
-}
+{}
diff --git a/parser/testdata/02552_check_referential_table_dependencies/metadata.json b/parser/testdata/02552_check_referential_table_dependencies/metadata.json
@@ -1 +1 @@
-{"explain_todo":{"stmt15":true,"stmt6":true}}
+{}
diff --git a/parser/testdata/02572_materialized_views_ignore_errors/metadata.json b/parser/testdata/02572_materialized_views_ignore_errors/metadata.json
@@ -1,5 +1 @@
-{
-  "explain_todo": {
-    "stmt9": true
-  }
-}
+{}
diff --git a/parser/testdata/02572_system_logs_materialized_views_ignore_errors/metadata.json b/parser/testdata/02572_system_logs_materialized_views_ignore_errors/metadata.json
@@ -1,5 +1 @@
-{
-  "explain_todo": {
-    "stmt6": true
-  }
-}
+{}
diff --git a/parser/testdata/02696_ignore_inacc_tables_mat_view_atttach/metadata.json b/parser/testdata/02696_ignore_inacc_tables_mat_view_atttach/metadata.json
@@ -1,5 +1 @@
-{
-  "explain_todo": {
-    "stmt4": true
-  }
-}
+{}
diff --git a/parser/testdata/02697_alter_dependencies/metadata.json b/parser/testdata/02697_alter_dependencies/metadata.json
@@ -1,6 +1,5 @@
 {
   "explain_todo": {
-    "stmt3": true,
     "stmt4": true
   }
 }
diff --git a/parser/testdata/02912_ingestion_mv_deduplication/metadata.json b/parser/testdata/02912_ingestion_mv_deduplication/metadata.json
@@ -2,7 +2,6 @@
   "explain_todo": {
     "stmt17": true,
     "stmt29": true,
-    "stmt42": true,
     "stmt5": true
   }
 }
diff --git a/parser/testdata/02931_alter_materialized_view_query_inconsistent/metadata.json b/parser/testdata/02931_alter_materialized_view_query_inconsistent/metadata.json
@@ -1,6 +1,5 @@
 {
   "explain_todo": {
-    "stmt6": true,
     "stmt8": true
   }
 }
diff --git a/parser/testdata/02932_materialized_view_with_dropped_target_table_no_exception/metadata.json b/parser/testdata/02932_materialized_view_with_dropped_target_table_no_exception/metadata.json
@@ -1,5 +1 @@
-{
-  "explain_todo": {
-    "stmt8": true
-  }
-}
+{}
diff --git a/parser/testdata/02933_ephemeral_mv/metadata.json b/parser/testdata/02933_ephemeral_mv/metadata.json
@@ -1,5 +1 @@
-{
-  "explain_todo": {
-    "stmt3": true
-  }
-}
+{}
diff --git a/parser/testdata/02972_insert_deduplication_token_hierarchical_inserts/metadata.json b/parser/testdata/02972_insert_deduplication_token_hierarchical_inserts/metadata.json
@@ -1,11 +1 @@
-{
-  "explain_todo": {
-    "stmt13": true,
-    "stmt17": true,
-    "stmt19": true,
-    "stmt23": true,
-    "stmt27": true,
-    "stmt31": true,
-    "stmt9": true
-  }
-}
+{}
diff --git a/parser/testdata/02972_insert_deduplication_token_hierarchical_inserts_views/metadata.json b/parser/testdata/02972_insert_deduplication_token_hierarchical_inserts_views/metadata.json
@@ -1,6 +1 @@
-{
-  "explain_todo": {
-    "stmt10": true,
-    "stmt12": true
-  }
-}
+{}
diff --git a/parser/testdata/02999_scalar_subqueries_bug_2/metadata.json b/parser/testdata/02999_scalar_subqueries_bug_2/metadata.json
@@ -1,5 +1 @@
-{
-  "explain_todo": {
-    "stmt10": true
-  }
-}
+{}
diff --git a/parser/testdata/03002_modify_query_cte/metadata.json b/parser/testdata/03002_modify_query_cte/metadata.json
@@ -1,6 +1,5 @@
 {
   "explain_todo": {
-    "stmt2": true,
     "stmt4": true
   }
 }
diff --git a/parser/testdata/03008_deduplication_cases_from_docs/metadata.json b/parser/testdata/03008_deduplication_cases_from_docs/metadata.json
@@ -1,8 +1,6 @@
 {
   "explain_todo": {
     "stmt27": true,
-    "stmt68": true,
-    "stmt8": true,
-    "stmt9": true
+    "stmt68": true
   }
 }
diff --git a/parser/testdata/03008_deduplication_wrong_mv/metadata.json b/parser/testdata/03008_deduplication_wrong_mv/metadata.json
@@ -1,5 +1 @@
-{
-  "explain_todo": {
-    "stmt6": true
-  }
-}
+{}
diff --git a/parser/testdata/03030_system_flush_distributed_settings/metadata.json b/parser/testdata/03030_system_flush_distributed_settings/metadata.json
@@ -3,7 +3,6 @@
     "stmt10": true,
     "stmt15": true,
     "stmt16": true,
-    "stmt7": true,
-    "stmt9": true
+    "stmt7": true
   }
 }
diff --git a/parser/testdata/03094_grouparraysorted_memory/metadata.json b/parser/testdata/03094_grouparraysorted_memory/metadata.json
@@ -1,5 +1 @@
-{
-  "explain_todo": {
-    "stmt3": true
-  }
-}
+{}
diff --git a/parser/testdata/03094_virtual_column_table_name/metadata.json b/parser/testdata/03094_virtual_column_table_name/metadata.json
@@ -1,6 +1,5 @@
 {
   "explain_todo": {
-    "stmt59": true,
     "stmt60": true
   }
 }
diff --git a/parser/testdata/03149_analyzer_join_projection_name_2/metadata.json b/parser/testdata/03149_analyzer_join_projection_name_2/metadata.json
@@ -1,6 +1,5 @@
 {
   "explain_todo": {
-    "stmt10": true,
     "stmt9": true
   }
 }
diff --git a/parser/testdata/03150_dynamic_type_mv_insert/metadata.json b/parser/testdata/03150_dynamic_type_mv_insert/metadata.json
@@ -1,5 +1 @@
-{
-  "explain_todo": {
-    "stmt8": true
-  }
-}
+{}
diff --git a/parser/testdata/03155_in_nested_subselects/metadata.json b/parser/testdata/03155_in_nested_subselects/metadata.json
@@ -1,5 +1 @@
-{
-  "explain_todo": {
-    "stmt6": true
-  }
-}
+{}
diff --git a/parser/testdata/03161_create_table_as_mv/metadata.json b/parser/testdata/03161_create_table_as_mv/metadata.json
diff --git a/parser/testdata/03168_attach_as_replicated_materialized_view/metadata.json b/parser/testdata/03168_attach_as_replicated_materialized_view/metadata.json
diff --git a/parser/testdata/03230_show_create_query_identifier_quoting_style/metadata.json b/parser/testdata/03230_show_create_query_identifier_quoting_style/metadata.json
diff --git a/parser/testdata/03243_check_for_nullable_nothing_in_alter/metadata.json b/parser/testdata/03243_check_for_nullable_nothing_in_alter/metadata.json
diff --git a/parser/testdata/03254_normalize_aggregate_states_with_named_tuple_args/metadata.json b/parser/testdata/03254_normalize_aggregate_states_with_named_tuple_args/metadata.json
diff --git a/parser/testdata/03285_default_engine_with_settings/metadata.json b/parser/testdata/03285_default_engine_with_settings/metadata.json
diff --git a/parser/testdata/03301_subcolumns_in_mv/metadata.json b/parser/testdata/03301_subcolumns_in_mv/metadata.json
diff --git a/parser/testdata/03310_materialized_view_with_bad_select/metadata.json b/parser/testdata/03310_materialized_view_with_bad_select/metadata.json
diff --git a/parser/testdata/03322_materialized_view_ignore_errors_url/metadata.json b/parser/testdata/03322_materialized_view_ignore_errors_url/metadata.json
diff --git a/parser/testdata/03357_analyzer_insert_view/metadata.json b/parser/testdata/03357_analyzer_insert_view/metadata.json
diff --git a/parser/testdata/03357_storage_join_mv_context/metadata.json b/parser/testdata/03357_storage_join_mv_context/metadata.json
diff --git a/parser/testdata/03530_insert_into_distributed_different_types_sparseness/metadata.json b/parser/testdata/03530_insert_into_distributed_different_types_sparseness/metadata.json
diff --git a/parser/testdata/03531_insert_removing_sparse_transform/metadata.json b/parser/testdata/03531_insert_removing_sparse_transform/metadata.json
diff --git a/parser/testdata/03561_materialized_subcolumns_materialized_view/metadata.json b/parser/testdata/03561_materialized_subcolumns_materialized_view/metadata.json
diff --git a/parser/testdata/03633_mv_squash_parallel_inserts/metadata.json b/parser/testdata/03633_mv_squash_parallel_inserts/metadata.json
diff --git a/parser/testdata/03710_pr_insert_into_mv_with_join/metadata.json b/parser/testdata/03710_pr_insert_into_mv_with_join/metadata.json
diff --git a/parser/testdata/03710_pr_join_with_mv/metadata.json b/parser/testdata/03710_pr_join_with_mv/metadata.json
diff --git a/parser/testdata/03740_alter_modify_query_dict_name_in_cse/metadata.json b/parser/testdata/03740_alter_modify_query_dict_name_in_cse/metadata.json

Original file line number	Diff line number	Diff line change
`@@ -140,9 +140,14 @@ func explainCreateQuery(sb strings.Builder, n ast.CreateQuery, indent string,`
`140`	`140`	`if len(n.Columns) > 0 \|\| len(n.Indexes) > 0 \|\| len(n.Projections) > 0 \|\| len(n.Constraints) > 0 {`
`141`	`141`	`children++`
`142`	`142`	`}`
`143`		`- if n.Engine != nil \|\| len(n.OrderBy) > 0 \|\| len(n.PrimaryKey) > 0 \|\| n.PartitionBy != nil {`
	`143`	`+ hasStorageChild := n.Engine != nil \|\| len(n.OrderBy) > 0 \|\| len(n.PrimaryKey) > 0 \|\| n.PartitionBy != nil \|\| n.SampleBy != nil \|\| n.TTL != nil \|\| len(n.Settings) > 0`
	`144`	`+ if hasStorageChild {`
`144`	`145`	`children++`
`145`	`146`	`}`
	`147`	`+ // For materialized views with TO clause but no storage, count ViewTargets as a child`
	`148`	`+ if n.Materialized && n.To != "" && !hasStorageChild {`
	`149`	`+ children++ // ViewTargets`
	`150`	`+ }`
`146`	`151`	`if n.AsSelect != nil {`
`147`	`152`	`children++`
`148`	`153`	`}`
`@@ -381,6 +386,10 @@ func explainCreateQuery(sb strings.Builder, n ast.CreateQuery, indent string,`
`381`	`386`	`if len(n.Settings) > 0 {`
`382`	`387`	`fmt.Fprintf(sb, "%s Set\n", storageIndent)`
`383`	`388`	`}`
	`389`	`+ } else if n.Materialized && n.To != "" {`
	`390`	`+ // For materialized views with TO clause but no storage definition,`
	`391`	`+ // output just ViewTargets without children`
	`392`	`+ fmt.Fprintf(sb, "%s ViewTargets\n", indent)`
`384`	`393`	`}`
`385`	`394`	`// For non-materialized views, output AsSelect after storage`
`386`	`395`	`if n.AsSelect != nil && !n.Materialized {`
-Original file line number
+Diff line change
@@ @@ -1,5 +1 @@ @@
 -{
 -  "explain_todo": {
 -    "stmt3": true
 -  }
 -}
 +{}
Original file line number	Diff line number	Diff line change
`@@ -1 +1 @@`
`1`		`-{"explain_todo":{"stmt7":true,"stmt8":true}}`
	`1`	`+{}`
Original file line number	Diff line number	Diff line change
`@@ -1,6 +1,5 @@`
`1`	`1`	`{`
`2`	`2`	`"explain_todo": {`
`3`		`- "stmt6": true,`
`4`	`3`	`"stmt9": true`
`5`	`4`	`}`
`6`	`5`	`}`
Original file line number	Diff line number	Diff line change
`@@ -1,6 +1,5 @@`
`1`	`1`	`{`
`2`	`2`	`"explain_todo": {`
`3`		`- "stmt12": true,`
`4`	`3`	`"stmt6": true`
`5`	`4`	`}`
`6`	`5`	`}`
Original file line number	Diff line number	Diff line change
`@@ -1,7 +1,5 @@`
`1`	`1`	`{`
`2`	`2`	`"explain_todo": {`
`3`		`- "stmt14": true,`
`4`		`- "stmt16": true,`
`5`	`3`	`"stmt17": true,`
`6`	`4`	`"stmt18": true,`
`7`	`5`	`"stmt19": true`