Allow ARRAY keyword to be used as identifier (column name)

claude · claude · commit 37a38121a8ea · 2025-12-30T21:32:57.000Z
When ARRAY is not followed by '(', treat it as an identifier
rather than requiring it to be a constructor. This allows
column names like 'array' to be referenced correctly.
diff --git a/parser/expression.go b/parser/expression.go
@@ -303,8 +303,12 @@ func (p *Parser) parsePrefixExpression() ast.Expression {
 	case token.COLUMNS:
 		return p.parseColumnsMatcher()
 	case token.ARRAY:
-		// array(1,2,3) constructor
-		return p.parseArrayConstructor()
+		// array(1,2,3) constructor or array as identifier (column name)
+		if p.peekIs(token.LPAREN) {
+			return p.parseArrayConstructor()
+		}
+		// array used as identifier (column/variable name)
+		return p.parseKeywordAsIdentifier()
 	case token.IF:
 		// IF function
 		return p.parseIfFunction()
diff --git a/parser/testdata/00261_storage_aliases_and_array_join/metadata.json b/parser/testdata/00261_storage_aliases_and_array_join/metadata.json
@@ -1,57 +1 @@
-{
-  "explain_todo": {
-    "stmt17": true,
-    "stmt18": true,
-    "stmt20": true,
-    "stmt21": true,
-    "stmt22": true,
-    "stmt23": true,
-    "stmt24": true,
-    "stmt25": true,
-    "stmt26": true,
-    "stmt28": true,
-    "stmt29": true,
-    "stmt3": true,
-    "stmt30": true,
-    "stmt31": true,
-    "stmt32": true,
-    "stmt33": true,
-    "stmt34": true,
-    "stmt36": true,
-    "stmt37": true,
-    "stmt38": true,
-    "stmt39": true,
-    "stmt40": true,
-    "stmt41": true,
-    "stmt42": true,
-    "stmt44": true,
-    "stmt45": true,
-    "stmt46": true,
-    "stmt47": true,
-    "stmt48": true,
-    "stmt49": true,
-    "stmt50": true,
-    "stmt52": true,
-    "stmt53": true,
-    "stmt54": true,
-    "stmt55": true,
-    "stmt56": true,
-    "stmt57": true,
-    "stmt58": true,
-    "stmt60": true,
-    "stmt61": true,
-    "stmt62": true,
-    "stmt63": true,
-    "stmt64": true,
-    "stmt65": true,
-    "stmt66": true,
-    "stmt68": true,
-    "stmt70": true,
-    "stmt72": true,
-    "stmt74": true,
-    "stmt76": true,
-    "stmt78": true,
-    "stmt80": true,
-    "stmt81": true
-  }
-}
+{}
diff --git a/parser/testdata/00262_alter_alias/metadata.json b/parser/testdata/00262_alter_alias/metadata.json
@@ -1,9 +1,6 @@
 {
   "explain_todo": {
     "stmt10": true,
-    "stmt12": true,
-    "stmt5": true,
-    "stmt7": true,
-    "stmt9": true
+    "stmt12": true
   }
 }
diff --git a/parser/testdata/01054_cache_dictionary_overflow_cell/metadata.json b/parser/testdata/01054_cache_dictionary_overflow_cell/metadata.json
@@ -1,5 +1 @@
-{
-  "explain_todo": {
-    "stmt25": true
-  }
-}
+{}
diff --git a/parser/testdata/02022_array_full_text_bloom_filter_index/metadata.json b/parser/testdata/02022_array_full_text_bloom_filter_index/metadata.json
@@ -1,12 +1 @@
-{
-  "explain_todo": {
-    "stmt13": true,
-    "stmt14": true,
-    "stmt15": true,
-    "stmt3": true,
-    "stmt4": true,
-    "stmt7": true,
-    "stmt8": true,
-    "stmt9": true
-  }
-}
+{}
diff --git a/parser/testdata/02346_text_index_creation/metadata.json b/parser/testdata/02346_text_index_creation/metadata.json
@@ -1,7 +1,6 @@
 {
   "explain_todo": {
     "stmt102": true,
-    "stmt103": true,
-    "stmt29": true
+    "stmt103": true
   }
 }
diff --git a/parser/testdata/02346_text_index_dictionary_cache/metadata.json b/parser/testdata/02346_text_index_dictionary_cache/metadata.json
@@ -1,6 +1,5 @@
 {
   "explain_todo": {
-    "stmt12": true,
-    "stmt9": true
+    "stmt12": true
   }
 }
diff --git a/parser/testdata/02346_text_index_header_cache/metadata.json b/parser/testdata/02346_text_index_header_cache/metadata.json
@@ -1,7 +1,6 @@
 {
   "explain_todo": {
     "stmt11": true,
-    "stmt13": true,
-    "stmt9": true
+    "stmt13": true
   }
 }
diff --git a/parser/testdata/02346_text_index_postings_cache/metadata.json b/parser/testdata/02346_text_index_postings_cache/metadata.json
@@ -1,6 +1,5 @@
 {
   "explain_todo": {
-    "stmt14": true,
-    "stmt9": true
+    "stmt14": true
   }
 }
diff --git a/parser/testdata/02943_use_full_text_skip_index_with_has_any/metadata.json b/parser/testdata/02943_use_full_text_skip_index_with_has_any/metadata.json
@@ -1,20 +1 @@
-{
-  "explain_todo": {
-    "stmt11": true,
-    "stmt13": true,
-    "stmt15": true,
-    "stmt17": true,
-    "stmt19": true,
-    "stmt21": true,
-    "stmt23": true,
-    "stmt25": true,
-    "stmt27": true,
-    "stmt29": true,
-    "stmt3": true,
-    "stmt31": true,
-    "stmt33": true,
-    "stmt4": true,
-    "stmt7": true,
-    "stmt9": true
-  }
-}
+{}
diff --git a/parser/testdata/03702_text_index_hint_basics/metadata.json b/parser/testdata/03702_text_index_hint_basics/metadata.json
@@ -2,7 +2,6 @@
   "explain_todo": {
     "stmt11": true,
     "stmt13": true,
-    "stmt16": true,
     "stmt19": true,
     "stmt21": true,
     "stmt27": true,
diff --git a/parser/testdata/03707_function_array_remove/metadata.json b/parser/testdata/03707_function_array_remove/metadata.json
@@ -1,6 +1,5 @@
 {
   "explain_todo": {
-    "stmt33": true,
     "stmt45": true,
     "stmt46": true
   }
diff --git a/parser/testdata/03742_lazy_materialization_of_array_after_alter_add_column/metadata.json b/parser/testdata/03742_lazy_materialization_of_array_after_alter_add_column/metadata.json
@@ -1,6 +1,5 @@
 {
   "explain_todo": {
-    "stmt4": true,
-    "stmt5": true
+    "stmt4": true
   }
 }

Original file line number	Diff line number	Diff line change
`@@ -1,9 +1,6 @@`
`1`	`1`	`{`
`2`	`2`	`"explain_todo": {`
`3`	`3`	`"stmt10": true,`
`4`		`- "stmt12": true,`
`5`		`- "stmt5": true,`
`6`		`- "stmt7": true,`
`7`		`- "stmt9": true`
	`4`	`+ "stmt12": true`
`8`	`5`	`}`
`9`	`6`	`}`
-Original file line number
+Diff line change
@@ @@ -1,5 +1 @@ @@
 -{
 -  "explain_todo": {
 -    "stmt25": true
 -  }
 -}
 +{}
Original file line number	Diff line number	Diff line change
`@@ -1,7 +1,6 @@`
`1`	`1`	`{`
`2`	`2`	`"explain_todo": {`
`3`	`3`	`"stmt102": true,`
`4`		`- "stmt103": true,`
`5`		`- "stmt29": true`
	`4`	`+ "stmt103": true`
`6`	`5`	`}`
`7`	`6`	`}`
Original file line number	Diff line number	Diff line change
`@@ -1,6 +1,5 @@`
`1`	`1`	`{`
`2`	`2`	`"explain_todo": {`
`3`		`- "stmt12": true,`
`4`		`- "stmt9": true`
	`3`	`+ "stmt12": true`
`5`	`4`	`}`
`6`	`5`	`}`
Original file line number	Diff line number	Diff line change
`@@ -1,7 +1,6 @@`
`1`	`1`	`{`
`2`	`2`	`"explain_todo": {`
`3`	`3`	`"stmt11": true,`
`4`		`- "stmt13": true,`
`5`		`- "stmt9": true`
	`4`	`+ "stmt13": true`
`6`	`5`	`}`
`7`	`6`	`}`
Original file line number	Diff line number	Diff line change
`@@ -1,6 +1,5 @@`
`1`	`1`	`{`
`2`	`2`	`"explain_todo": {`
`3`		`- "stmt14": true,`
`4`		`- "stmt9": true`
	`3`	`+ "stmt14": true`
`5`	`4`	`}`
`6`	`5`	`}`