Fix 31 todo tests by adding # comment and parameterized query support (#23)

Author: kyleconroy

lexer/lexer.go

@@ -92,6 +92,9 @@ func (l *Lexer) NextToken() Item {
 	if l.ch == '-' && l.peekChar() == '-' {
 		return l.readLineComment()
 	}
+	if l.ch == '#' {
+		return l.readHashComment()
+	}
 	if l.ch == '/' && l.peekChar() == '*' {
 		return l.readBlockComment()
 	}
@@ -280,6 +283,20 @@ func (l *Lexer) readLineComment() Item {
 	return Item{Token: token.COMMENT, Value: sb.String(), Pos: pos}
 }
 
+func (l *Lexer) readHashComment() Item {
+	pos := l.pos
+	var sb strings.Builder
+	// Skip #
+	sb.WriteRune(l.ch)
+	l.readChar()
+
+	for l.ch != '\n' && l.ch != 0 && !l.eof {
+		sb.WriteRune(l.ch)
+		l.readChar()
+	}
+	return Item{Token: token.COMMENT, Value: sb.String(), Pos: pos}
+}
+
 func (l *Lexer) readBlockComment() Item {
 	pos := l.pos
 	var sb strings.Builder

parser/parser.go

@@ -3098,6 +3098,13 @@ func (p *Parser) parseIdentifierName() string {
 		return name
 	}
 
+	// Handle parameterized identifiers like {CLICKHOUSE_DATABASE:Identifier}
+	if p.currentIs(token.PARAM) {
+		name = "{" + p.current.Value + "}"
+		p.nextToken()
+		return name
+	}
+
 	// Handle name starting with number (e.g., 03657_test)
 	if p.currentIs(token.NUMBER) {
 		name = p.current.Value

parser/parser_test.go

@@ -66,7 +66,7 @@ func TestParser(t *testing.T) {
 			var queryParts []string
 			for _, line := range strings.Split(string(queryBytes), "\n") {
 				trimmed := strings.TrimSpace(line)
-				if trimmed == "" || strings.HasPrefix(trimmed, "--") {
+				if trimmed == "" || strings.HasPrefix(trimmed, "--") || strings.HasPrefix(trimmed, "#") {
 					continue
 				}
 				// Remove trailing comment if present (but not inside strings - simple heuristic)

parser/testdata/00080_show_tables_and_system_tables/metadata.json

@@ -1 +1 @@
-{"explain":false,"todo": true}
+{"explain":false}

parser/testdata/00158_buffer_and_nonexistent_table/metadata.json

@@ -1 +1 @@
-{"explain":false,"todo": true}
+{"explain":false}

parser/testdata/00571_non_exist_database_when_create_materializ_view/metadata.json

@@ -1 +1 @@
-{"explain":false,"todo": true}
+{"explain":false}

parser/testdata/00740_database_in_nested_view/metadata.json

@@ -1 +1 @@
-{"explain":false,"todo": true}
+{"explain":false}

parser/testdata/01012_show_tables_limit/metadata.json

@@ -1 +1 @@
-{"explain":false,"todo": true}
+{"explain":false}

parser/testdata/01041_create_dictionary_if_not_exists/metadata.json

@@ -1 +1 @@
-{"explain":false,"todo": true}
+{"explain":false}

parser/testdata/01043_dictionary_attribute_properties_values/metadata.json

@@ -1 +1 @@
-{"explain":false,"todo": true}
+{"explain":false}