Fix NULL::Type cast to keep Literal NULL format

claude · claude · commit 4c5028252078 · 2025-12-31T18:02:21.000Z
When casting NULL with :: operator syntax (e.g. NULL::Nullable(UInt8)),
output as Literal NULL rather than Literal \'NULL\'.

Fixes many statements across 27 tests.
diff --git a/internal/explain/functions.go b/internal/explain/functions.go
@@ -336,6 +336,9 @@ func explainCastExprWithAlias(sb *strings.Builder, n *ast.CastExpr, alias string
 					exprStr := formatExprAsString(lit)
 					fmt.Fprintf(sb, "%s  Literal \\'%s\\'\n", indent, exprStr)
 				}
+			} else if lit.Type == ast.LiteralNull {
+				// NULL stays as Literal NULL, not formatted as a string
+				fmt.Fprintf(sb, "%s  Literal NULL\n", indent)
 			} else {
 				// Simple literal - format as string
 				exprStr := formatExprAsString(lit)
diff --git a/parser/testdata/00255_array_concat_string/metadata.json b/parser/testdata/00255_array_concat_string/metadata.json
@@ -1 +1,8 @@
-{"explain_todo":{"stmt12":true,"stmt15":true,"stmt16":true,"stmt17":true,"stmt18":true,"stmt20":true}}
+{
+  "explain_todo": {
+    "stmt15": true,
+    "stmt16": true,
+    "stmt17": true,
+    "stmt18": true
+  }
+}
diff --git a/parser/testdata/00727_concat/metadata.json b/parser/testdata/00727_concat/metadata.json
@@ -3,13 +3,6 @@
     "stmt19": true,
     "stmt20": true,
     "stmt44": true,
-    "stmt46": true,
-    "stmt62": true,
-    "stmt63": true,
-    "stmt64": true,
-    "stmt65": true,
-    "stmt66": true,
-    "stmt67": true,
-    "stmt83": true
+    "stmt46": true
   }
 }
diff --git a/parser/testdata/01410_nullable_key_and_index_negate_cond/metadata.json b/parser/testdata/01410_nullable_key_and_index_negate_cond/metadata.json
@@ -1,5 +1 @@
-{
-  "explain_todo": {
-    "stmt23": true
-  }
-}
+{}
diff --git a/parser/testdata/02277_full_sort_join_misc/metadata.json b/parser/testdata/02277_full_sort_join_misc/metadata.json
@@ -1,5 +1 @@
-{
-  "explain_todo": {
-    "stmt5": true
-  }
-}
+{}
diff --git a/parser/testdata/02302_defaults_in_columnar_formats/metadata.json b/parser/testdata/02302_defaults_in_columnar_formats/metadata.json
@@ -1,7 +1 @@
-{
-  "explain_todo": {
-    "stmt1": true,
-    "stmt3": true,
-    "stmt5": true
-  }
-}
+{}
diff --git a/parser/testdata/02320_mapped_array_witn_const_nullable/metadata.json b/parser/testdata/02320_mapped_array_witn_const_nullable/metadata.json
@@ -1 +1 @@
-{"explain_todo":{"stmt5":true,"stmt6":true}}
+{}
diff --git a/parser/testdata/02797_range_nullable/metadata.json b/parser/testdata/02797_range_nullable/metadata.json
@@ -1 +1 @@
-{"explain_todo":{"stmt10":true,"stmt11":true,"stmt12":true,"stmt9":true}}
+{}
diff --git a/parser/testdata/02809_has_subsequence/metadata.json b/parser/testdata/02809_has_subsequence/metadata.json
@@ -1 +1 @@
-{"explain_todo":{"stmt61":true}}
+{}
diff --git a/parser/testdata/02922_analyzer_aggregate_nothing_type/metadata.json b/parser/testdata/02922_analyzer_aggregate_nothing_type/metadata.json
@@ -1,12 +1 @@
-{
-  "explain_todo": {
-    "stmt27": true,
-    "stmt28": true,
-    "stmt29": true,
-    "stmt3": true,
-    "stmt30": true,
-    "stmt4": true,
-    "stmt7": true,
-    "stmt82": true
-  }
-}
+{}
diff --git a/parser/testdata/02922_respect_nulls_extensive/metadata.json b/parser/testdata/02922_respect_nulls_extensive/metadata.json
@@ -1,6 +1 @@
-{
-  "explain_todo": {
-    "stmt40": true,
-    "stmt41": true
-  }
-}
+{}
diff --git a/parser/testdata/02922_respect_nulls_states/metadata.json b/parser/testdata/02922_respect_nulls_states/metadata.json
@@ -1 +1 @@
-{"explain_todo":{"stmt3":true,"stmt5":true,"stmt7":true,"stmt9":true}}
+{}
diff --git a/parser/testdata/02935_format_with_arbitrary_types/metadata.json b/parser/testdata/02935_format_with_arbitrary_types/metadata.json
@@ -3,13 +3,6 @@
     "stmt19": true,
     "stmt20": true,
     "stmt44": true,
-    "stmt46": true,
-    "stmt55": true,
-    "stmt56": true,
-    "stmt57": true,
-    "stmt58": true,
-    "stmt59": true,
-    "stmt60": true,
-    "stmt76": true
+    "stmt46": true
   }
 }
diff --git a/parser/testdata/02942_variant_cast/metadata.json b/parser/testdata/02942_variant_cast/metadata.json
@@ -1 +1 @@
-{"explain_todo":{"stmt12":true,"stmt13":true,"stmt16":true,"stmt17":true,"stmt2":true}}
+{}
diff --git a/parser/testdata/02943_variant_element/metadata.json b/parser/testdata/02943_variant_element/metadata.json
@@ -1,7 +1 @@
-{
-  "explain_todo": {
-    "stmt11": true,
-    "stmt3": true,
-    "stmt9": true
-  }
-}
+{}
diff --git a/parser/testdata/02944_variant_as_common_type_analyzer/metadata.json b/parser/testdata/02944_variant_as_common_type_analyzer/metadata.json
@@ -1,12 +1 @@
-{
-  "explain_todo": {
-    "stmt10": true,
-    "stmt11": true,
-    "stmt18": true,
-    "stmt19": true,
-    "stmt26": true,
-    "stmt27": true,
-    "stmt34": true,
-    "stmt35": true
-  }
-}
+{}
diff --git a/parser/testdata/02990_arrayFold_nullable_lc/metadata.json b/parser/testdata/02990_arrayFold_nullable_lc/metadata.json
@@ -1,6 +1 @@
-{
-  "explain_todo": {
-    "stmt24": true,
-    "stmt25": true
-  }
-}
+{}
diff --git a/parser/testdata/03032_string_to_variant_cast/metadata.json b/parser/testdata/03032_string_to_variant_cast/metadata.json
@@ -1,7 +1 @@
-{
-  "explain_todo": {
-    "stmt12": true,
-    "stmt14": true,
-    "stmt15": true
-  }
-}
+{}
diff --git a/parser/testdata/03210_dynamic_squashing/metadata.json b/parser/testdata/03210_dynamic_squashing/metadata.json
@@ -1,6 +1 @@
-{
-  "explain_todo": {
-    "stmt10": true,
-    "stmt5": true
-  }
-}
+{}
diff --git a/parser/testdata/03261_any_respect_camelCase_aliases/metadata.json b/parser/testdata/03261_any_respect_camelCase_aliases/metadata.json
@@ -1,9 +1 @@
-{
-  "explain_todo": {
-    "stmt10": true,
-    "stmt16": true,
-    "stmt22": true,
-    "stmt28": true,
-    "stmt4": true
-  }
-}
+{}
diff --git a/parser/testdata/03408_hash_functions_on_null/metadata.json b/parser/testdata/03408_hash_functions_on_null/metadata.json
@@ -1,12 +1 @@
-{
-  "explain_todo": {
-    "stmt11": true,
-    "stmt12": true,
-    "stmt18": true,
-    "stmt19": true,
-    "stmt23": true,
-    "stmt24": true,
-    "stmt6": true,
-    "stmt7": true
-  }
-}
+{}
diff --git a/parser/testdata/03513_simple_aggregate_function_any_respect_nulls_in_aggregating_merge_tree/metadata.json b/parser/testdata/03513_simple_aggregate_function_any_respect_nulls_in_aggregating_merge_tree/metadata.json
@@ -1,7 +1,5 @@
 {
   "explain_todo": {
-    "stmt3": true,
-    "stmt4": true,
-    "stmt5": true
+    "stmt4": true
   }
 }
diff --git a/parser/testdata/03513_simple_aggregate_function_any_respect_nulls_in_summing_merge_tree/metadata.json b/parser/testdata/03513_simple_aggregate_function_any_respect_nulls_in_summing_merge_tree/metadata.json
@@ -1,7 +1,5 @@
 {
   "explain_todo": {
-    "stmt3": true,
-    "stmt4": true,
-    "stmt5": true
+    "stmt4": true
   }
 }
diff --git a/parser/testdata/03522_function_first_non_default/metadata.json b/parser/testdata/03522_function_first_non_default/metadata.json
@@ -1,11 +1 @@
-{
-  "explain_todo": {
-    "stmt16": true,
-    "stmt2": true,
-    "stmt22": true,
-    "stmt23": true,
-    "stmt33": true,
-    "stmt4": true,
-    "stmt7": true
-  }
-}
+{}
diff --git a/parser/testdata/03525_transform_null_in_subqeury_with_not_nullable_type/metadata.json b/parser/testdata/03525_transform_null_in_subqeury_with_not_nullable_type/metadata.json
@@ -1,7 +1 @@
-{
-  "explain_todo": {
-    "stmt2": true,
-    "stmt3": true,
-    "stmt4": true
-  }
-}
+{}
diff --git a/parser/testdata/03606_nullable_json_group_by/metadata.json b/parser/testdata/03606_nullable_json_group_by/metadata.json
@@ -1,5 +1 @@
-{
-  "explain_todo": {
-    "stmt3": true
-  }
-}
+{}
diff --git a/parser/testdata/03639_hash_of_dynamic_column/metadata.json b/parser/testdata/03639_hash_of_dynamic_column/metadata.json
@@ -1 +1 @@
-{"explain_todo":{"stmt10":true,"stmt9":true}}
+{}
diff --git a/parser/testdata/03707_function_array_remove/metadata.json b/parser/testdata/03707_function_array_remove/metadata.json
@@ -1,6 +1 @@
-{
-  "explain_todo": {
-    "stmt45": true,
-    "stmt46": true
-  }
-}
+{}

-Original file line number
+Diff line change
@@ @@ -1,5 +1 @@ @@
 -{
 -  "explain_todo": {
 -    "stmt23": true
 -  }
 -}
 +{}
Original file line number	Diff line number	Diff line change
`@@ -1 +1 @@`
`1`		`-{"explain_todo":{"stmt5":true,"stmt6":true}}`
	`1`	`+{}`
Original file line number	Diff line number	Diff line change
`@@ -1 +1 @@`
`1`		`-{"explain_todo":{"stmt10":true,"stmt11":true,"stmt12":true,"stmt9":true}}`
	`1`	`+{}`