Commit 4ff9272
committed
Fix GROUPING SETS tuple unwrapping and add TOP clause support
- Fixed GROUPING SETS handling to unwrap tuple literals and output elements
directly with correct child counts
- Added TOP clause support to SELECT parser (use MUL_PREC to stop at *)
- Added TOP clause output to EXPLAIN AST at end of SelectQuery
- Updated 3 GROUPING SETS tests that now pass
The TOP fix prevents `SELECT TOP 5 * FROM t` from being misparsed as
`TOP (5 * FROM t)` where * was treated as multiplication.1 parent 259d663 commit 4ff9272
File tree
5 files changed
+12
-20
lines changed- internal/explain
- parser
- testdata
- 01883_grouping_sets_crash
- 01883_with_grouping_sets
- 02313_group_by_modifiers_with_non_default_types
5 files changed
+12
-20
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
181 | 181 | | |
182 | 182 | | |
183 | 183 | | |
| 184 | + | |
| 185 | + | |
| 186 | + | |
| 187 | + | |
184 | 188 | | |
185 | 189 | | |
186 | 190 | | |
| |||
355 | 359 | | |
356 | 360 | | |
357 | 361 | | |
| 362 | + | |
| 363 | + | |
| 364 | + | |
| 365 | + | |
358 | 366 | | |
359 | 367 | | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
492 | 492 | | |
493 | 493 | | |
494 | 494 | | |
495 | | - | |
| 495 | + | |
| 496 | + | |
496 | 497 | | |
497 | 498 | | |
498 | 499 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | 2 | | |
3 | | - | |
4 | | - | |
5 | | - | |
6 | | - | |
7 | | - | |
8 | | - | |
9 | | - | |
10 | | - | |
| 3 | + | |
11 | 4 | | |
12 | 5 | | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | 2 | | |
3 | | - | |
4 | | - | |
5 | | - | |
6 | | - | |
7 | | - | |
8 | | - | |
9 | 3 | | |
10 | 4 | | |
11 | 5 | | |
Lines changed: 1 addition & 5 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | | - | |
2 | | - | |
3 | | - | |
4 | | - | |
5 | | - | |
| 1 | + | |
0 commit comments