Commit 6aaa618
committed
Fix empty tuple and WITH clause expression parsing
1. Fix WITH clause to only treat ( as subquery when followed by SELECT/WITH
Previously (SELECT...) AS name was parsed even for empty () or expressions
2. Fix empty tuple EXPLAIN output to use Function tuple format
Empty tuples should output "Function tuple (children 1)" with ExpressionList
rather than "Literal Tuple_()"
Fixes 41 tests including materialized views and WITH clause tests.1 parent cf878e5 commit 6aaa618
41 files changed
Lines changed: 55 additions & 199 deletions
File tree
- internal/explain
- parser
- testdata
- 00101_materialized_views_and_insert_without_explicit_database
- 00148_summing_merge_tree_aggregate_function
- 00165_jit_aggregate_functions
- 00172_constexprs_in_set
- 00175_partition_by_ignore
- 00542_materialized_view_and_time_zone_tag
- 00610_materialized_view_forward_alter_partition_statements
- 00687_insert_into_mv
- 00751_default_databasename_for_view
- 00752_low_cardinality_mv_1
- 00752_low_cardinality_mv_2
- 00753_system_columns_and_system_tables_long
- 00916_create_or_replace_view
- 00945_bloom_filter_index
- 01046_materialized_view_with_join_over_distributed
- 01153_attach_mv_uuid
- 01155_rename_move_materialized_view
- 01161_information_schema
- 01332_join_type_syntax_position
- 01504_view_type_conversion
- 01549_low_cardinality_materialized_view
- 01549_low_cardinality_mv_fuzz
- 01907_multiple_aliases
- 02096_rename_atomic_hang
- 02116_tuple_element_analyzer
- 02343_analyzer_lambdas
- 02385_analyzer_aliases_compound_expression
- 02695_logical_optimizer_alias_bug
- 02833_tuple_concat
- 02841_with_clause_resolve
- 02923_cte_equality_disjunction
- 03022_alter_materialized_view_query_has_inner_table
- 03035_materialized_primary_key
- 03174_split_parts_ranges_into_intersecting_and_non_intersecting_final_and_read-in-order_bug
- 03201_analyzer_resolve_in_parent_scope
- 03314_analyzer_resolve_in_parent_scope_3
- 03359_analyzer_rewrite_view_query
- 03566_analyzer_single_with_scope
- 03714_empty_tuple_reverse_function
Some content is hidden
Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
422 | 422 | | |
423 | 423 | | |
424 | 424 | | |
425 | | - | |
| 425 | + | |
| 426 | + | |
| 427 | + | |
| 428 | + | |
| 429 | + | |
426 | 430 | | |
427 | 431 | | |
428 | | - | |
| 432 | + | |
429 | 433 | | |
430 | 434 | | |
431 | 435 | | |
432 | | - | |
| 436 | + | |
433 | 437 | | |
434 | 438 | | |
435 | 439 | | |
| |||
683 | 687 | | |
684 | 688 | | |
685 | 689 | | |
| 690 | + | |
| 691 | + | |
| 692 | + | |
| 693 | + | |
| 694 | + | |
| 695 | + | |
| 696 | + | |
| 697 | + | |
| 698 | + | |
| 699 | + | |
| 700 | + | |
| 701 | + | |
686 | 702 | | |
687 | 703 | | |
688 | 704 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
819 | 819 | | |
820 | 820 | | |
821 | 821 | | |
822 | | - | |
823 | | - | |
| 822 | + | |
| 823 | + | |
824 | 824 | | |
825 | 825 | | |
826 | 826 | | |
| |||
Lines changed: 1 addition & 3 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
3 | 3 | | |
4 | 4 | | |
5 | 5 | | |
6 | | - | |
7 | | - | |
8 | | - | |
| 6 | + | |
9 | 7 | | |
10 | 8 | | |
Lines changed: 1 addition & 5 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | | - | |
2 | | - | |
3 | | - | |
4 | | - | |
5 | | - | |
| 1 | + | |
Lines changed: 1 addition & 6 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | | - | |
2 | | - | |
3 | | - | |
4 | | - | |
5 | | - | |
6 | | - | |
| 1 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | | - | |
2 | | - | |
3 | | - | |
4 | | - | |
5 | | - | |
| 1 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | | - | |
2 | | - | |
3 | | - | |
4 | | - | |
5 | | - | |
6 | | - | |
| 1 | + | |
Lines changed: 1 addition & 5 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | | - | |
2 | | - | |
3 | | - | |
4 | | - | |
5 | | - | |
| 1 | + | |
Lines changed: 1 addition & 5 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | | - | |
2 | | - | |
3 | | - | |
4 | | - | |
5 | | - | |
| 1 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | | - | |
2 | | - | |
3 | | - | |
4 | | - | |
5 | | - | |
6 | | - | |
7 | | - | |
| 1 | + | |
0 commit comments