Add trim to trimBoth function name normalization

claude · claude · commit 7080f6447f9f · 2025-12-31T03:13:53.000Z
ClickHouse canonicalizes trim() to trimBoth() in EXPLAIN AST output.
This fixes many text/token index tests that use trim().
diff --git a/internal/explain/format.go b/internal/explain/format.go
@@ -277,6 +277,7 @@ func formatBinaryExprForType(expr *ast.BinaryExpr) string {
 func NormalizeFunctionName(name string) string {
 	// ClickHouse normalizes certain function names in EXPLAIN AST
 	normalized := map[string]string{
+		"trim":       "trimBoth",
 		"ltrim":      "trimLeft",
 		"rtrim":      "trimRight",
 		"lcase":      "lower",
diff --git a/parser/testdata/00765_sql_compatibility_aliases/metadata.json b/parser/testdata/00765_sql_compatibility_aliases/metadata.json
@@ -1,7 +1,6 @@
 {
   "explain_todo": {
     "stmt10": true,
-    "stmt18": true,
     "stmt2": true,
     "stmt25": true,
     "stmt26": true,
diff --git a/parser/testdata/02160_special_functions/metadata.json b/parser/testdata/02160_special_functions/metadata.json
@@ -1,6 +1,5 @@
 {
   "explain_todo": {
-    "stmt11": true,
     "stmt14": true,
     "stmt16": true,
     "stmt18": true,
diff --git a/parser/testdata/02346_text_index_direct_read/metadata.json b/parser/testdata/02346_text_index_direct_read/metadata.json
@@ -1,12 +1 @@
-{
-  "explain_todo": {
-    "stmt22": true,
-    "stmt23": true,
-    "stmt24": true,
-    "stmt25": true,
-    "stmt26": true,
-    "stmt27": true,
-    "stmt28": true,
-    "stmt29": true
-  }
-}
+{}
diff --git a/parser/testdata/02346_text_index_match_predicate/metadata.json b/parser/testdata/02346_text_index_match_predicate/metadata.json
@@ -1,10 +1 @@
-{
-  "explain_todo": {
-    "stmt10": true,
-    "stmt11": true,
-    "stmt14": true,
-    "stmt15": true,
-    "stmt6": true,
-    "stmt7": true
-  }
-}
+{}
diff --git a/parser/testdata/02346_text_index_on_lower_column/metadata.json b/parser/testdata/02346_text_index_on_lower_column/metadata.json
@@ -1,10 +1 @@
-{
-  "explain_todo": {
-    "stmt11": true,
-    "stmt13": true,
-    "stmt18": true,
-    "stmt20": true,
-    "stmt22": true,
-    "stmt9": true
-  }
-}
+{}
diff --git a/parser/testdata/03000_minmax_index_first/metadata.json b/parser/testdata/03000_minmax_index_first/metadata.json
@@ -1,5 +1 @@
-{
-  "explain_todo": {
-    "stmt4": true
-  }
-}
+{}
diff --git a/parser/testdata/03047_on_fly_mutations_skip_index/metadata.json b/parser/testdata/03047_on_fly_mutations_skip_index/metadata.json
@@ -1,8 +1,5 @@
 {
   "explain_todo": {
-    "stmt10": true,
-    "stmt13": true,
-    "stmt15": true,
-    "stmt17": true
+    "stmt13": true
   }
 }
diff --git a/parser/testdata/03100_lwu_36_json_skip_indexes/metadata.json b/parser/testdata/03100_lwu_36_json_skip_indexes/metadata.json
@@ -1,9 +1,5 @@
 {
   "explain_todo": {
-    "stmt10": true,
-    "stmt12": true,
-    "stmt14": true,
-    "stmt16": true,
     "stmt8": true
   }
 }
diff --git a/parser/testdata/03100_lwu_46_deletes_skip_indexes/metadata.json b/parser/testdata/03100_lwu_46_deletes_skip_indexes/metadata.json
@@ -1,10 +1,6 @@
 {
   "explain_todo": {
-    "stmt11": true,
-    "stmt13": true,
-    "stmt15": true,
     "stmt6": true,
-    "stmt7": true,
-    "stmt9": true
+    "stmt7": true
   }
 }
diff --git a/parser/testdata/03165_string_functions_with_token_text_indexes/metadata.json b/parser/testdata/03165_string_functions_with_token_text_indexes/metadata.json
@@ -1,32 +1 @@
-{
-  "explain_todo": {
-    "stmt103": true,
-    "stmt107": true,
-    "stmt111": true,
-    "stmt115": true,
-    "stmt119": true,
-    "stmt12": true,
-    "stmt123": true,
-    "stmt16": true,
-    "stmt20": true,
-    "stmt24": true,
-    "stmt28": true,
-    "stmt32": true,
-    "stmt36": true,
-    "stmt40": true,
-    "stmt51": true,
-    "stmt55": true,
-    "stmt59": true,
-    "stmt63": true,
-    "stmt67": true,
-    "stmt71": true,
-    "stmt75": true,
-    "stmt79": true,
-    "stmt8": true,
-    "stmt83": true,
-    "stmt87": true,
-    "stmt91": true,
-    "stmt95": true,
-    "stmt99": true
-  }
-}
+{}
diff --git a/parser/testdata/03321_functions_to_subcolumns_skip_index/metadata.json b/parser/testdata/03321_functions_to_subcolumns_skip_index/metadata.json
@@ -1,6 +1 @@
-{
-  "explain_todo": {
-    "stmt6": true,
-    "stmt8": true
-  }
-}
+{}
diff --git a/parser/testdata/03457_move_global_in_to_prewhere/metadata.json b/parser/testdata/03457_move_global_in_to_prewhere/metadata.json
@@ -1,8 +1 @@
-{
-  "explain_todo": {
-    "stmt11": true,
-    "stmt13": true,
-    "stmt7": true,
-    "stmt9": true
-  }
-}
+{}
diff --git a/parser/testdata/03563_coarser_minmax_indexes_first/metadata.json b/parser/testdata/03563_coarser_minmax_indexes_first/metadata.json
@@ -1,5 +1 @@
-{
-  "explain_todo": {
-    "stmt4": true
-  }
-}
+{}
diff --git a/parser/testdata/03565_clickhouse_smaller_indexes_first/metadata.json b/parser/testdata/03565_clickhouse_smaller_indexes_first/metadata.json
@@ -1,5 +1 @@
-{
-  "explain_todo": {
-    "stmt4": true
-  }
-}
+{}
diff --git a/parser/testdata/03593_funcs_on_empty_string/metadata.json b/parser/testdata/03593_funcs_on_empty_string/metadata.json
@@ -1 +1,7 @@
-{"explain_todo":{"stmt167":true,"stmt362":true,"stmt373":true,"stmt91":true}}
+{
+  "explain_todo": {
+    "stmt167": true,
+    "stmt373": true,
+    "stmt91": true
+  }
+}
diff --git a/parser/testdata/03636_index_analysis_with_session_tz/metadata.json b/parser/testdata/03636_index_analysis_with_session_tz/metadata.json
@@ -1,10 +1 @@
-{
-  "explain_todo": {
-    "stmt11": true,
-    "stmt17": true,
-    "stmt21": true,
-    "stmt27": true,
-    "stmt31": true,
-    "stmt7": true
-  }
-}
+{}
diff --git a/parser/testdata/03702_text_index_hint_basics/metadata.json b/parser/testdata/03702_text_index_hint_basics/metadata.json
@@ -1,10 +1 @@
-{
-  "explain_todo": {
-    "stmt11": true,
-    "stmt13": true,
-    "stmt19": true,
-    "stmt21": true,
-    "stmt27": true,
-    "stmt29": true
-  }
-}
+{}
diff --git a/parser/testdata/03702_text_index_hint_low_cardinality/metadata.json b/parser/testdata/03702_text_index_hint_low_cardinality/metadata.json
@@ -1,6 +1 @@
-{
-  "explain_todo": {
-    "stmt6": true,
-    "stmt8": true
-  }
-}
+{}
diff --git a/parser/testdata/03722_function_trim_ltrim_rtrim_alias/metadata.json b/parser/testdata/03722_function_trim_ltrim_rtrim_alias/metadata.json
@@ -2,9 +2,6 @@
   "explain_todo": {
     "stmt11": true,
     "stmt12": true,
-    "stmt13": true,
-    "stmt17": true,
-    "stmt5": true,
-    "stmt7": true
+    "stmt13": true
   }
 }

Original file line number	Diff line number	Diff line change
`@@ -1,7 +1,6 @@`
`1`	`1`	`{`
`2`	`2`	`"explain_todo": {`
`3`	`3`	`"stmt10": true,`
`4`		`- "stmt18": true,`
`5`	`4`	`"stmt2": true,`
`6`	`5`	`"stmt25": true,`
`7`	`6`	`"stmt26": true,`
Original file line number	Diff line number	Diff line change
`@@ -1,6 +1,5 @@`
`1`	`1`	`{`
`2`	`2`	`"explain_todo": {`
`3`		`- "stmt11": true,`
`4`	`3`	`"stmt14": true,`
`5`	`4`	`"stmt16": true,`
`6`	`5`	`"stmt18": true,`
-Original file line number
+Diff line change
@@ @@ -1,5 +1 @@ @@
 -{
 -  "explain_todo": {
 -    "stmt4": true
 -  }
 -}
 +{}
Original file line number	Diff line number	Diff line change
`@@ -1,8 +1,5 @@`
`1`	`1`	`{`
`2`	`2`	`"explain_todo": {`
`3`		`- "stmt10": true,`
`4`		`- "stmt13": true,`
`5`		`- "stmt15": true,`
`6`		`- "stmt17": true`
	`3`	`+ "stmt13": true`
`7`	`4`	`}`
`8`	`5`	`}`
Original file line number	Diff line number	Diff line change
`@@ -1,9 +1,5 @@`
`1`	`1`	`{`
`2`	`2`	`"explain_todo": {`
`3`		`- "stmt10": true,`
`4`		`- "stmt12": true,`
`5`		`- "stmt14": true,`
`6`		`- "stmt16": true,`
`7`	`3`	`"stmt8": true`
`8`	`4`	`}`
`9`	`5`	`}`
Original file line number	Diff line number	Diff line change
`@@ -1,10 +1,6 @@`
`1`	`1`	`{`
`2`	`2`	`"explain_todo": {`
`3`		`- "stmt11": true,`
`4`		`- "stmt13": true,`
`5`		`- "stmt15": true,`
`6`	`3`	`"stmt6": true,`
`7`		`- "stmt7": true,`
`8`		`- "stmt9": true`
	`4`	`+ "stmt7": true`
`9`	`5`	`}`
`10`	`6`	`}`