Include type in QueryParameter EXPLAIN output

claude · claude · commit 838f6b4e857f · 2026-01-01T20:05:26.000Z
Format QueryParameter with type as Name:Type to match ClickHouse output.
For example: QueryParameter filter:FixedString(2)

Fixes many parameterized view tests.
diff --git a/internal/explain/statements.go b/internal/explain/statements.go
@@ -1057,7 +1057,11 @@ func explainNameTypePair(sb *strings.Builder, n *ast.NameTypePair, indent string
 
 func explainParameter(sb *strings.Builder, n *ast.Parameter, indent string) {
 	if n.Name != "" {
-		fmt.Fprintf(sb, "%sQueryParameter %s\n", indent, n.Name)
+		if n.Type != nil {
+			fmt.Fprintf(sb, "%sQueryParameter %s:%s\n", indent, n.Name, FormatDataType(n.Type))
+		} else {
+			fmt.Fprintf(sb, "%sQueryParameter %s\n", indent, n.Name)
+		}
 	} else {
 		fmt.Fprintf(sb, "%sQueryParameter\n", indent)
 	}
diff --git a/parser/testdata/02346_text_index_array_support/metadata.json b/parser/testdata/02346_text_index_array_support/metadata.json
@@ -1,7 +1 @@
-{
-  "explain_todo": {
-    "stmt24": true,
-    "stmt57": true,
-    "stmt90": true
-  }
-}
+{}
diff --git a/parser/testdata/02346_text_index_dictionary_cache/metadata.json b/parser/testdata/02346_text_index_dictionary_cache/metadata.json
@@ -1,5 +1 @@
-{
-  "explain_todo": {
-    "stmt12": true
-  }
-}
+{}
diff --git a/parser/testdata/02346_text_index_header_cache/metadata.json b/parser/testdata/02346_text_index_header_cache/metadata.json
@@ -1,5 +1 @@
-{
-  "explain_todo": {
-    "stmt13": true
-  }
-}
+{}
diff --git a/parser/testdata/02346_text_index_map_support/metadata.json b/parser/testdata/02346_text_index_map_support/metadata.json
@@ -1,12 +1 @@
-{
-  "explain_todo": {
-    "stmt113": true,
-    "stmt144": true,
-    "stmt200": true,
-    "stmt21": true,
-    "stmt232": true,
-    "stmt263": true,
-    "stmt52": true,
-    "stmt83": true
-  }
-}
+{}
diff --git a/parser/testdata/02346_text_index_postings_cache/metadata.json b/parser/testdata/02346_text_index_postings_cache/metadata.json
@@ -1,5 +1 @@
-{
-  "explain_todo": {
-    "stmt14": true
-  }
-}
+{}
diff --git a/parser/testdata/03033_analyzer_parametrized_view_alias/metadata.json b/parser/testdata/03033_analyzer_parametrized_view_alias/metadata.json
@@ -1,5 +1 @@
-{
-  "explain_todo": {
-    "stmt3": true
-  }
-}
+{}
diff --git a/parser/testdata/03142_alter_comment_parameterized_view/metadata.json b/parser/testdata/03142_alter_comment_parameterized_view/metadata.json
@@ -1,5 +1 @@
-{
-  "explain_todo": {
-    "stmt2": true
-  }
-}
+{}
diff --git a/parser/testdata/03146_parameterized_view_with_date/metadata.json b/parser/testdata/03146_parameterized_view_with_date/metadata.json
@@ -1 +1 @@
-{"explain_todo":{"stmt5":true}}
+{}
diff --git a/parser/testdata/03209_parameterized_view_with_non_literal_params/metadata.json b/parser/testdata/03209_parameterized_view_with_non_literal_params/metadata.json
@@ -1,9 +1 @@
-{
-  "explain_todo": {
-    "stmt27": true,
-    "stmt43": true,
-    "stmt53": true,
-    "stmt65": true,
-    "stmt9": true
-  }
-}
+{}
diff --git a/parser/testdata/03321_system_tables_parametrized_view_params/metadata.json b/parser/testdata/03321_system_tables_parametrized_view_params/metadata.json
@@ -1 +1 @@
-{"explain_todo":{"stmt10":true,"stmt12":true,"stmt18":true,"stmt20":true}}
+{}
diff --git a/parser/testdata/03322_view_over_parameterized_view/metadata.json b/parser/testdata/03322_view_over_parameterized_view/metadata.json
@@ -1,5 +1 @@
-{
-  "explain_todo": {
-    "stmt1": true
-  }
-}
+{}
diff --git a/parser/testdata/03450_parameterized_view_forward/metadata.json b/parser/testdata/03450_parameterized_view_forward/metadata.json
@@ -1,6 +1 @@
-{
-  "explain_todo": {
-    "stmt2": true,
-    "stmt5": true
-  }
-}
+{}
diff --git a/parser/testdata/03451_parameterized_views_without_alias/metadata.json b/parser/testdata/03451_parameterized_views_without_alias/metadata.json
@@ -1 +1 @@
-{"explain_todo":{"stmt2":true,"stmt4":true}}
+{}
diff --git a/parser/testdata/03453_parameterized_view_array_of_points/metadata.json b/parser/testdata/03453_parameterized_view_array_of_points/metadata.json
@@ -1,6 +1 @@
-{
-  "explain_todo": {
-    "stmt4": true,
-    "stmt6": true
-  }
-}
+{}
diff --git a/parser/testdata/03454_parameterized_view_constant_identifier/metadata.json b/parser/testdata/03454_parameterized_view_constant_identifier/metadata.json
@@ -1 +1 @@
-{"explain_todo":{"stmt2":true}}
+{}
diff --git a/parser/testdata/03454_parameterized_views_null/metadata.json b/parser/testdata/03454_parameterized_views_null/metadata.json
@@ -1 +1 @@
-{"explain_todo":{"stmt3":true}}
+{}
diff --git a/parser/testdata/03663_parameterized_views_formatting_of_substitutions_excessive_backticks/metadata.json b/parser/testdata/03663_parameterized_views_formatting_of_substitutions_excessive_backticks/metadata.json
@@ -1,6 +1,5 @@
 {
   "explain_todo": {
-    "stmt2": true,
     "stmt5": true
   }
 }
diff --git a/parser/testdata/03664_parameterized_view_restart/metadata.json b/parser/testdata/03664_parameterized_view_restart/metadata.json
@@ -1,5 +1 @@
-{
-  "explain_todo": {
-    "stmt4": true
-  }
-}
+{}

-Original file line number
+Diff line change
@@ @@ -1,5 +1 @@ @@
 -{
 -  "explain_todo": {
 -    "stmt12": true
 -  }
 -}
 +{}