Fix INSERT column list parsing to handle keyword column names

The parseInsert function was only checking for token.IDENT when parsing
column lists in INSERT statements. Column names like 'key' and 'value'
are keywords with their own tokens, so they were being skipped.

Changed to use parseIdentifierName() which handles both IDENT tokens
and keywords that can be used as identifiers.

Author: claude

parser/parser.go

@@ -1170,12 +1170,13 @@ func (p *Parser) parseInsert() *ast.InsertQuery {
 	if p.currentIs(token.LPAREN) {
 		p.nextToken()
 		for !p.currentIs(token.RPAREN) && !p.currentIs(token.EOF) {
-			if p.currentIs(token.IDENT) {
+			pos := p.current.Pos
+			colName := p.parseIdentifierName()
+			if colName != "" {
 				ins.Columns = append(ins.Columns, &ast.Identifier{
-					Position: p.current.Pos,
-					Parts:    []string{p.current.Value},
+					Position: pos,
+					Parts:    []string{colName},
 				})
-				p.nextToken()
 			}
 			if p.currentIs(token.COMMA) {
 				p.nextToken()

parser/testdata/00531_aggregate_over_nullable/metadata.json

@@ -1,7 +1 @@
-{
-  "explain_todo": {
-    "stmt4": true,
-    "stmt5": true,
-    "stmt6": true
-  }
-}
+{}

parser/testdata/00605_intersections_aggregate_functions/metadata.json

@@ -1,5 +1 @@
-{
-  "explain_todo": {
-    "stmt3": true
-  }
-}
+{}

parser/testdata/00615_nullable_alter_optimize/metadata.json

@@ -1,6 +1 @@
-{
-  "explain_todo": {
-    "stmt4": true,
-    "stmt7": true
-  }
-}
+{}

parser/testdata/00671_max_intersections/metadata.json

@@ -1,6 +1 @@
-{
-  "explain_todo": {
-    "stmt5": true,
-    "stmt6": true
-  }
-}
+{}

parser/testdata/00927_asof_joins/metadata.json

@@ -1,8 +1 @@
-{
-  "explain_todo": {
-    "stmt4": true,
-    "stmt5": true,
-    "stmt7": true,
-    "stmt8": true
-  }
-}
+{}

parser/testdata/00950_test_double_delta_codec/metadata.json

@@ -1,8 +1 @@
-{
-  "explain_todo": {
-    "stmt3": true,
-    "stmt4": true,
-    "stmt5": true,
-    "stmt6": true
-  }
-}
+{}

parser/testdata/00950_test_gorilla_codec/metadata.json

@@ -1,8 +1 @@
-{
-  "explain_todo": {
-    "stmt4": true,
-    "stmt5": true,
-    "stmt6": true,
-    "stmt7": true
-  }
-}
+{}

parser/testdata/01213_alter_rename_with_default_zookeeper_long/metadata.json

@@ -1,6 +1,5 @@
 {
   "explain_todo": {
-    "stmt13": true,
-    "stmt3": true
+    "stmt13": true
   }
 }

parser/testdata/01275_alter_rename_column_default_expr/metadata.json

@@ -1,7 +1 @@
-{
-  "explain_todo": {
-    "stmt15": true,
-    "stmt3": true,
-    "stmt9": true
-  }
-}
+{}