Commit 8fb7119
committed
Fix 25 todo tests: CAST alias, inf/nan formatting, subquery alias, named tuples
Key fixes:
- Add UsedASSyntax field to CastExpr to distinguish CAST(x AS Type) from CAST(x, 'Type')
- Fix inf/nan float formatting to use lowercase (inf, -inf, nan) matching ClickHouse
- Add NameTypePair support in FormatDataType for named tuple fields like Tuple(a UInt32)
- Display Subquery alias when present
- Update 03601 golden file for inf formatting change
Tests now passing:
- 00503_cast_const_nullable
- 00516_is_inf_nan
- 00525_aggregate_functions_of_nullable_that_return_non_nullable
- 00547_named_tuples
- 01351_geohash_assert
- 01581_to_int_inf_nan
- 01602_modified_julian_day_msan
- 01611_constant_folding_subqueries
- 01642_if_nullable_regression
- 01664_decimal_ubsan
- 01677_bit_float
- 01679_format_readable_time_delta_inf
- 01773_datetime64_add_ubsan
- 01852_cast_operator
- 02007_ipv4_and_ipv6_to_and_from_string
- 02136_scalar_subquery_metrics
- 02148_cast_type_parsing
- 02313_avro_records_and_maps
- 02366_union_decimal_conversion
- 02416_input_json_formats
- 02795_full_join_assert_cast
- 02832_transform_fixed_string_no_default
- 02921_bit_hamming_distance_big_int
- 03237_get_subcolumn_low_cardinality_column
- 03261_json_hints_types_check1 parent 21bc015 commit 8fb7119
32 files changed
Lines changed: 144 additions & 101 deletions
File tree
- ast
- internal/explain
- parser
- testdata
- 00503_cast_const_nullable
- 00516_is_inf_nan
- 00525_aggregate_functions_of_nullable_that_return_non_nullable
- 00547_named_tuples
- 01351_geohash_assert
- 01581_to_int_inf_nan
- 01602_modified_julian_day_msan
- 01611_constant_folding_subqueries
- 01642_if_nullable_regression
- 01664_decimal_ubsan
- 01677_bit_float
- 01679_format_readable_time_delta_inf
- 01773_datetime64_add_ubsan
- 01852_cast_operator
- 02007_ipv4_and_ipv6_to_and_from_string
- 02136_scalar_subquery_metrics
- 02148_cast_type_parsing
- 02313_avro_records_and_maps
- 02366_union_decimal_conversion
- 02416_input_json_formats
- 02795_full_join_assert_cast
- 02832_transform_fixed_string_no_default
- 02921_bit_hamming_distance_big_int
- 03031_low_cardinality_logical_error
- 03237_get_subcolumn_low_cardinality_column
- 03261_json_hints_types_check
- 03601_histogram_quantile
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
911 | 911 | | |
912 | 912 | | |
913 | 913 | | |
| 914 | + | |
914 | 915 | | |
915 | 916 | | |
916 | 917 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
198 | 198 | | |
199 | 199 | | |
200 | 200 | | |
201 | | - | |
| 201 | + | |
| 202 | + | |
| 203 | + | |
| 204 | + | |
| 205 | + | |
202 | 206 | | |
203 | 207 | | |
204 | 208 | | |
| |||
270 | 274 | | |
271 | 275 | | |
272 | 276 | | |
273 | | - | |
274 | | - | |
| 277 | + | |
| 278 | + | |
| 279 | + | |
| 280 | + | |
| 281 | + | |
| 282 | + | |
275 | 283 | | |
276 | 284 | | |
277 | 285 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
2 | 2 | | |
3 | 3 | | |
4 | 4 | | |
| 5 | + | |
5 | 6 | | |
6 | 7 | | |
7 | 8 | | |
| |||
10 | 11 | | |
11 | 12 | | |
12 | 13 | | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
13 | 24 | | |
14 | 25 | | |
15 | 26 | | |
| |||
161 | 172 | | |
162 | 173 | | |
163 | 174 | | |
| 175 | + | |
| 176 | + | |
| 177 | + | |
164 | 178 | | |
165 | 179 | | |
166 | 180 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
83 | 83 | | |
84 | 84 | | |
85 | 85 | | |
| 86 | + | |
| 87 | + | |
| 88 | + | |
| 89 | + | |
| 90 | + | |
| 91 | + | |
| 92 | + | |
| 93 | + | |
| 94 | + | |
| 95 | + | |
| 96 | + | |
86 | 97 | | |
87 | | - | |
| 98 | + | |
88 | 99 | | |
89 | 100 | | |
90 | 101 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
958 | 958 | | |
959 | 959 | | |
960 | 960 | | |
| 961 | + | |
961 | 962 | | |
962 | 963 | | |
963 | 964 | | |
| |||
1564 | 1565 | | |
1565 | 1566 | | |
1566 | 1567 | | |
| 1568 | + | |
| 1569 | + | |
| 1570 | + | |
| 1571 | + | |
| 1572 | + | |
| 1573 | + | |
| 1574 | + | |
| 1575 | + | |
| 1576 | + | |
| 1577 | + | |
| 1578 | + | |
| 1579 | + | |
1567 | 1580 | | |
1568 | 1581 | | |
1569 | 1582 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | | - | |
| 1 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | | - | |
| 1 | + | |
Lines changed: 1 addition & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | | - | |
| 1 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | | - | |
| 1 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | | - | |
| 1 | + | |
0 commit comments