Add JSON subcolumn type accessor syntax support

claude · claude · commit 9785146af935 · 2025-12-30T21:05:28.000Z
ClickHouse supports a special syntax for JSON path type casting:
- json.field.:`TypeName` (backtick-quoted type)
- json.field.:TypeName (unquoted type)

These are parsed as part of identifier paths and represented
as parts like ":`String`" or ":`Array(Nullable(Int64))`".

This fixes ~100 failing statements across multiple JSON-related
test files.
diff --git a/parser/expression.go b/parser/expression.go
@@ -475,6 +475,15 @@ func (p *Parser) parseIdentifierOrFunction() ast.Expression {
 			} else {
 				break
 			}
+		} else if p.currentIs(token.COLON) {
+			// JSON subcolumn type accessor: json.field.:`TypeName` or json.field.:TypeName
+			p.nextToken() // skip :
+			typePart := ":"
+			if p.currentIs(token.IDENT) || p.current.Token.IsKeyword() || p.currentIs(token.STRING) {
+				typePart += "`" + p.current.Value + "`"
+				p.nextToken()
+			}
+			parts = append(parts, typePart)
 		} else if p.currentIs(token.IDENT) || p.current.Token.IsKeyword() {
 			// Keywords can be used as column/field names (e.g., l_t.key, t.index)
 			parts = append(parts, p.current.Value)
diff --git a/parser/testdata/01825_new_type_json_10/metadata.json b/parser/testdata/01825_new_type_json_10/metadata.json
@@ -1,6 +1 @@
-{
-  "explain_todo": {
-    "stmt6": true,
-    "stmt8": true
-  }
-}
+{}
diff --git a/parser/testdata/03207_json_read_subcolumns_1_memory/metadata.json b/parser/testdata/03207_json_read_subcolumns_1_memory/metadata.json
@@ -1,40 +1,6 @@
 {
   "explain_todo": {
     "stmt14": true,
-    "stmt17": true,
-    "stmt18": true,
-    "stmt20": true,
-    "stmt21": true,
-    "stmt23": true,
-    "stmt24": true,
-    "stmt28": true,
-    "stmt29": true,
-    "stmt31": true,
-    "stmt32": true,
-    "stmt34": true,
-    "stmt35": true,
-    "stmt37": true,
-    "stmt38": true,
-    "stmt40": true,
-    "stmt41": true,
-    "stmt43": true,
-    "stmt44": true,
-    "stmt46": true,
-    "stmt47": true,
-    "stmt49": true,
-    "stmt50": true,
-    "stmt52": true,
-    "stmt53": true,
-    "stmt55": true,
-    "stmt56": true,
-    "stmt58": true,
-    "stmt59": true,
-    "stmt6": true,
-    "stmt61": true,
-    "stmt62": true,
-    "stmt66": true,
-    "stmt67": true,
-    "stmt69": true,
-    "stmt70": true
+    "stmt6": true
   }
 }
diff --git a/parser/testdata/03207_json_read_subcolumns_2_memory/metadata.json b/parser/testdata/03207_json_read_subcolumns_2_memory/metadata.json
@@ -1,60 +1,6 @@
 {
   "explain_todo": {
-    "stmt100": true,
-    "stmt101": true,
-    "stmt103": true,
-    "stmt104": true,
-    "stmt105": true,
     "stmt14": true,
-    "stmt17": true,
-    "stmt18": true,
-    "stmt19": true,
-    "stmt20": true,
-    "stmt22": true,
-    "stmt24": true,
-    "stmt25": true,
-    "stmt27": true,
-    "stmt28": true,
-    "stmt29": true,
-    "stmt36": true,
-    "stmt39": true,
-    "stmt40": true,
-    "stmt41": true,
-    "stmt42": true,
-    "stmt45": true,
-    "stmt46": true,
-    "stmt47": true,
-    "stmt48": true,
-    "stmt50": true,
-    "stmt52": true,
-    "stmt53": true,
-    "stmt55": true,
-    "stmt56": true,
-    "stmt57": true,
-    "stmt59": true,
-    "stmt6": true,
-    "stmt61": true,
-    "stmt62": true,
-    "stmt64": true,
-    "stmt65": true,
-    "stmt66": true,
-    "stmt68": true,
-    "stmt70": true,
-    "stmt71": true,
-    "stmt73": true,
-    "stmt74": true,
-    "stmt75": true,
-    "stmt77": true,
-    "stmt79": true,
-    "stmt80": true,
-    "stmt82": true,
-    "stmt83": true,
-    "stmt84": true,
-    "stmt86": true,
-    "stmt88": true,
-    "stmt89": true,
-    "stmt91": true,
-    "stmt92": true,
-    "stmt93": true
+    "stmt6": true
   }
 }
diff --git a/parser/testdata/03227_dynamic_subcolumns_enumerate_streams/metadata.json b/parser/testdata/03227_dynamic_subcolumns_enumerate_streams/metadata.json
@@ -1,5 +1 @@
-{
-  "explain_todo": {
-    "stmt6": true
-  }
-}
+{}
diff --git a/parser/testdata/03228_dynamic_subcolumns_from_subquery/metadata.json b/parser/testdata/03228_dynamic_subcolumns_from_subquery/metadata.json
@@ -1,5 +1 @@
-{
-  "explain_todo": {
-    "stmt7": true
-  }
-}
+{}
diff --git a/parser/testdata/03257_json_escape_file_names/metadata.json b/parser/testdata/03257_json_escape_file_names/metadata.json
@@ -1,5 +1 @@
-{
-  "explain_todo": {
-    "stmt7": true
-  }
-}
+{}
diff --git a/parser/testdata/03363_read_json_and_subcolumns_from_view/metadata.json b/parser/testdata/03363_read_json_and_subcolumns_from_view/metadata.json
@@ -1,5 +1 @@
-{
-  "explain_todo": {
-    "stmt11": true
-  }
-}
+{}
diff --git a/parser/testdata/03525_json_infer_array_of_dynamic_from_array_of_different_types/metadata.json b/parser/testdata/03525_json_infer_array_of_dynamic_from_array_of_different_types/metadata.json
@@ -1,6 +1 @@
-{
-  "explain_todo": {
-    "stmt8": true,
-    "stmt9": true
-  }
-}
+{}
diff --git a/parser/testdata/03620_json_advanced_shared_data_seek_bug/metadata.json b/parser/testdata/03620_json_advanced_shared_data_seek_bug/metadata.json
@@ -1,6 +1,5 @@
 {
   "explain_todo": {
-    "stmt3": true,
-    "stmt5": true
+    "stmt3": true
   }
 }
diff --git a/parser/testdata/03712_json_advanced_shared_data_bug/metadata.json b/parser/testdata/03712_json_advanced_shared_data_bug/metadata.json
@@ -1,5 +1 @@
-{
-  "explain_todo": {
-    "stmt5": true
-  }
-}
+{}
diff --git a/parser/testdata/03722_json_compact_part_substreams_cache_bug/metadata.json b/parser/testdata/03722_json_compact_part_substreams_cache_bug/metadata.json
@@ -1,5 +1 @@
-{
-  "explain_todo": {
-    "stmt5": true
-  }
-}
+{}

-Original file line number
+Diff line change
@@ @@ -1,5 +1 @@ @@
 -{
 -  "explain_todo": {
 -    "stmt6": true
 -  }
 -}
 +{}
Original file line number	Diff line number	Diff line change
`@@ -1,6 +1,5 @@`
`1`	`1`	`{`
`2`	`2`	`"explain_todo": {`
`3`		`- "stmt3": true,`
`4`		`- "stmt5": true`
	`3`	`+ "stmt3": true`
`5`	`4`	`}`
`6`	`5`	`}`