Add ORDER BY and table options support for MATERIALIZED VIEW

claude · claude · commit cf878e59c07d · 2025-12-31T08:47:56.000Z
Parse table options (ORDER BY, PRIMARY KEY, etc.) after ENGINE for
materialized views. Fixes 26 tests including stmt2 in test 03667.
diff --git a/parser/parser.go b/parser/parser.go
@@ -1973,6 +1973,9 @@ func (p *Parser) parseCreateView(create *ast.CreateQuery) {
 		create.Engine = p.parseEngineClause()
 	}
 
+	// Parse table options (ORDER BY, PRIMARY KEY, etc.) for materialized views
+	p.parseTableOptions(create)
+
 	// Parse POPULATE (for materialized views)
 	if p.currentIs(token.POPULATE) {
 		create.Populate = true
diff --git a/parser/testdata/02124_insert_deduplication_token_materialized_views/metadata.json b/parser/testdata/02124_insert_deduplication_token_materialized_views/metadata.json
@@ -1,7 +1 @@
-{
-  "explain_todo": {
-    "stmt10": true,
-    "stmt8": true,
-    "stmt9": true
-  }
-}
+{}
diff --git a/parser/testdata/02131_mv_many_chunks_bug/metadata.json b/parser/testdata/02131_mv_many_chunks_bug/metadata.json
@@ -1,5 +1 @@
-{
-  "explain_todo": {
-    "stmt4": true
-  }
-}
+{}
diff --git a/parser/testdata/02146_mv_non_phys/metadata.json b/parser/testdata/02146_mv_non_phys/metadata.json
@@ -1,5 +1 @@
-{
-  "explain_todo": {
-    "stmt2": true
-  }
-}
+{}
diff --git a/parser/testdata/02164_materialized_view_support_virtual_column/metadata.json b/parser/testdata/02164_materialized_view_support_virtual_column/metadata.json
@@ -1,5 +1 @@
-{
-  "explain_todo": {
-    "stmt4": true
-  }
-}
+{}
diff --git a/parser/testdata/02184_default_table_engine/metadata.json b/parser/testdata/02184_default_table_engine/metadata.json
@@ -3,7 +3,6 @@
     "stmt107": true,
     "stmt114": true,
     "stmt26": true,
-    "stmt46": true,
     "stmt56": true,
     "stmt61": true,
     "stmt69": true,
diff --git a/parser/testdata/02324_map_combinator_bug/metadata.json b/parser/testdata/02324_map_combinator_bug/metadata.json
@@ -1,5 +1 @@
-{
-  "explain_todo": {
-    "stmt4": true
-  }
-}
+{}
diff --git a/parser/testdata/02518_delete_on_materialized_view/metadata.json b/parser/testdata/02518_delete_on_materialized_view/metadata.json
@@ -1,6 +1,5 @@
 {
   "explain_todo": {
-    "stmt4": true,
     "stmt6": true,
     "stmt7": true
   }
diff --git a/parser/testdata/02560_analyzer_materialized_view/metadata.json b/parser/testdata/02560_analyzer_materialized_view/metadata.json
@@ -1,5 +1 @@
-{
-  "explain_todo": {
-    "stmt5": true
-  }
-}
+{}
diff --git a/parser/testdata/02912_ingestion_mv_deduplication/metadata.json b/parser/testdata/02912_ingestion_mv_deduplication/metadata.json
@@ -1,7 +1 @@
-{
-  "explain_todo": {
-    "stmt17": true,
-    "stmt29": true,
-    "stmt5": true
-  }
-}
+{}
diff --git a/parser/testdata/02943_create_query_interpreter_sample_block_fix/metadata.json b/parser/testdata/02943_create_query_interpreter_sample_block_fix/metadata.json
@@ -1,6 +1 @@
-{
-  "explain_todo": {
-    "stmt16": true,
-    "stmt4": true
-  }
-}
+{}
diff --git a/parser/testdata/03008_deduplication_cases_from_docs/metadata.json b/parser/testdata/03008_deduplication_cases_from_docs/metadata.json
@@ -1,6 +1 @@
-{
-  "explain_todo": {
-    "stmt27": true,
-    "stmt68": true
-  }
-}
+{}
diff --git a/parser/testdata/03008_deduplication_insert_into_partitioned_table/metadata.json b/parser/testdata/03008_deduplication_insert_into_partitioned_table/metadata.json
@@ -1,7 +1 @@
-{
-  "explain_todo": {
-    "stmt18": true,
-    "stmt30": true,
-    "stmt6": true
-  }
-}
+{}
diff --git a/parser/testdata/03008_deduplication_remote_insert_select/metadata.json b/parser/testdata/03008_deduplication_remote_insert_select/metadata.json
@@ -1,6 +1,5 @@
 {
   "explain_todo": {
-    "stmt14": true,
     "stmt9": true
   }
 }
diff --git a/parser/testdata/03094_virtual_column_table_name/metadata.json b/parser/testdata/03094_virtual_column_table_name/metadata.json
@@ -1,5 +1 @@
-{
-  "explain_todo": {
-    "stmt60": true
-  }
-}
+{}
diff --git a/parser/testdata/03105_table_aliases_in_mv/metadata.json b/parser/testdata/03105_table_aliases_in_mv/metadata.json
@@ -1,5 +1 @@
-{
-  "explain_todo": {
-    "stmt8": true
-  }
-}
+{}
diff --git a/parser/testdata/03107_ill_formed_select_in_materialized_view/metadata.json b/parser/testdata/03107_ill_formed_select_in_materialized_view/metadata.json
@@ -1,5 +1 @@
-{
-  "explain_todo": {
-    "stmt7": true
-  }
-}
+{}
diff --git a/parser/testdata/03143_parallel_replicas_mat_view_bug/metadata.json b/parser/testdata/03143_parallel_replicas_mat_view_bug/metadata.json
@@ -1,5 +1 @@
-{
-  "explain_todo": {
-    "stmt6": true
-  }
-}
+{}
diff --git a/parser/testdata/03161_create_table_as_mv/metadata.json b/parser/testdata/03161_create_table_as_mv/metadata.json
@@ -1,5 +1 @@
-{
-  "explain_todo": {
-    "stmt10": true
-  }
-}
+{}
diff --git a/parser/testdata/03167_transactions_are_really_disabled/metadata.json b/parser/testdata/03167_transactions_are_really_disabled/metadata.json
@@ -1,5 +1 @@
-{
-  "explain_todo": {
-    "stmt4": true
-  }
-}
+{}
diff --git a/parser/testdata/03263_analyzer_materialized_view_cte_nested/metadata.json b/parser/testdata/03263_analyzer_materialized_view_cte_nested/metadata.json
@@ -1,5 +1 @@
-{
-  "explain_todo": {
-    "stmt5": true
-  }
-}
+{}
diff --git a/parser/testdata/03282_materialized_views_ignore_errors/metadata.json b/parser/testdata/03282_materialized_views_ignore_errors/metadata.json
@@ -1,5 +1 @@
-{
-  "explain_todo": {
-    "stmt6": true
-  }
-}
+{}
diff --git a/parser/testdata/03321_inner_materialized_view_nested/metadata.json b/parser/testdata/03321_inner_materialized_view_nested/metadata.json
@@ -1,6 +1,5 @@
 {
   "explain_todo": {
-    "stmt11": true,
     "stmt5": true
   }
 }
diff --git a/parser/testdata/03357_check_contraints_null_syntax/metadata.json b/parser/testdata/03357_check_contraints_null_syntax/metadata.json
@@ -1,5 +1 @@
-{
-  "explain_todo": {
-    "stmt4": true
-  }
-}
+{}
diff --git a/parser/testdata/03460_alter_materialized_view_on_cluster/metadata.json b/parser/testdata/03460_alter_materialized_view_on_cluster/metadata.json
@@ -1,6 +1,5 @@
 {
   "explain_todo": {
-    "stmt4": true,
     "stmt6": true
   }
 }
diff --git a/parser/testdata/03667_drop_inner_table_size_limits/metadata.json b/parser/testdata/03667_drop_inner_table_size_limits/metadata.json
@@ -1,5 +1 @@
-{
-  "explain_todo": {
-    "stmt2": true
-  }
-}
+{}

Original file line number	Diff line number	Diff line change
`@@ -1973,6 +1973,9 @@ func (p Parser) parseCreateView(create ast.CreateQuery) {`
`1973`	`1973`	`create.Engine = p.parseEngineClause()`
`1974`	`1974`	`}`
`1975`	`1975`
	`1976`	`+ // Parse table options (ORDER BY, PRIMARY KEY, etc.) for materialized views`
	`1977`	`+ p.parseTableOptions(create)`
	`1978`	`+`
`1976`	`1979`	`// Parse POPULATE (for materialized views)`
`1977`	`1980`	`if p.currentIs(token.POPULATE) {`
`1978`	`1981`	`create.Populate = true`
-Original file line number
+Diff line change
@@ @@ -1,5 +1 @@ @@
 -{
 -  "explain_todo": {
 -    "stmt4": true
 -  }
 -}
 +{}
Original file line number	Diff line number	Diff line change
`@@ -1,6 +1,5 @@`
`1`	`1`	`{`
`2`	`2`	`"explain_todo": {`
`3`		`- "stmt4": true,`
`4`	`3`	`"stmt6": true,`
`5`	`4`	`"stmt7": true`
`6`	`5`	`}`