Fix database-qualified dictionary names in DETACH/ATTACH statements

The parser was not handling database-qualified dictionary names like
`db.dict` in DETACH DICTIONARY and ATTACH DICTIONARY statements.

Parser changes:
- parseDetach: Allow qualified names for DICTIONARY (database.dict)
- parseAttach: Allow qualified names for DICTIONARY (database.dict)

Explain changes:
- explainDetachQuery: Handle Database + Dictionary case
- explainAttachQuery: Handle Database + Dictionary case

Fixes tests:
- 01110_dictionary_layout_without_arguments (stmt7, stmt8)
- 01575_disable_detach_table_of_dictionary (stmt7, stmt9)
- 01018_ddl_dictionaries_create (stmt17, stmt22)

Author: claude

internal/explain/statements.go

@@ -1255,8 +1255,16 @@ func explainDetachQuery(sb *strings.Builder, n *ast.DetachQuery, indent string)
 		fmt.Fprintf(sb, "%s Identifier %s\n", indent, n.Table)
 		return
 	}
+	// Check for database-qualified dictionary name
+	if n.Database != "" && n.Dictionary != "" {
+		// Database-qualified: DetachQuery db dict (children 2)
+		fmt.Fprintf(sb, "%sDetachQuery %s %s (children 2)\n", indent, n.Database, n.Dictionary)
+		fmt.Fprintf(sb, "%s Identifier %s\n", indent, n.Database)
+		fmt.Fprintf(sb, "%s Identifier %s\n", indent, n.Dictionary)
+		return
+	}
 	// DETACH DATABASE db: Database set, Table empty -> "DetachQuery db  (children 1)"
-	if n.Database != "" && n.Table == "" {
+	if n.Database != "" && n.Table == "" && n.Dictionary == "" {
 		fmt.Fprintf(sb, "%sDetachQuery %s  (children 1)\n", indent, n.Database)
 		fmt.Fprintf(sb, "%s Identifier %s\n", indent, n.Database)
 		return
@@ -1280,7 +1288,7 @@ func explainDetachQuery(sb *strings.Builder, n *ast.DetachQuery, indent string)
 func explainAttachQuery(sb *strings.Builder, n *ast.AttachQuery, indent string, depth int) {
 	// Count children: identifier + columns definition (if any) + select query (if any) + storage/view targets (if any)
 	children := 1 // table/database identifier
-	if n.Database != "" && n.Table != "" {
+	if n.Database != "" && (n.Table != "" || n.Dictionary != "") {
 		children++ // extra identifier for database
 	}
 	hasColumns := len(n.Columns) > 0 || len(n.ColumnsPrimaryKey) > 0 || len(n.Indexes) > 0
@@ -1301,7 +1309,13 @@ func explainAttachQuery(sb *strings.Builder, n *ast.AttachQuery, indent string,
 		fmt.Fprintf(sb, "%sAttachQuery %s %s (children %d)\n", indent, n.Database, n.Table, children)
 		fmt.Fprintf(sb, "%s Identifier %s\n", indent, n.Database)
 		fmt.Fprintf(sb, "%s Identifier %s\n", indent, n.Table)
-	} else if n.Database != "" && n.Table == "" {
+	} else if n.Database != "" && n.Dictionary != "" {
+		// Database-qualified dictionary: ATTACH DICTIONARY db.dict
+		fmt.Fprintf(sb, "%sAttachQuery %s %s (children %d)\n", indent, n.Database, n.Dictionary, children)
+		fmt.Fprintf(sb, "%s Identifier %s\n", indent, n.Database)
+		fmt.Fprintf(sb, "%s Identifier %s\n", indent, n.Dictionary)
+		return // Dictionary doesn't have columns or storage
+	} else if n.Database != "" && n.Table == "" && n.Dictionary == "" {
 		fmt.Fprintf(sb, "%sAttachQuery %s  (children %d)\n", indent, n.Database, children)
 		fmt.Fprintf(sb, "%s Identifier %s\n", indent, n.Database)
 	} else if n.Table != "" {

parser/parser.go

@@ -6990,12 +6990,16 @@ func (p *Parser) parseDetach() *ast.DetachQuery {
 		p.nextToken()
 	}
 
-	// Parse name (can be qualified: database.table for TABLE, not for DATABASE/DICTIONARY)
+	// Parse name (can be qualified: database.table for TABLE, database.dict for DICTIONARY)
 	name := p.parseIdentifierName()
-	if p.currentIs(token.DOT) && !isDatabase && !isDictionary {
+	if p.currentIs(token.DOT) && !isDatabase {
 		p.nextToken()
 		detach.Database = name
-		detach.Table = p.parseIdentifierName()
+		if isDictionary {
+			detach.Dictionary = p.parseIdentifierName()
+		} else {
+			detach.Table = p.parseIdentifierName()
+		}
 	} else if isDatabase {
 		detach.Database = name
 	} else if isDictionary {
@@ -7047,12 +7051,16 @@ func (p *Parser) parseAttach() *ast.AttachQuery {
 		}
 	}
 
-	// Parse name (can be qualified: database.table for TABLE, not for DATABASE/DICTIONARY)
+	// Parse name (can be qualified: database.table for TABLE, database.dict for DICTIONARY)
 	name := p.parseIdentifierName()
-	if p.currentIs(token.DOT) && !isDatabase && !isDictionary {
+	if p.currentIs(token.DOT) && !isDatabase {
 		p.nextToken()
 		attach.Database = name
-		attach.Table = p.parseIdentifierName()
+		if isDictionary {
+			attach.Dictionary = p.parseIdentifierName()
+		} else {
+			attach.Table = p.parseIdentifierName()
+		}
 	} else if isDatabase {
 		attach.Database = name
 	} else if isDictionary {

parser/testdata/01018_ddl_dictionaries_create/metadata.json

@@ -1,6 +1 @@
-{
-  "explain_todo": {
-    "stmt17": true,
-    "stmt22": true
-  }
-}
+{}

parser/testdata/01110_dictionary_layout_without_arguments/metadata.json

@@ -1,6 +1 @@
-{
-  "explain_todo": {
-    "stmt7": true,
-    "stmt8": true
-  }
-}
+{}

parser/testdata/01575_disable_detach_table_of_dictionary/metadata.json

@@ -1,6 +1 @@
-{
-  "explain_todo": {
-    "stmt7": true,
-    "stmt9": true
-  }
-}
+{}