Add EXPLAIN settings and explicit type support#67
Merged
kyleconroy merged 2 commits intomainfrom Dec 28, 2025
Merged
Conversation
Add HasSettings and ExplicitType fields to ExplainQuery AST to properly handle EXPLAIN statements with settings (e.g., `explain header = 1`) and to correctly distinguish when the EXPLAIN type was explicitly specified. - When EXPLAIN has settings like `header = 1`, output includes a Set child - When EXPLAIN type is not explicitly specified, omit type from output (e.g., `Explain EXPLAIN` instead of `Explain EXPLAIN PLAN`) This enables 61 previously failing explain tests to pass, including the target test 01508_explain_header.
Format metadata.json files with proper indentation when updating explain_todo entries, improving readability.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add HasSettings and ExplicitType fields to ExplainQuery AST to properly
handle EXPLAIN statements with settings (e.g.,
explain header = 1) andto correctly distinguish when the EXPLAIN type was explicitly specified.
header = 1, output includes a Set child(e.g.,
Explain EXPLAINinstead ofExplain EXPLAIN PLAN)This enables 61 previously failing explain tests to pass, including the
target test 01508_explain_header.