Add analysis of explain_todo test inconsistencies#74
Closed
kyleconroy wants to merge 3 commits intomainfrom
Closed
Add analysis of explain_todo test inconsistencies#74kyleconroy wants to merge 3 commits intomainfrom
kyleconroy wants to merge 3 commits intomainfrom
Conversation
Investigation found that the 2446 explain_todo tests contain fundamental data inconsistencies that prevent systematic fixes: - LIMIT 0/FORMAT stripping varies between similar tests - SETTINGS position expectations differ for same syntax - AND/OR flattening expectations are inconsistent The root cause is that explain.txt files were generated from different ClickHouse versions. Fixes that work for explain_todo tests break existing passing tests. Detailed analysis in EXPLAIN_TODO_ANALYSIS.md
- Update ClickHouse version to 25.12.1.649 (stable) - Use ClickHouse server instead of spawning clickhouse local for each query - Process statements in parallel with configurable worker count - Add version comment stripping in parser_test.go for compare - Remove old bash generate_explain.sh script
This test ensures all explain.txt files have the same ClickHouse version header comment, which guarantees test expectations were generated from a consistent ClickHouse version. The test will fail until explain.txt files are regenerated with version headers using: go run ./cmd/regenerate-explain
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Investigation found that the 2446 explain_todo tests contain
fundamental data inconsistencies that prevent systematic fixes:
The root cause is that explain.txt files were generated from
different ClickHouse versions. Fixes that work for explain_todo
tests break existing passing tests.
Detailed analysis in EXPLAIN_TODO_ANALYSIS.md