Add TestExplainVersionConsistency and integrate ClickHouse into regenerate-explain#75
Merged
kyleconroy merged 2 commits intomainfrom Dec 29, 2025
Merged
Conversation
…erate-explain - Add TestExplainVersionConsistency test that validates all explain*.txt files have consistent ClickHouse version headers - Update cmd/regenerate-explain to download and manage ClickHouse v25.8.13.73-lts with HTTPS_PROXY support, idempotent start/stop, and version verification - Update parser tests to strip version headers when comparing EXPLAIN output - Remove scripts directory (functionality now in regenerate-explain command)
- Fix download URL to use correct v25.8.13.73-lts release - Extract clickhouse binary from tgz archive correctly - Start server in background instead of daemon mode (daemon was unreliable) - Use clickhouse client for EXPLAIN AST queries (faster than local) - Add version header to generated explain.txt files
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
have consistent ClickHouse version headers
with HTTPS_PROXY support, idempotent start/stop, and version verification