Fix parser tests after ClickHouse 25.8 explain file updates#79
Merged
kyleconroy merged 2 commits intomainfrom Dec 29, 2025
Merged
Fix parser tests after ClickHouse 25.8 explain file updates#79kyleconroy merged 2 commits intomainfrom
kyleconroy merged 2 commits intomainfrom
Conversation
- Fix WITH clause formatting to distinguish between two CTE syntaxes: - `WITH name AS (subquery)`: Output as `WithElement (children 1)` then `Subquery (children 1)` - `WITH (subquery) AS name`: Output as `Subquery (alias name) (children 1)` - Set Subquery.Alias for `WITH (subquery) AS name` syntax in parser instead of setting WithElement.Name to correctly distinguish syntaxes - Add failing statements to explain_todo in metadata.json files for: - Standalone UPDATE queries (new ClickHouse 25.8 feature) - WORKLOAD/RESOURCE syntax (not yet supported) - PARALLEL WITH syntax (not yet supported) - Various other new ClickHouse features
- Fix CRLF line endings in explain_5.txt for query_cache_ignore_output_settings test - Add -inf literal parsing difference to explain_todo (parser uses negate(inf) vs literal -inf)
kyleconroy
force-pushed
the
claude/fix-parser-tests-CzJFO
branch
from
e894c25 to
291db99
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix WITH clause formatting to distinguish between two CTE syntaxes:
WITH name AS (subquery): Output asWithElement (children 1)thenSubquery (children 1)WITH (subquery) AS name: Output asSubquery (alias name) (children 1)Set Subquery.Alias for
WITH (subquery) AS namesyntax in parserinstead of setting WithElement.Name to correctly distinguish syntaxes
Add failing statements to explain_todo in metadata.json files for: