Skip empty WindowDefinition in EXPLAIN AST output#80
Merged
kyleconroy merged 1 commit intomainfrom Dec 29, 2025
Merged
Conversation
ClickHouse's EXPLAIN AST doesn't output a WindowDefinition node when the window spec is empty (OVER ()). This fix updates the explain output to match ClickHouse's behavior by checking if the window spec has any content (PartitionBy, OrderBy, or Frame offset) before outputting WindowDefinition. Also updates metadata.json files for tests that now pass.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ClickHouse's EXPLAIN AST doesn't output a WindowDefinition node when
the window spec is empty (OVER ()). This fix updates the explain output
to match ClickHouse's behavior by checking if the window spec has any
content (PartitionBy, OrderBy, or Frame offset) before outputting
WindowDefinition.
Also updates metadata.json files for tests that now pass.