Add dictionary-related AST node types and EXPLAIN output#87
Merged
kyleconroy merged 1 commit intomainfrom Dec 29, 2025
Merged
Conversation
This change adds proper support for CREATE DICTIONARY parsing and EXPLAIN AST output: - Add new AST types: DictionaryAttributeDeclaration, DictionaryDefinition, DictionarySource, KeyValuePair, DictionaryLifetime, DictionaryLayout, DictionaryRange - Implement dictionary parsing in parseCreateDictionary() with support for: - Dictionary attributes (column definitions) - PRIMARY KEY clause - SOURCE clause with key-value pairs - LIFETIME clause - LAYOUT clause - RANGE clause - Add EXPLAIN output for dictionary nodes matching ClickHouse's format: - DictionaryAttributeDeclaration for attribute definitions - FunctionWithKeyValueArguments for SOURCE (with extra space before name) - pair (lowercase) for key-value pairs - Dictionary lifetime/layout/range sections - Update metadata.json files to remove explain_todo entries for now-passing dictionary tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change adds proper support for CREATE DICTIONARY parsing and EXPLAIN AST output:
DictionarySource, KeyValuePair, DictionaryLifetime, DictionaryLayout,
DictionaryRange
dictionary tests