feat(sqlite): disable positional indexing when sqlc.slice is present

Author: Pickle Rick

internal/endtoend/testdata/issue_4213_reuse/sqlite/go/db.go

@@ -0,0 +1,3 @@
+-- name: ReuseWithSlice :many
+SELECT * FROM mytable
+WHERE typ IN (sqlc.slice(types)) AND (name = @name OR id = @id OR name = @name);

internal/endtoend/testdata/issue_4213_reuse/sqlite/go/models.go

@@ -0,0 +1,5 @@
+CREATE TABLE mytable (
+    id INTEGER PRIMARY KEY,
+    typ INTEGER NOT NULL,
+    name TEXT NOT NULL
+);

internal/endtoend/testdata/issue_4213_reuse/sqlite/go/query.sql.go

@@ -0,0 +1,16 @@
+{
+  "version": "2",
+  "sql": [
+    {
+      "engine": "sqlite",
+      "queries": "query.sql",
+      "schema": "schema.sql",
+      "gen": {
+        "go": {
+          "package": "querytest",
+          "out": "go"
+        }
+      }
+    }
+  ]
+}

internal/endtoend/testdata/issue_4213_reuse/sqlite/query.sql

@@ -81,7 +81,20 @@ func paramFromFuncCall(call *ast.FuncCall) (named.Param, string) {
 func NamedParameters(engine config.Engine, raw *ast.RawStmt, numbs map[int]bool, dollar bool) (*ast.RawStmt, *named.ParamSet, []source.Edit) {
 	foundFunc := astutils.Search(raw, named.IsParamFunc)
 	foundSign := astutils.Search(raw, named.IsParamSign)
+
+	hasSlice := false
+	for _, item := range foundFunc.Items {
+		if call, ok := item.(*ast.FuncCall); ok && call.Func.Name == "slice" {
+			hasSlice = true
+			break
+		}
+	}
+
 	hasNamedParameterSupport := engine != config.EngineMySQL
+	if engine == config.EngineSQLite && hasSlice {
+		hasNamedParameterSupport = false
+	}
+
 	allParams := named.NewParamSet(numbs, hasNamedParameterSupport)
 
 	if len(foundFunc.Items)+len(foundSign.Items) == 0 {
@@ -108,7 +121,7 @@ func NamedParameters(engine config.Engine, raw *ast.RawStmt, numbs map[int]bool,
 					// since it's needed during template generation for replacement
 					replace = fmt.Sprintf(`/*SLICE:%s*/?`, param.Name())
 				} else {
-					if engine == config.EngineSQLite {
+					if engine == config.EngineSQLite && hasNamedParameterSupport {
 						replace = fmt.Sprintf("?%d", argn)
 					} else {
 						replace = "?"
@@ -143,7 +156,11 @@ func NamedParameters(engine config.Engine, raw *ast.RawStmt, numbs map[int]bool,
 			if engine == config.EngineMySQL || !dollar {
 				replace = "?"
 			} else if engine == config.EngineSQLite {
-				replace = fmt.Sprintf("?%d", argn)
+				if hasNamedParameterSupport {
+					replace = fmt.Sprintf("?%d", argn)
+				} else {
+					replace = "?"
+				}
 			} else {
 				replace = fmt.Sprintf("$%d", argn)
 			}
@@ -171,7 +188,11 @@ func NamedParameters(engine config.Engine, raw *ast.RawStmt, numbs map[int]bool,
 			if engine == config.EngineMySQL || !dollar {
 				replace = "?"
 			} else if engine == config.EngineSQLite {
-				replace = fmt.Sprintf("?%d", argn)
+				if hasNamedParameterSupport {
+					replace = fmt.Sprintf("?%d", argn)
+				} else {
+					replace = "?"
+				}
 			} else {
 				replace = fmt.Sprintf("$%d", argn)
 			}