-
Notifications
You must be signed in to change notification settings - Fork 1k
Add database engine plugins (external engines) #4247
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
asmyasnikov
wants to merge
57
commits into
sqlc-dev:main
Choose a base branch
from
ydb-platform:engine-plugin
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 23 commits
Commits
Show all changes
57 commits
Select commit
Hold shift + click to select a range
b6aa62d
Added support for the database engine plugin system for extending sql…
asmyasnikov 5336821
Fix of endtoend tests
asmyasnikov 2b88994
added install plugin-based-codegen's
asmyasnikov b1d156d
remove tmp file
asmyasnikov 9f65d4f
removed go.{mod,sum}
asmyasnikov 74b621f
SQLCDEBUG=processplugins=1
asmyasnikov cede5d3
Fix
asmyasnikov 15b240d
Fix
asmyasnikov 0b3b165
Apply suggestions from code review
asmyasnikov 6c5b9a6
revert Combine
asmyasnikov 7609ebc
.gitignore + README
asmyasnikov 2c74313
simplified engine API
asmyasnikov 88e6082
Apply suggestions from code review
asmyasnikov f39ae4a
Delete protos/engine/engine_grpc.pb.go
asmyasnikov 18f5368
Delete protos/engine/engine.pb.go
asmyasnikov 8eaef3c
Delete pkg/plugin/sdk.go
asmyasnikov fbaf6ba
Delete pkg/engine/engine.pb.go
asmyasnikov ce385ae
Delete pkg/plugin/codegen.pb.go
asmyasnikov a024d3e
Delete examples/plugin-based-codegen/README.md
asmyasnikov fbd5b43
Delete examples/plugin-based-codegen/gen/rust/queries.rs
asmyasnikov e6a730a
docs
asmyasnikov c8831c7
removed example
asmyasnikov 6d5770f
fix
asmyasnikov d2417e8
Update .gitignore
asmyasnikov c50e9c7
pb.go
asmyasnikov e9cc264
fix comments
asmyasnikov ad7bf6c
simplified plugin engine code
asmyasnikov 5d4c8dd
sourceFiles
asmyasnikov 131d7bb
fix
asmyasnikov 048a64d
Apply suggestions from code review
asmyasnikov 79621b0
removed temp file
asmyasnikov d9df83b
Apply suggestions from code review
asmyasnikov 55760fc
Apply suggestions from code review
asmyasnikov 96dfabd
Apply suggestions from code review
asmyasnikov 85475e2
removed engine interface
asmyasnikov 0f81f5d
merge files
asmyasnikov 7800a42
move md doc
asmyasnikov f6b34f0
Apply suggestions from code review
asmyasnikov 830767e
revert changes
asmyasnikov e4667d2
revert
asmyasnikov 9b9b3ed
docs
asmyasnikov a8fec25
fix
asmyasnikov 778b45c
fixes and tests
asmyasnikov fb7e9a6
change ParseResponse - returns multiple statements from single call
asmyasnikov 13fc9f3
Merge branch 'sqlc-dev:main' into engine-plugin
asmyasnikov 12ffdbb
fix
asmyasnikov 2e280c8
Merge branch 'sqlc-dev:main' into engine-plugin
asmyasnikov a6a4bdb
fix doc
asmyasnikov 2f48010
fix doc
asmyasnikov bd1f56e
throw error on wrong external plugin options
asmyasnikov d4ccb4d
Catalog from engine plugin
asmyasnikov b9d8139
clickhouse + YDB
asmyasnikov ec0503c
README
asmyasnikov 7f8f44e
Merge branch 'sqlc-dev:main' into engine-plugin
asmyasnikov eedd52c
Merge branch 'sqlc-dev:main' into engine-plugin
asmyasnikov 7b46024
Merge branch 'sqlc-dev:main' into engine-plugin
asmyasnikov c3d8d13
removed EngineService from protos/engine/engine.proto
asmyasnikov File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -9,3 +9,4 @@ __pycache__ | |
| .devenv* | ||
| devenv.local.nix | ||
|
|
||
| /bin/sqlc | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,175 @@ | ||
| # External Database Engines (Engine Plugins) | ||
|
|
||
| Engine plugins let you use sqlc with databases that are not built-in. You can add support for other SQL-compatible systems (e.g. CockroachDB, TiDB, or custom engines) by implementing a small external program that parses SQL and returns parameters and result columns. | ||
|
|
||
| ## Why use an engine plugin? | ||
|
|
||
| - Use sqlc with a database that doesn’t have native support. | ||
| - Reuse an existing SQL parser or dialect in a separate binary. | ||
| - Keep engine-specific logic outside the sqlc core. | ||
|
|
||
| Data returned by the engine plugin (SQL text, parameters, columns) is passed through to [codegen plugins](../guides/plugins.md) without an extra compiler/AST step. The plugin is the single place that defines how queries are interpreted for that engine. | ||
|
|
||
| ## Overview | ||
|
|
||
| An engine plugin is an external process that implements one RPC: | ||
|
|
||
| - **Parse** — accepts the query text and either schema SQL or connection parameters, and returns processed SQL, parameter list, and result columns. | ||
|
|
||
| Process plugins (e.g. written in Go) talk to sqlc over **stdin/stdout** using **Protocol Buffers**. The schema is defined in `engine/engine.proto`. | ||
|
|
||
| ## Compatibility | ||
|
|
||
| For Go plugins, compatibility is enforced at **compile time** by importing the engine package: | ||
|
|
||
| ```go | ||
| import "github.com/sqlc-dev/sqlc/pkg/engine" | ||
| ``` | ||
|
|
||
| - If the plugin builds, it matches this version of the engine API. | ||
| - If the API changes in a breaking way, the plugin stops compiling until it’s updated. | ||
|
|
||
| No version handshake is required; the proto schema defines the contract. | ||
|
|
||
| ## Configuration | ||
|
|
||
| ### sqlc.yaml | ||
|
|
||
| ```yaml | ||
| version: "2" | ||
|
|
||
| engines: | ||
| - name: mydb | ||
| process: | ||
| cmd: sqlc-engine-mydb | ||
| env: | ||
| - MYDB_DSN | ||
|
|
||
| sql: | ||
| - engine: mydb | ||
| schema: "schema.sql" | ||
| queries: "queries.sql" | ||
| codegen: | ||
| - plugin: go | ||
| out: db | ||
| ``` | ||
|
|
||
| ### Engine options | ||
|
|
||
| | Field | Description | | ||
| |-------|-------------| | ||
| | `name` | Engine name used in `sql[].engine` | | ||
| | `process.cmd` | Command to run (PATH or absolute path) | | ||
| | `env` | Environment variables passed to the plugin | | ||
|
|
||
| ## Implementing an engine plugin (Go) | ||
|
|
||
| ### 1. Dependencies and entrypoint | ||
|
|
||
| ```go | ||
| package main | ||
|
|
||
| import "github.com/sqlc-dev/sqlc/pkg/engine" | ||
|
|
||
| func main() { | ||
| engine.Run(engine.Handler{ | ||
| PluginName: "mydb", | ||
| PluginVersion: "1.0.0", | ||
| Parse: handleParse, | ||
| }) | ||
| } | ||
| ``` | ||
|
|
||
| The engine API exposes only **Parse**. There are no separate methods for catalog, keywords, comment syntax, or dialect. | ||
|
|
||
| ### 2. Parse | ||
|
|
||
| **Request** | ||
|
|
||
| - `sql` — The query text to parse. | ||
| - `schema_source` — One of: | ||
| - `schema_sql`: schema as in a schema.sql file (used for schema-based parsing). | ||
| - `connection_params`: DSN and options for database-only mode. | ||
|
|
||
| **Response** | ||
|
|
||
| - `sql` — Processed query text. Often the same as input; with a schema you may expand `*` into explicit columns. | ||
| - `parameters` — List of parameters (position/name, type, nullable, array, etc.). | ||
| - `columns` — List of result columns (name, type, nullable, table/schema if known). | ||
|
|
||
| Example handler: | ||
|
|
||
| ```go | ||
| func handleParse(req *engine.ParseRequest) (*engine.ParseResponse, error) { | ||
| sql := req.GetSql() | ||
|
|
||
| var schema *SchemaInfo | ||
| if s := req.GetSchemaSql(); s != "" { | ||
| schema = parseSchema(s) | ||
| } | ||
| // Or use req.GetConnectionParams() for database-only mode. | ||
|
|
||
| parameters := extractParameters(sql) | ||
| columns := extractColumns(sql, schema) | ||
| processedSQL := processSQL(sql, schema) // e.g. expand SELECT * | ||
|
|
||
| return &engine.ParseResponse{ | ||
| Sql: processedSQL, | ||
| Parameters: parameters, | ||
| Columns: columns, | ||
| }, nil | ||
| } | ||
| ``` | ||
|
|
||
| Parameter and column types use the `Parameter` and `Column` messages in `engine.proto` (name, position, data_type, nullable, is_array, array_dims; for columns, table_name and schema_name are optional). | ||
|
|
||
| Support for sqlc placeholders (`sqlc.arg()`, `sqlc.narg()`, `sqlc.slice()`, `sqlc.embed()`) is up to the plugin: it can parse and map them into `parameters` (and schema usage) as needed. | ||
|
|
||
| ### 3. Build and run | ||
|
|
||
| ```bash | ||
| go build -o sqlc-engine-mydb . | ||
| # Ensure sqlc-engine-mydb is on PATH or use an absolute path in process.cmd | ||
| ``` | ||
|
|
||
| ## Protocol | ||
|
|
||
| Process plugins use Protocol Buffers on stdin/stdout: | ||
|
|
||
| ``` | ||
| sqlc → stdin (protobuf) → plugin → stdout (protobuf) → sqlc | ||
| ``` | ||
|
|
||
| Invocation: | ||
|
|
||
| ```bash | ||
| sqlc-engine-mydb parse # stdin: ParseRequest, stdout: ParseResponse | ||
| ``` | ||
|
|
||
| The definition lives in `engine/engine.proto` (and generated Go in `pkg/engine`). | ||
|
|
||
| ## Example | ||
|
|
||
| A minimal engine that parses SQLite-style SQL and expands `*` using a schema is in this repository under `examples/plugin-based-codegen/plugins/sqlc-engine-sqlite3/`. It pairs with the Rust codegen example in the same `plugin-based-codegen` sample. | ||
|
|
||
| ## Architecture | ||
|
|
||
| ``` | ||
| ┌─────────────────────────────────────────────────────────────────┐ | ||
| │ sqlc generate │ | ||
| │ 1. Read sqlc.yaml, find engine for this sql block │ | ||
| │ 2. Call plugin: parse (sql + schema_sql or connection_params) │ | ||
| │ 3. Use returned sql, parameters, columns in codegen │ | ||
| └─────────────────────────────────────────────────────────────────┘ | ||
|
|
||
| sqlc sqlc-engine-mydb | ||
| │──── spawn, args: ["parse"] ──────────────────────────────► │ | ||
| │──── stdin: ParseRequest{sql, schema_sql|connection_params} ► │ | ||
| │◄─── stdout: ParseResponse{sql, parameters, columns} ─────── │ | ||
| ``` | ||
|
|
||
| ## See also | ||
|
|
||
| - [Codegen plugins](../guides/plugins.md) — Custom code generators that consume engine output. | ||
| - [Configuration reference](../reference/config.md) | ||
| - Proto schema: `protos/engine/engine.proto` |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.