Add TRIM function FROM keyword and function COLLATE support

- Handle TRIM(chars FROM string) syntax where FROM acts as parameter
  separator instead of comma
- Add COLLATE clause support for function calls in parsePostExpressionAccess

Enables Baselines140_TrimBuiltInTest140

Author: claude

parser/parse_select.go

@@ -1384,6 +1384,7 @@ func (p *Parser) parseFunctionCallFromIdentifiers(identifiers []*ast.Identifier)
 	}
 
 	// Parse parameters
+	funcNameUpper := strings.ToUpper(fc.FunctionName.Value)
 	if p.curTok.Type != TokenRParen {
 		for {
 			param, err := p.parseScalarExpression()
@@ -1392,6 +1393,12 @@ func (p *Parser) parseFunctionCallFromIdentifiers(identifiers []*ast.Identifier)
 			}
 			fc.Parameters = append(fc.Parameters, param)
 
+			// Special handling for TRIM function: FROM keyword acts as separator
+			if funcNameUpper == "TRIM" && strings.ToUpper(p.curTok.Literal) == "FROM" {
+				p.nextToken() // consume FROM
+				continue
+			}
+
 			if p.curTok.Type != TokenComma {
 				break
 			}
@@ -1587,6 +1594,13 @@ func (p *Parser) parsePostExpressionAccess(expr ast.ScalarExpression) (ast.Scala
 			fc.OverClause = overClause
 		}
 
+		// Check for COLLATE clause for function calls
+		if fc, ok := expr.(*ast.FunctionCall); ok && strings.ToUpper(p.curTok.Literal) == "COLLATE" {
+			p.nextToken() // consume COLLATE
+			fc.Collation = p.parseIdentifier()
+			continue
+		}
+
 		break
 	}
 

parser/testdata/Baselines140_TrimBuiltInTest140/metadata.json

@@ -1 +1 @@
-{"todo": true}
+{}

parser/testdata/TrimBuiltInTest140/metadata.json

@@ -1 +1 @@
-{"todo": true}
+{}