Skip to content

Add parser features and enable 12 more tests#18

Merged
kyleconroy merged 8 commits intomainfrom
claude/fix-skipped-queries-rSTMZ
Dec 18, 2025
Merged

Add parser features and enable 12 more tests#18
kyleconroy merged 8 commits intomainfrom
claude/fix-skipped-queries-rSTMZ

Conversation

@kyleconroy
Copy link
Copy Markdown
Collaborator

Add support for:

  • Cursor statements (OPEN, CLOSE, FETCH, DEALLOCATE)
  • DECLARE CURSOR statement
  • UPDATE STATISTICS statement with options
  • CREATE STATISTICS with columns and options
  • ALTER DATABASE autogrow options (AUTOGROW_ALL_FILES, AUTOGROW_SINGLE_FILE)

Enabled tests:

  • AlterDatabaseStatementTests130
  • Baselines130_AlterDatabaseStatementTests130
  • BaselinesCommon_BigIntRowCountPageCountTests
  • BigIntRowCountPageCountTests
  • BaselinesCommon_CreateStatisticsStatementTests
  • CreateStatisticsStatementTests
  • BaselinesCommon_CursorStatementsTests
  • CursorStatementsTests
  • BaselinesCommon_DeclareCursorStatementTests
  • DeclareCursorStatementTests
  • BaselinesCommon_UpdateStatisticsStatementTests
  • UpdateStatisticsStatementTests

Add support for:
- Cursor statements (OPEN, CLOSE, FETCH, DEALLOCATE)
- DECLARE CURSOR statement
- UPDATE STATISTICS statement with options
- CREATE STATISTICS with columns and options
- ALTER DATABASE autogrow options (AUTOGROW_ALL_FILES, AUTOGROW_SINGLE_FILE)

Enabled tests:
- AlterDatabaseStatementTests130
- Baselines130_AlterDatabaseStatementTests130
- BaselinesCommon_BigIntRowCountPageCountTests
- BigIntRowCountPageCountTests
- BaselinesCommon_CreateStatisticsStatementTests
- CreateStatisticsStatementTests
- BaselinesCommon_CursorStatementsTests
- CursorStatementsTests
- BaselinesCommon_DeclareCursorStatementTests
- DeclareCursorStatementTests
- BaselinesCommon_UpdateStatisticsStatementTests
- UpdateStatisticsStatementTests
- Add UseCurrent field to AlterDatabaseRemoveFileGroupStatement
- Differentiate READONLY/READWRITE (old syntax) from READ_ONLY/READ_WRITE
  - READONLY -> ReadOnlyOld
  - READ_ONLY -> ReadOnly
  - READWRITE -> ReadWriteOld
  - READ_WRITE -> ReadWrite
- Always output UseCurrent in AlterDatabaseModifyFileGroupStatement
- Update PhaseOne tests to include new fields
Implement EnableDisableTriggerStatement AST type with parsing for:
- ENABLE/DISABLE TRIGGER ALL ON table_name
- ENABLE/DISABLE TRIGGER name1, name2 ON table_name
- ENABLE/DISABLE TRIGGER name ON ALL SERVER
- ENABLE/DISABLE TRIGGER name ON DATABASE

Enable EnableDisableTriggerStatementTests and Baselines90_EnableDisableTriggerStatementTests.
…nable 3 tests

- Add DelayedDurabilityDatabaseOption type for ALTER DATABASE SET DELAYED_DURABILITY
- Parse DELAYED_DURABILITY = DISABLED/ALLOWED/FORCED values
- Add ValidationMethod, Owner, XmlSchemaCollectionName to CreateMessageTypeStatement
- Parse CREATE MESSAGE TYPE ... AUTHORIZATION ... VALIDATION = ...

Enable tests:
- AlterDatabaseOptionsTests120
- Baselines120_AlterDatabaseOptionsTests120
- Baselines90_CreateMessageTypeStatementTests
- Add ApplicationRoleOption type with OptionKind and Value fields
- Parse CREATE APPLICATION ROLE ... WITH PASSWORD/DEFAULT_SCHEMA/NAME/LOGIN
- Parse ALTER APPLICATION ROLE ... WITH options
- Strip quotes from password string literal values

Enable tests:
- ApplicationRoleStatementTests
- Baselines90_ApplicationRoleStatementTests
- Add QueueOption, QueueStateOption, QueueOptionSimple AST types
- Parse WITH clause for CREATE QUEUE and ALTER QUEUE
- Support STATUS, RETENTION, POISON_MESSAGE_HANDLING, ACTIVATION options
- Add JSON marshaling for queue options
- Enable Baselines100_QueueStatementTests100 and QueueStatementTests100
- Add IdentifierDatabaseOption and CreateDatabaseOption types
- Parse WITH LEDGER and CATALOG_COLLATION options for CREATE DATABASE
- Add JSON marshaling for new database options
- Only output AttachMode when options are present
- Enable CreateDatabaseTests160 and Baselines160_CreateDatabaseTests160
@kyleconroy kyleconroy merged commit 502c84d into main Dec 18, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants