Skip to content

Add parser features and enable 6 more tests#20

Merged
kyleconroy merged 4 commits intomainfrom
claude/fix-todo-queries-i7BnI
Dec 20, 2025
Merged

Add parser features and enable 6 more tests#20
kyleconroy merged 4 commits intomainfrom
claude/fix-todo-queries-i7BnI

Conversation

@kyleconroy
Copy link
Copy Markdown
Collaborator

Add support for:

  • CREATE/ALTER WORKLOAD GROUP with parameters
  • CREATE/ALTER SEQUENCE with options
  • DBCC statements with commands and options
  • WorkloadGroupImportanceParameter for importance values

Enable 6 workload group tests:

  • CreateAlterWorkloadGroupStatementTests110
  • Baselines110_CreateAlterWorkloadGroupStatementTests110
  • CreateAlterDropWorkloadGroupStatementTests
  • Baselines100_CreateAlterDropWorkloadGroupStatementTests
  • CreateWorkloadGroupStatementTests130
  • Baselines130_CreateWorkloadGroupStatementTests130

Add support for:
- CREATE/ALTER WORKLOAD GROUP with parameters
- CREATE/ALTER SEQUENCE with options
- DBCC statements with commands and options
- WorkloadGroupImportanceParameter for importance values

Enable 6 workload group tests:
- CreateAlterWorkloadGroupStatementTests110
- Baselines110_CreateAlterWorkloadGroupStatementTests110
- CreateAlterDropWorkloadGroupStatementTests
- Baselines100_CreateAlterDropWorkloadGroupStatementTests
- CreateWorkloadGroupStatementTests130
- Baselines130_CreateWorkloadGroupStatementTests130
- Fix DBCC statement parsing to distinguish known commands from DLLs
- Add DllName as string (not Identifier) for user-defined DBCC commands
- Fix ParenthesisRequired to only be true for empty parentheses ()
- Add more DBCC option mappings (AllConstraints, StatsStream, Histogram)
- Add DataTypeSequenceOption type for AS clause in sequence statements
- Add START WITH option for CREATE/ALTER SEQUENCE
- Fix CYCLE to use SequenceOption (not ScalarExpressionSequenceOption)
- Enable 4 tests: DbccStatementsTests, BaselinesCommon_DbccStatementsTests,
  AlterSequenceStatementTests, Baselines110_AlterSequenceStatementTests
- Add getSqlDataTypeOption() to check if type is a known SQL type
- Return UserDataTypeReference for unknown types (e.g., sysname, INTALIAS)
- Add more SQL types: JSON, CONNECTION, DATETIMEOFFSET, SMALLDATETIME
- Add UserDataTypeReference type and marshal function
@kyleconroy kyleconroy merged commit 8fa9ff9 into main Dec 20, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants