Skip to content

Add parser features and enable 15 more tests#21

Merged
kyleconroy merged 1 commit intomainfrom
claude/fix-todo-queries-duTKG
Dec 22, 2025
Merged

Add parser features and enable 15 more tests#21
kyleconroy merged 1 commit intomainfrom
claude/fix-todo-queries-duTKG

Conversation

@kyleconroy
Copy link
Copy Markdown
Collaborator

Features added:

  • String concat operator (||) and concat-equals (||=)
  • Compound assignment operators (+=, -=, *=, /=, %=, &=, |=, ^=)
  • CREATE WORKLOAD CLASSIFIER statement with options
  • SEND statement with multiple conversation handles
  • SelectSetVariable for SELECT @var = expr patterns

Bug fixes:

  • Fixed NullLiteral value to use lowercase "null"
  • Fixed StringLiteral to always include Value field (even empty)
  • Fixed WorkloadGroup parameter types
  • Fixed SeparatorType output for NotSpecified

Tests enabled:

  • StringConcatOperatorTests160 (2)
  • SendStatementTests110 (3)
  • AlterWorkloadGroupStatementSqlDwTests (2)
  • CreateWorkloadGroupStatementSqlDwTests130 (2)
  • AssignmentWithOperationTests (2)
  • CreateWorkloadClassifierStatementSqlDwTests (2)
  • FuzzyStringMatchingTests160 (2)

Features added:
- String concat operator (||) and concat-equals (||=)
- Compound assignment operators (+=, -=, *=, /=, %=, &=, |=, ^=)
- CREATE WORKLOAD CLASSIFIER statement with options
- SEND statement with multiple conversation handles
- SelectSetVariable for SELECT @var = expr patterns

Bug fixes:
- Fixed NullLiteral to preserve original case from input SQL
- Fixed StringLiteral to always include Value field (even empty)
- Fixed WorkloadGroup parameter types
- Fixed SeparatorType output for NotSpecified

Tests enabled:
- StringConcatOperatorTests160 (2)
- SendStatementTests110 (3)
- AlterWorkloadGroupStatementSqlDwTests (2)
- CreateWorkloadGroupStatementSqlDwTests130 (2)
- AssignmentWithOperationTests (2)
- CreateWorkloadClassifierStatementSqlDwTests (2)
- FuzzyStringMatchingTests160 (2)

Also updated CLAUDE.md with rule about not modifying ast.json golden files.
@kyleconroy kyleconroy force-pushed the claude/fix-todo-queries-duTKG branch from b1f22b0 to a43d303 Compare December 21, 2025 21:12
@kyleconroy kyleconroy merged commit e1f07e8 into main Dec 22, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants