Add Unicode and control character whitespace support in lexer#47
Merged
kyleconroy merged 1 commit intomainfrom Dec 23, 2025
Merged
Add Unicode and control character whitespace support in lexer#47kyleconroy merged 1 commit intomainfrom
kyleconroy merged 1 commit intomainfrom
Conversation
T-SQL treats many characters as whitespace beyond standard ASCII spaces, including control characters (0x01-0x1F) and Unicode spaces. This adds proper handling for multi-byte UTF-8 whitespace sequences including Zero Width Space (U+200B) which Go's unicode.IsSpace doesn't include. Also fixes isLetter to only handle ASCII letters, preventing UTF-8 leading bytes from being incorrectly treated as identifier characters.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
T-SQL treats many characters as whitespace beyond standard ASCII spaces,
including control characters (0x01-0x1F) and Unicode spaces. This adds
proper handling for multi-byte UTF-8 whitespace sequences including
Zero Width Space (U+200B) which Go's unicode.IsSpace doesn't include.
Also fixes isLetter to only handle ASCII letters, preventing UTF-8
leading bytes from being incorrectly treated as identifier characters.