Skip to content

Commit 0a4de46

Browse files
committed
Added router basename for navigation on Github Pages
1 parent c400a8f commit 0a4de46

2 files changed

Lines changed: 8 additions & 2 deletions

File tree

src/Visualizer/components/DatabaseMenuPopup.tsx

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,10 @@ import { DatabaseMenuPopupProps } from "../types";
44
import databases from "../../config/databases";
55

66
export function DatabaseMenuPopup(props: DatabaseMenuPopupProps) {
7+
const databaseHref = ((databaseName: string) => {
8+
return `/databases/${databaseName}`;
9+
});
10+
711
return (
812
<div
913
className="info-popup">
@@ -27,7 +31,7 @@ export function DatabaseMenuPopup(props: DatabaseMenuPopupProps) {
2731
<h3
2832
className="info-popup__database-name">
2933
{ /* design_notes/0001_using_regular_links.md */}
30-
<a href={`/databases/${databaseName}`}>{databases[databaseName].name}</a>
34+
<a href={databaseHref(databaseName)}>{databases[databaseName].name}</a>
3135
</h3>
3236

3337
<p

src/index.tsx

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,9 +8,11 @@ import "./index.css";
88

99
const root = (document.getElementById("root") as HTMLElement);
1010

11+
const basename = process.env.NODE_ENV === "production" ? "/sql_schema_visualizer" : "/";
12+
1113
ReactDOM.createRoot(root).render(
1214
<React.StrictMode>
13-
<BrowserRouter>
15+
<BrowserRouter basename={basename}>
1416
<App />
1517
</BrowserRouter>
1618
</React.StrictMode>

0 commit comments

Comments
 (0)