Skip to content

chore: added zizmor to GH Actions ci workflow #166

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tomayac merged 5 commits into from
May 22, 2026
Merged

chore: added zizmor to GH Actions ci workflow #166

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
e90415d
chore: added zizmor to GH Actions ci workflow
jurerotar May 19, 2026
72c4730
chore: actions now use pinned versions
jurerotar May 22, 2026
0dc5ff1
chore: explicit package manager cache disable
jurerotar May 22, 2026
e72b533
test: testing stricter zizmor persona
jurerotar May 22, 2026
5297087
chore: removed peter-evans/create-pull-request, added permission comment
jurerotar May 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions .github/actions/node-setup/action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,11 +8,10 @@ runs:
using: 'composite'
steps:
- name: Setup Node.js
uses: actions/setup-node@v6
uses: actions/setup-node@48b55a011bda9f5d6aeb4c2d9c7362e8dae4041e # v6.4.0
with:
node-version: ${{ inputs.node-version }}
cache: 'npm'
cache-dependency-path: package-lock.json
package-manager-cache: false

- name: Install dependencies
shell: bash
Expand Down
8 changes: 4 additions & 4 deletions .github/workflows/build-wasm.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
pull-requests: write
steps:
- name: Checkout repository
uses: actions/checkout@v6
uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
with:
persist-credentials: false

Expand Down Expand Up @@ -53,11 +53,11 @@

- name: Set up Buildx Docker CLI plugin
if: steps.check-branch.outputs.skip != 'true'
uses: docker/setup-buildx-action@v3
uses: docker/setup-buildx-action@4d04d5d9486b7bd6fa91e7baf45bbb4f8b9deedd # v4.0.0

- name: Build Docker image
if: steps.check-branch.outputs.skip != 'true'
uses: docker/build-push-action@v6
uses: docker/build-push-action@f9f3042f7e2789586610d6e8b85c8f03e5195baf # v7.2.0
with:
context: .
load: true
Expand Down Expand Up @@ -92,7 +92,7 @@

- name: Create Pull Request
if: steps.check-branch.outputs.skip != 'true' && steps.git-check.outputs.changes == 'true'
uses: peter-evans/create-pull-request@v6
uses: peter-evans/create-pull-request@5f6978faf089d4d20b00c7766989d076bb2fc7f1 # v8.1.1

Check notice

Code scanning / zizmor

action functionality is already included by the runner: use gh pr create in a script step Note

action functionality is already included by the runner: use gh pr create in a script step
Comment thread
github-advanced-security[bot] marked this conversation as resolved.
Fixed
with:
token: ${{ secrets.GITHUB_TOKEN }}
commit-message:
Expand Down
39 changes: 29 additions & 10 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,9 +24,9 @@
contents: read
steps:
- name: Checkout repo
uses: actions/checkout@v6
uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
with:
fetch-depth: 0
persist-credentials: false

- name: Set up Node.js
uses: ./.github/actions/node-setup
Expand All @@ -41,26 +41,47 @@
contents: read
steps:
- name: Checkout repo
uses: actions/checkout@v6
uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
with:
fetch-depth: 0
persist-credentials: false

- name: Setup environment (node + install)
uses: ./.github/actions/node-setup

- name: Run format check
run: npx oxfmt . --check

zizmor:
name: Zizmor GitHub Actions check
runs-on: ubuntu-latest
permissions:
actions: read

Check notice

Code scanning / zizmor

permissions without explanatory comments: needs an explanatory comment Note

permissions without explanatory comments: needs an explanatory comment
contents: read
security-events: write
steps:
- name: Checkout repository
uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
with:
persist-credentials: false

- name: Run zizmor
uses: zizmorcore/zizmor-action@5f14fd08f7cf1cb1609c1e344975f152c7ee938d # v0.5.6
with:
online-audits: true
persona: auditor
min-severity: informational
min-confidence: low

test-browser:
name: Run browser tests
runs-on: ubuntu-latest
permissions:
contents: read
steps:
- name: Checkout repo
uses: actions/checkout@v6
uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
with:
fetch-depth: 0
persist-credentials: false

- name: Setup environment (node + install)
uses: ./.github/actions/node-setup
Expand All @@ -73,7 +94,7 @@
>> $GITHUB_OUTPUT

- name: Cache Playwright browsers
uses: actions/cache@v5
uses: actions/cache@27d5ce7f107fe9357f9df03efb73ab90386fccae # v5.0.5
id: playwright-cache
with:
path: ~/.cache/ms-playwright
Expand Down Expand Up @@ -104,9 +125,7 @@
node-version: [20, 22, 23, 24, 25]
steps:
- name: Checkout repo
uses: actions/checkout@v6
with:
fetch-depth: 0
uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2

- name: Setup environment (node + install)
uses: ./.github/actions/node-setup
Expand Down
7 changes: 3 additions & 4 deletions .github/workflows/publish.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,9 +16,7 @@ jobs:
id-token: write
steps:
- name: Checkout repo
uses: actions/checkout@v6
with:
fetch-depth: 0
uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2

- name: Setup environment (node + install)
uses: ./.github/actions/node-setup
Expand All @@ -29,9 +27,10 @@ jobs:
run: npm run prepublishOnly

- name: Configure npm for OIDC trusted publishing
uses: actions/setup-node@v6
uses: actions/setup-node@48b55a011bda9f5d6aeb4c2d9c7362e8dae4041e # v6.4.0
Comment thread
github-advanced-security[bot] marked this conversation as resolved.
Fixed
with:
node-version: 24
package-manager-cache: false
registry-url: https://registry.npmjs.org

- name: Publish to npm
Expand Down