Skip to content

Commit 284d731

Browse files
committed
fix(build): add MSVC libraries for HIP_CLANG support and update linker flags
1 parent e667297 commit 284d731

1 file changed

Lines changed: 3 additions & 2 deletions

File tree

Makefile

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -128,6 +128,7 @@ ifeq ($(PLATFORM),windows)
128128
STRIP = echo "No stripping needed for MSVC"
129129
else ifeq ($(USE_HIP_CLANG),1)
130130
LDFLAGS += -shared -lbcrypt
131+
MSVC_LIBS += ucrt.lib msvcrt.lib legacy_stdio_definitions.lib
131132
DEF_FILE := $(BUILD_DIR)/ai.def
132133
STRIP = strip --strip-unneeded $@
133134
else
@@ -270,7 +271,7 @@ ifneq (,$(findstring HIP,$(LLAMA)))
270271
#-L./$(BUILD_WHISPER)/src/Release -lwhisper
271272
MINIAUDIO_LDFLAGS =
272273
#-L./$(BUILD_MINIAUDIO)/Release -lminiaudio
273-
LLAMA_LDFLAGS = -L"$(HIP_PATH)/lib" -lamdhip64 -lrocblas
274+
LLAMA_LDFLAGS = -L"$(HIP_PATH)/lib" -lamdhip64 -lrocblas -lhipblas
274275
else
275276
# MinGW linker flags (should not be used for HIP)
276277
LLAMA_LDFLAGS += -L./$(BUILD_LLAMA)/ggml/src/ggml-hip -L"$(HIP_PATH)/lib" -lggml-hip -lamdhip64 -lrocblas
@@ -318,7 +319,7 @@ ifeq ($(USE_MSVC),1)
318319
@cat $(BUILD_DIR)/link.rsp
319320
"$(VCToolsInstallDir)bin\Hostx64\x64\link.exe" @$(BUILD_DIR)/link.rsp
320321
else ifeq ($(USE_HIP_CLANG),1)
321-
$(CXX) $(OBJ_FILES) -o $@ $(LLAMA_LIBS) $(WHISPER_LIBS) $(MINIAUDIO_LIBS) $(LDFLAGS)
322+
$(CXX) $(OBJ_FILES) -o $@ $(LLAMA_LIBS) $(WHISPER_LIBS) $(MINIAUDIO_LIBS) $(LDFLAGS) $(MSVC_LIBS)
322323
else
323324
$(CXX) $(OBJ_FILES) $(DEF_FILE) -o $@ $(LDFLAGS)
324325
ifeq ($(PLATFORM),windows)

0 commit comments

Comments
 (0)