Skip to content

Commit 6a0d7a1

Browse files
committed
fix(workflow): increase timeout for build job and adjust CUDA host compiler settings for Windows
1 parent c2a6297 commit 6a0d7a1

2 files changed

Lines changed: 6 additions & 10 deletions

File tree

.github/workflows/main.yml

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ jobs:
1010
build:
1111
runs-on: ${{ matrix.os }}
1212
name: ${{ matrix.name }}${{ matrix.arch && format('-{0}', matrix.arch) || '' }} build${{ matrix.arch != 'arm64-v8a' && matrix.name != 'isim' && matrix.name != 'ios' && ' + test' || ''}}
13-
timeout-minutes: 20
13+
timeout-minutes: 30
1414
strategy:
1515
fail-fast: false
1616
matrix:
@@ -216,12 +216,11 @@ jobs:
216216
with:
217217
cuda_version: '12.4'
218218

219-
- name: windows configure cuda for mingw
219+
- name: windows build llama.cpp with cuda and msvc
220220
if: matrix.name == 'windows-cuda'
221-
run: |
222-
# Configure CUDA to use GCC instead of MSVC
223-
echo "CUDAHOSTCXX=g++" >> $GITHUB_ENV
224-
echo "CUDA_HOST_COMPILER=g++" >> $GITHUB_ENV
221+
run: make extension ${{ matrix.make && matrix.make || ''}}
222+
continue-on-error: true
223+
shell: pwsh
225224

226225
- name: windows install hip toolkit
227226
if: matrix.name == 'windows-hip'

Makefile

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -178,10 +178,7 @@ endif
178178
ifneq (,$(findstring CUDA,$(LLAMA)))
179179
LLAMA_LIBS += $(BUILD_LLAMA)/ggml/src/ggml-cuda/libggml-cuda.a
180180
LLAMA_LDFLAGS += -L./$(BUILD_LLAMA)/ggml/src/ggml-cuda $(L)ggml-cuda$(A) -lcuda -lcublas -lcublasLt -lcudart
181-
# Set CUDA host compiler for Windows MinGW builds
182-
ifeq ($(PLATFORM),windows)
183-
LLAMA_OPTIONS += -DCMAKE_CUDA_HOST_COMPILER=g++
184-
else
181+
ifneq ($(PLATFORM),windows)
185182
LLAMA_LDFLAGS += -ldl
186183
endif
187184
endif

0 commit comments

Comments
 (0)