fix(workflow): trigger when main workflow completes#11
Merged
Conversation
danielebriggi
commented
Sep 1, 2025
Member
- release or publish trigger doesn't work when the relase is done by another workflow
d028da7 to
f2c8a0b
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the workflow architecture to fix an issue where release and publish triggers don't work when releases are created by other workflows. The main change separates the release job into its own workflow that triggers after the build workflow completes.
- Extracts release job from main workflow into separate release.yml workflow
- Updates python package workflow to trigger on release workflow completion instead of GitHub release events
- Renames main workflow from "Build, Test and Release SQLite AI" to "Build and Test"
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| .github/workflows/release.yml | New workflow containing the release job extracted from main.yml |
| .github/workflows/python-package.yml | Updates trigger from release events to workflow_run completion |
| .github/workflows/main.yml | Removes release job and updates workflow name |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
- release or publish trigger doesn't work when the relase is done by another workflow
f2c8a0b to
9981f61
Compare
Gioee
approved these changes
Sep 2, 2025
Gioee
left a comment
Member
There was a problem hiding this comment.
Please double check that the job release is not removed
efde84b to
e2150c7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.