Skip to content

Commit 8c88f2f

Browse files
committed
Refactor GitHub Actions and Makefile for Windows builds; streamline conditions and improve command execution
1 parent db5d7b7 commit 8c88f2f

File tree

2 files changed

+26
-38
lines changed

2 files changed

+26
-38
lines changed

.github/workflows/main.yml

Lines changed: 5 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -269,12 +269,8 @@ jobs:
269269
with:
270270
submodules: ${{ !contains(matrix.make, 'OMIT_LOCAL_ENGINE=1') && 'true' || 'false' }}
271271

272-
- name: windows install sqlite
273-
if: matrix.name == 'windows'
274-
run: choco install sqlite -y
275-
276272
- uses: msys2/setup-msys2@v2.27.0
277-
if: matrix.name == 'windows' && matrix.variant != 'remote'
273+
if: matrix.name == 'windows'
278274
with:
279275
msystem: mingw64
280276
install: >-
@@ -318,12 +314,8 @@ jobs:
318314
if: matrix.name == 'android-aar'
319315
run: make ${{ matrix.make }}
320316

321-
- name: windows build sqlite-memory (remote)
322-
if: matrix.name == 'windows' && matrix.variant == 'remote'
323-
run: make extension ${{ matrix.make && matrix.make || ''}}
324-
325-
- name: windows build sqlite-memory (llama.cpp)
326-
if: matrix.name == 'windows' && matrix.variant != 'remote'
317+
- name: windows build sqlite-memory
318+
if: matrix.name == 'windows'
327319
shell: msys2 {0}
328320
run: make extension ${{ matrix.make && matrix.make || ''}}
329321

@@ -410,12 +402,8 @@ jobs:
410402
if: matrix.skip_test != true && matrix.os != 'windows-2022' && matrix.name != 'android'
411403
run: ${{ matrix.name == 'linux-musl' && matrix.arch == 'arm64' && 'docker exec alpine' || '' }} make test ${{ matrix.make && matrix.make || ''}}
412404

413-
- name: windows test sqlite-memory (remote)
414-
if: matrix.skip_test != true && matrix.name == 'windows' && matrix.variant == 'remote'
415-
run: make test ${{ matrix.make && matrix.make || ''}}
416-
417-
- name: windows test sqlite-memory (llama.cpp)
418-
if: matrix.skip_test != true && matrix.name == 'windows' && matrix.variant != 'remote'
405+
- name: windows test sqlite-memory
406+
if: matrix.skip_test != true && matrix.name == 'windows'
419407
shell: msys2 {0}
420408
run: make test ${{ matrix.make && matrix.make || ''}}
421409

Makefile

Lines changed: 21 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -456,29 +456,29 @@ endef
456456

457457
.PHONY: xcframework
458458
xcframework:
459-
# Build remote variant (no llama.cpp)
460-
$(MAKE) distclean && $(MAKE) PLATFORM=ios OMIT_LOCAL_ENGINE=1
461-
mv $(DIST_DIR)/memory.dylib $(DIST_DIR)/ios_remote.dylib
462-
$(MAKE) clean && $(MAKE) PLATFORM=ios-sim OMIT_LOCAL_ENGINE=1
463-
mv $(DIST_DIR)/memory.dylib $(DIST_DIR)/ios-sim_remote.dylib
464-
$(MAKE) clean && $(MAKE) PLATFORM=macos OMIT_LOCAL_ENGINE=1
465-
mv $(DIST_DIR)/memory.dylib $(DIST_DIR)/macos_remote.dylib
459+
@# Build remote variant (no llama.cpp)
460+
$(MAKE) -j1 distclean && $(MAKE) PLATFORM=ios OMIT_LOCAL_ENGINE=1 && \
461+
mv $(DIST_DIR)/memory.dylib $(DIST_DIR)/ios_remote.dylib && \
462+
$(MAKE) -j1 clean && $(MAKE) PLATFORM=ios-sim OMIT_LOCAL_ENGINE=1 && \
463+
mv $(DIST_DIR)/memory.dylib $(DIST_DIR)/ios-sim_remote.dylib && \
464+
$(MAKE) -j1 clean && $(MAKE) PLATFORM=macos OMIT_LOCAL_ENGINE=1 && \
465+
mv $(DIST_DIR)/memory.dylib $(DIST_DIR)/macos_remote.dylib
466466
$(call create_xcframework,_remote,memory-remote)
467-
# Build local variant (llama.cpp only)
468-
$(MAKE) distclean && $(MAKE) PLATFORM=ios OMIT_REMOTE_ENGINE=1 $(XCFRAMEWORK_LLAMA)
469-
mv $(DIST_DIR)/memory.dylib $(DIST_DIR)/ios_local.dylib
470-
$(MAKE) clean && $(MAKE) PLATFORM=ios-sim OMIT_REMOTE_ENGINE=1 $(XCFRAMEWORK_LLAMA)
471-
mv $(DIST_DIR)/memory.dylib $(DIST_DIR)/ios-sim_local.dylib
472-
$(MAKE) clean && $(MAKE) PLATFORM=macos OMIT_REMOTE_ENGINE=1 $(XCFRAMEWORK_LLAMA)
473-
mv $(DIST_DIR)/memory.dylib $(DIST_DIR)/macos_local.dylib
467+
@# Build local variant (llama.cpp only)
468+
$(MAKE) -j1 distclean && $(MAKE) PLATFORM=ios OMIT_REMOTE_ENGINE=1 $(XCFRAMEWORK_LLAMA) && \
469+
mv $(DIST_DIR)/memory.dylib $(DIST_DIR)/ios_local.dylib && \
470+
$(MAKE) -j1 clean && $(MAKE) PLATFORM=ios-sim OMIT_REMOTE_ENGINE=1 $(XCFRAMEWORK_LLAMA) && \
471+
mv $(DIST_DIR)/memory.dylib $(DIST_DIR)/ios-sim_local.dylib && \
472+
$(MAKE) -j1 clean && $(MAKE) PLATFORM=macos OMIT_REMOTE_ENGINE=1 $(XCFRAMEWORK_LLAMA) && \
473+
mv $(DIST_DIR)/memory.dylib $(DIST_DIR)/macos_local.dylib
474474
$(call create_xcframework,_local,memory-local)
475-
# Build full variant (both)
476-
$(MAKE) distclean && $(MAKE) PLATFORM=ios $(XCFRAMEWORK_LLAMA)
477-
mv $(DIST_DIR)/memory.dylib $(DIST_DIR)/ios_full.dylib
478-
$(MAKE) clean && $(MAKE) PLATFORM=ios-sim $(XCFRAMEWORK_LLAMA)
479-
mv $(DIST_DIR)/memory.dylib $(DIST_DIR)/ios-sim_full.dylib
480-
$(MAKE) clean && $(MAKE) PLATFORM=macos $(XCFRAMEWORK_LLAMA)
481-
mv $(DIST_DIR)/memory.dylib $(DIST_DIR)/macos_full.dylib
475+
@# Build full variant (both)
476+
$(MAKE) -j1 distclean && $(MAKE) PLATFORM=ios $(XCFRAMEWORK_LLAMA) && \
477+
mv $(DIST_DIR)/memory.dylib $(DIST_DIR)/ios_full.dylib && \
478+
$(MAKE) -j1 clean && $(MAKE) PLATFORM=ios-sim $(XCFRAMEWORK_LLAMA) && \
479+
mv $(DIST_DIR)/memory.dylib $(DIST_DIR)/ios-sim_full.dylib && \
480+
$(MAKE) -j1 clean && $(MAKE) PLATFORM=macos $(XCFRAMEWORK_LLAMA) && \
481+
mv $(DIST_DIR)/memory.dylib $(DIST_DIR)/macos_full.dylib
482482
$(call create_xcframework,_full,memory-full)
483483

484484
# ============ Android AAR ============

0 commit comments

Comments
 (0)