fix: registerPushToken - register the token at every app open

Author: damlayildiz

src/core/pushNotifications/__tests__/registerPushToken.test.ts

@@ -1,15 +1,8 @@
 import { registerPushToken } from '../registerPushToken';
 import { createLogger } from '../../common/logger';
-import {
-  ExpoSecureStore,
-  ExpoApplication,
-} from '../../common/optionalDependencies';
+import { ExpoApplication } from '../../common/optionalDependencies';
 
 jest.mock('../../common/optionalDependencies', () => ({
-  ExpoSecureStore: {
-    getItemAsync: jest.fn().mockResolvedValue(null),
-    setItemAsync: jest.fn().mockResolvedValue(undefined),
-  },
   ExpoApplication: {
     getIosIdForVendorAsync: jest.fn().mockResolvedValue('mock-ios-vendor-id'),
     getAndroidId: jest.fn().mockReturnValue('mock-android-id'),
@@ -49,16 +42,6 @@ describe('registerPushToken', () => {
     Platform.OS = 'ios';
   });
 
-  it('skips registration if token is already registered', async () => {
-    (ExpoSecureStore!.getItemAsync as jest.Mock).mockResolvedValueOnce(
-      'ExponentPushToken[abc123]'
-    );
-
-    await registerPushToken(baseParams);
-
-    expect(mockFetch).not.toHaveBeenCalled();
-  });
-
   it('sends request to the correct URL', async () => {
     await registerPushToken(baseParams);
 
@@ -135,30 +118,11 @@ describe('registerPushToken', () => {
     );
   });
 
-  it('persists token after successful registration', async () => {
+  it('registers token on every call', async () => {
+    await registerPushToken(baseParams);
     await registerPushToken(baseParams);
 
-    expect(ExpoSecureStore!.setItemAsync).toHaveBeenCalledWith(
-      'sqlite_sync_push_token_registered',
-      'ExponentPushToken[abc123]'
-    );
-  });
-
-  it('handles SecureStore read errors gracefully', async () => {
-    (ExpoSecureStore!.getItemAsync as jest.Mock).mockRejectedValueOnce(
-      new Error('SecureStore read failed')
-    );
-
-    await expect(registerPushToken(baseParams)).resolves.toBeUndefined();
-    expect(mockFetch).toHaveBeenCalled();
-  });
-
-  it('handles SecureStore write errors gracefully', async () => {
-    (ExpoSecureStore!.setItemAsync as jest.Mock).mockRejectedValueOnce(
-      new Error('SecureStore write failed')
-    );
-
-    await expect(registerPushToken(baseParams)).resolves.toBeUndefined();
+    expect(mockFetch).toHaveBeenCalledTimes(2);
   });
 
   it('throws when ExpoApplication is null', async () => {

src/core/pushNotifications/registerPushToken.ts

@@ -1,12 +1,7 @@
-import {
-  ExpoSecureStore,
-  ExpoApplication,
-} from '../common/optionalDependencies';
+import { ExpoApplication } from '../common/optionalDependencies';
 import type { Logger } from '../common/logger';
 import { CLOUDSYNC_BASE_URL } from '../constants';
 
-const TOKEN_REGISTERED_KEY = 'sqlite_sync_push_token_registered';
-
 async function getDeviceId(): Promise<string> {
   if (!ExpoApplication) {
     throw new Error(
@@ -34,7 +29,7 @@ interface RegisterPushTokenParams {
 
 /**
  * Register an Expo push token with the SQLite Cloud backend.
- * Only sends the token once per installation (persisted via SecureStore).
+ * Sends the token on every call to ensure the backend always has a valid token.
  */
 export async function registerPushToken(
   params: RegisterPushTokenParams
@@ -49,21 +44,6 @@ export async function registerPushToken(
     logger,
   } = params;
 
-  /** CHECK IF ALREADY REGISTERED */
-  if (ExpoSecureStore) {
-    try {
-      const registered = await ExpoSecureStore.getItemAsync(
-        TOKEN_REGISTERED_KEY
-      );
-      if (registered === expoToken) {
-        logger.info('📱 Push token already registered, skipping');
-        return;
-      }
-    } catch {
-      // Continue with registration
-    }
-  }
-
   /** PREPARE REQUEST HEADERS */
   const headers: Record<string, string> = {
     'Content-Type': 'application/json',
@@ -93,11 +73,6 @@ export async function registerPushToken(
   const url = `${CLOUDSYNC_BASE_URL}/v2/cloudsync/databases/${encodeURIComponent(
     databaseId
   )}/notifications/tokens`;
-  logger.info(
-    '📱 Registering push token with backend...',
-    url,
-    JSON.stringify(body)
-  );
 
   const response = await fetch(url, {
     method: 'PUT',
@@ -113,13 +88,4 @@ export async function registerPushToken(
   }
 
   logger.info('📱 Push token registered successfully');
-
-  /** PERSIST REGISTRATION STATUS */
-  if (ExpoSecureStore) {
-    try {
-      await ExpoSecureStore.setItemAsync(TOKEN_REGISTERED_KEY, expoToken);
-    } catch {
-      // Non-critical
-    }
-  }
 }