fix: isSqliteCloudNotification

Author: damlayildiz

src/core/pushNotifications/isSqliteCloudNotification.ts

@@ -0,0 +1,46 @@
+const ARTIFACT_URI = 'https://sqlite.ai';
+
+/**
+ * Check if a foreground Expo Notification is from SQLite Cloud.
+ * Foreground notifications use the Expo Notification object structure:
+ * `notification.request.content.data.artifactURI`
+ */
+export const isForegroundSqliteCloudNotification = (
+  notification: any
+): boolean => {
+  const artifactURI = notification?.request?.content?.data?.artifactURI;
+  return artifactURI === ARTIFACT_URI;
+};
+
+/**
+ * Check if background/terminated task data is from SQLite Cloud.
+ * Handles platform differences:
+ * - iOS: `data.body` is an object with `artifactURI`
+ * - Android: `data.body` or `data.dataString` is a JSON string containing `artifactURI`
+ * Also checks the foreground structure as a fallback.
+ */
+export const isSqliteCloudNotification = (notification: any): boolean => {
+  const body = notification?.data?.body;
+
+  // iOS background
+  if (body && typeof body === 'object' && body.artifactURI === ARTIFACT_URI) {
+    return true;
+  }
+
+  // Android background
+  const bodyString =
+    typeof body === 'string' ? body : notification?.data?.dataString;
+  if (typeof bodyString === 'string') {
+    try {
+      const parsed = JSON.parse(bodyString);
+      if (parsed?.artifactURI === ARTIFACT_URI) {
+        return true;
+      }
+    } catch {
+      // Not valid JSON
+    }
+  }
+
+  // Foreground notification structure (fallback)
+  return isForegroundSqliteCloudNotification(notification);
+};

src/core/pushNotifications/pushNotificationSyncTask.ts

@@ -5,33 +5,7 @@ import { createLogger } from '../common/logger';
 import { BACKGROUND_SYNC_TASK_NAME } from '../constants';
 import { executeBackgroundSync } from '../background/executeBackgroundSync';
 import { getForegroundSyncCallback } from './pushNotificationSyncCallbacks';
-
-/**
- * Check if task data is from SQLite Cloud.
- * Handles different data structures from foreground vs background notifications.
- */
-const isSqliteCloudNotification = (taskData: any): boolean => {
-  // Background notification: data is in taskData.data.body (as JSON string)
-  const bodyString = taskData?.data?.body || taskData?.data?.dataString;
-  if (bodyString) {
-    try {
-      const parsed = JSON.parse(bodyString);
-      if (parsed?.artifactURI === 'https://sqlite.ai') {
-        return true;
-      }
-    } catch {
-      // Not valid JSON
-    }
-  }
-
-  // Foreground notification structure
-  const artifactURI = taskData?.request?.content?.data?.artifactURI;
-  if (artifactURI === 'https://sqlite.ai') {
-    return true;
-  }
-
-  return false;
-};
+import { isSqliteCloudNotification } from './isSqliteCloudNotification';
 
 /**
  * Auto-define background task at module level.

src/core/pushNotifications/usePushNotificationSync.ts

@@ -97,13 +97,7 @@ export interface PushNotificationSyncParams {
   onBeforePushPermissionRequest?: () => Promise<boolean>;
 }
 
-/**
- * Check if a notification is from SQLite Cloud
- */
-const isSqliteCloudNotification = (notification: any): boolean => {
-  const artifactURI = notification?.request?.content?.data?.artifactURI;
-  return artifactURI === 'https://sqlite.ai';
-};
+import { isForegroundSqliteCloudNotification } from './isSqliteCloudNotification';
 
 export function usePushNotificationSync(
   params: PushNotificationSyncParams
@@ -279,7 +273,7 @@ export function usePushNotificationSync(
           JSON.stringify(notification, null, 2)
         );
 
-        if (isSqliteCloudNotification(notification)) {
+        if (isForegroundSqliteCloudNotification(notification)) {
           logger.info(
             '📲 SQLite Cloud notification (foreground) - triggering sync'
           );