fix(cluster): clang-format spec-5.16 sources for fast-gate Validate

Session-1 5.16 sources (cluster_debug.c, cluster_gcs_block.{c,h}, cluster_guc.c,
cluster_grd.h, test_cluster_grd.c) carried clang-format v18 violations that were
never CI-checked while connectivity was down.  No functional change.

Author: SqlRush

src/backend/cluster/cluster_debug.c

@@ -1128,8 +1128,7 @@ dump_grd_recovery(ReturnSetInfo *rsinfo)
 	 * category; no new dump category, §8 Q6-A). */
 	emit_row(rsinfo, "grd_recovery", "join_remaster_started",
 			 fmt_int64((int64)c.join_remaster_started));
-	emit_row(rsinfo, "grd_recovery", "join_remaster_done",
-			 fmt_int64((int64)c.join_remaster_done));
+	emit_row(rsinfo, "grd_recovery", "join_remaster_done", fmt_int64((int64)c.join_remaster_done));
 	emit_row(rsinfo, "grd_recovery", "join_shards_remastered",
 			 fmt_int64((int64)c.join_shards_remastered));
 	emit_row(rsinfo, "grd_recovery", "join_block_views_rebuilt",

src/backend/cluster/cluster_gcs_block.c

@@ -49,8 +49,8 @@
 #include "cluster/cluster_gcs_block_dedup.h" /* spec-2.34 D1 — counter forward */
 #include "cluster/cluster_grd.h"			 /* spec-4.6 D4 — block_path_failclosed counter */
 #include "cluster/cluster_grd_outbound.h"
-#include "cluster/cluster_membership.h" /* spec-5.16 D3b — is_member master-side gate */
-#include "cluster/cluster_qvotec.h"		/* spec-5.16 D3b — in_quorum master-side gate */
+#include "cluster/cluster_membership.h"		/* spec-5.16 D3b — is_member master-side gate */
+#include "cluster/cluster_qvotec.h"			/* spec-5.16 D3b — in_quorum master-side gate */
 #include "cluster/cluster_recovery_merge.h" /* spec-4.7 D5 — recovered_through redo gate */
 #include "cluster/cluster_guc.h"
 #include "cluster/cluster_inject.h"
@@ -676,8 +676,7 @@ cluster_gcs_block_phase_for_tag(BufferTag tag)
 	 * the optimization; the master-side hard gate (cluster_gcs_handle_block_
 	 * request_envelope) is the correctness backstop for stale-view requesters.
 	 */
-	if (cluster_grd_join_remaster_active_for_shard(tag)
-		&& !cluster_grd_block_view_rebuilt(tag)) {
+	if (cluster_grd_join_remaster_active_for_shard(tag) && !cluster_grd_block_view_rebuilt(tag)) {
 		cluster_grd_inc_join_block_failclosed();
 		return GCS_BLOCK_RECOVERING;
 	}

src/backend/cluster/cluster_guc.c

@@ -2237,16 +2237,16 @@ cluster_init_guc(void)
 	 * PCM block snap-back fence is NOT gated here (it is forced correctness
 	 * bound to cluster.online_join, INV-R13); this only controls whether the
 	 * joiner's home-shard GES mastership is moved back from the survivor. */
-	DefineCustomBoolVariable("cluster.join_remaster_enabled",
-							 gettext_noop("On node rejoin, move the joiner's home-shard GES "
-										  "mastership back from the survivor (optional rebalance)."),
-							 gettext_noop("Default off: the joiner's logical-lock mastership stays "
-										  "on the survivor that held it during the absence (load "
-										  "imbalance only).  The PCM block view rebuild + RECOVERING "
-										  "fence always run when cluster.online_join is on, "
-										  "independent of this GUC (forced correctness)."),
-							 &cluster_join_remaster_enabled, false, PGC_POSTMASTER, 0, NULL, NULL,
-							 NULL);
+	DefineCustomBoolVariable(
+		"cluster.join_remaster_enabled",
+		gettext_noop("On node rejoin, move the joiner's home-shard GES "
+					 "mastership back from the survivor (optional rebalance)."),
+		gettext_noop("Default off: the joiner's logical-lock mastership stays "
+					 "on the survivor that held it during the absence (load "
+					 "imbalance only).  The PCM block view rebuild + RECOVERING "
+					 "fence always run when cluster.online_join is on, "
+					 "independent of this GUC (forced correctness)."),
+		&cluster_join_remaster_enabled, false, PGC_POSTMASTER, 0, NULL, NULL, NULL);
 
 	DefineCustomIntVariable("cluster.join_convergence_timeout_ms",
 							gettext_noop("Deadline for an online join to converge + commit."),

src/include/cluster/cluster_gcs_block.h

@@ -171,7 +171,8 @@ typedef enum GcsBlockReplyStatus {
 													 * 8.A: a cached copy with no
 													 * invalidation path would go stale).
 													 * Reuses HC103 copy-ship + HC127
-													 * watermark. */,
+													 * watermark. */
+	,
 	GCS_BLOCK_REPLY_DENIED_RESOURCE_RECOVERING = 14 /* PGRAC: spec-5.16 D3b NEW;
 													 * master-side hard gate (INV-R8/R14)
 													 * — the master (a rejoining node) is

src/include/cluster/cluster_grd.h

@@ -365,11 +365,11 @@ typedef struct ClusterGrdShared {
 	/* spec-5.16 D5 — join-direction remaster counters (dump_grd grd_recovery
 	 * segment;  kept distinct from the failure-driven remaster_* counters so
 	 * ops can tell the two remaster kinds apart — §8 Q6-A). */
-	pg_atomic_uint64 join_remaster_started_count;			   /* JOIN episode entered */
-	pg_atomic_uint64 join_remaster_done_count;				   /* JOIN episode reached IDLE */
-	pg_atomic_uint64 join_shards_remastered_count;			   /* GRD shards moved to joiner */
-	pg_atomic_uint64 join_block_views_rebuilt_count;		   /* joiner-home fences lifted */
-	pg_atomic_uint64 join_block_recovering_failclosed_count;   /* 53R9L denied (both gates) */
+	pg_atomic_uint64 join_remaster_started_count;			 /* JOIN episode entered */
+	pg_atomic_uint64 join_remaster_done_count;				 /* JOIN episode reached IDLE */
+	pg_atomic_uint64 join_shards_remastered_count;			 /* GRD shards moved to joiner */
+	pg_atomic_uint64 join_block_views_rebuilt_count;		 /* joiner-home fences lifted */
+	pg_atomic_uint64 join_block_recovering_failclosed_count; /* 53R9L denied (both gates) */
 } ClusterGrdShared;
 
 /* spec-2.17 D28b — extern atomic generation alloc helper(InitProcess hook). */

src/test/cluster_unit/test_cluster_grd.c

@@ -3288,7 +3288,7 @@ ut_jr_setup_3node(void)
 	int32 nodes3[] = { 0, 1, 2 };
 
 	ut_mock_epoch = 0;
-	ut_member_mask = -1;	  /* all members */
+	ut_member_mask = -1; /* all members */
 	ut_mock_static_master = 0;
 	ut_reset_grd_shmem(); /* clean fence / recovery_done_epoch / direction */
 	cluster_grd_shmem_init();
@@ -3559,15 +3559,13 @@ UT_TEST(test_jr_u15_master_side_gate_decision)
 	ut_mock_static_master = 1;
 
 	/* The gate's home-block leg: active_for_shard && !view_rebuilt. */
-	deny = cluster_grd_join_remaster_active_for_shard(tag)
-		   && !cluster_grd_block_view_rebuilt(tag);
+	deny = cluster_grd_join_remaster_active_for_shard(tag) && !cluster_grd_block_view_rebuilt(tag);
 	UT_ASSERT(deny);
 
 	cluster_grd_recovery_mark_peer_done(0, 10);
 	cluster_grd_recovery_mark_peer_done(1, 10);
 	cluster_grd_recovery_mark_peer_done(2, 10);
-	deny = cluster_grd_join_remaster_active_for_shard(tag)
-		   && !cluster_grd_block_view_rebuilt(tag);
+	deny = cluster_grd_join_remaster_active_for_shard(tag) && !cluster_grd_block_view_rebuilt(tag);
 	UT_ASSERT(!deny);
 }