Comment out stuff in the play closure on develop to prevent accidental shipping

rock3r · rock3r · commit 37f2b57ffebe · 2018-04-16T11:58:53.000+01:00
Don't be like me, kids, practice safe build script maintenance
diff --git a/app/build.gradle b/app/build.gradle
@@ -96,7 +96,13 @@ private static boolean isNotRunningOnCI() {
 }
 
 play {
-    jsonFile = teamPropsFile('play-store-keys.json')
+    // TODO uncomment these lines if you want to be able to publish to the Play Store, but *ONLY* do it
+    // on a release branch or you'll risk shipping random stuff to the Store (don't ask)
+
+//    jsonFile = teamPropsFile('play-store-keys.json')
+//    errorOnSizeLimit = true
+//    uploadImages = true
+//    track = 'production'
 }
 
 detekt {

Original file line number	Diff line number	Diff line change
`@@ -96,7 +96,13 @@ private static boolean isNotRunningOnCI() {`
`96`	`96`	`}`
`97`	`97`
`98`	`98`	`play {`
`99`		`- jsonFile = teamPropsFile('play-store-keys.json')`
	`99`	`+ // TODO uncomment these lines if you want to be able to publish to the Play Store, but ONLY do it`
	`100`	`+ // on a release branch or you'll risk shipping random stuff to the Store (don't ask)`
	`101`	`+`
	`102`	`+// jsonFile = teamPropsFile('play-store-keys.json')`
	`103`	`+// errorOnSizeLimit = true`
	`104`	`+// uploadImages = true`
	`105`	`+// track = 'production'`
`100`	`106`	`}`
`101`	`107`
`102`	`108`	`detekt {`