Skip to content
This repository was archived by the owner on Feb 17, 2020. It is now read-only.

Commit 3caf33e

Browse files
committed
Use constants for boolean strings
1 parent 5d5c0c7 commit 3caf33e

1 file changed

Lines changed: 9 additions & 4 deletions

File tree

app/src/main/java/net/squanchy/analytics/Analytics.kt

Lines changed: 9 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -82,22 +82,22 @@ class Analytics internal constructor(
8282

8383
fun trackNotificationsEnabled() {
8484
firebaseAnalytics.setUserProperty("notifications_status", "enabled")
85-
firebaseAnalytics.logEvent("notifications_status_changed", flagEnabled("true"))
85+
firebaseAnalytics.logEvent("notifications_status_changed", flagEnabled(TRUE))
8686
}
8787

8888
fun trackNotificationsDisabled() {
8989
firebaseAnalytics.setUserProperty("notifications_status", "disabled")
90-
firebaseAnalytics.logEvent("notifications_status_changed", flagEnabled("false"))
90+
firebaseAnalytics.logEvent("notifications_status_changed", flagEnabled(FALSE))
9191
}
9292

9393
fun trackFavoritesInScheduleEnabled() {
9494
firebaseAnalytics.setUserProperty("favorites_in_schedule", "enable")
95-
firebaseAnalytics.logEvent("favorites_in_schedule_changed", flagEnabled("true"))
95+
firebaseAnalytics.logEvent("favorites_in_schedule_changed", flagEnabled(TRUE))
9696
}
9797

9898
fun trackFavoritesInScheduleDisabled() {
9999
firebaseAnalytics.setUserProperty("favorites_in_schedule", "disabled")
100-
firebaseAnalytics.logEvent("favorites_in_schedule_changed", flagEnabled("false"))
100+
firebaseAnalytics.logEvent("favorites_in_schedule_changed", flagEnabled(FALSE))
101101
}
102102

103103
private fun flagEnabled(value: String) = Bundle().apply { putString("enabled", value) }
@@ -126,4 +126,9 @@ class Analytics internal constructor(
126126
}
127127
firebaseAnalytics.logEvent("wifi_config", params)
128128
}
129+
130+
companion object {
131+
private const val TRUE = "true"
132+
private const val FALSE = "false"
133+
}
129134
}

0 commit comments

Comments
 (0)