Add missing onError's

Author: rock3r

app/src/main/java/net/squanchy/eventdetails/EventDetailsActivity.kt

@@ -16,6 +16,7 @@ import net.squanchy.notification.NotificationsIntentService
 import net.squanchy.schedule.domain.view.Event
 import net.squanchy.signin.SignInOrigin
 import net.squanchy.speaker.domain.view.Speaker
+import timber.log.Timber
 
 class EventDetailsActivity : AppCompatActivity() {
 
@@ -65,7 +66,10 @@ class EventDetailsActivity : AppCompatActivity() {
         subscriptions.add(
             service.event(eventId)
                 .observeOn(AndroidSchedulers.mainThread())
-                .subscribe { event -> eventDetailsRoot.updateWith(event, onEventDetailsClickListener(event)) }
+                .subscribe(
+                    { event -> eventDetailsRoot.updateWith(event, onEventDetailsClickListener(event)) },
+                    Timber::e
+                )
         )
     }
 
@@ -78,17 +82,22 @@ class EventDetailsActivity : AppCompatActivity() {
             override fun onFavoriteClick() {
                 subscriptions.add(
                     service.toggleFavorite(event)
-                        .subscribe { result ->
-                            if (result === EventDetailsService.FavoriteResult.MUST_AUTHENTICATE) {
-                                requestSignIn()
-                            } else {
-                                triggerNotificationService()
-                            }
-                        }
+                        .subscribe(
+                            onFavouriteStateChange(),
+                            Timber::e
+                        )
                 )
             }
         }
 
+    private fun onFavouriteStateChange() = { result: EventDetailsService.FavoriteResult ->
+        if (result === EventDetailsService.FavoriteResult.MUST_AUTHENTICATE) {
+            requestSignIn()
+        } else {
+            triggerNotificationService()
+        }
+    }
+
     private fun requestSignIn() {
         navigator.toSignInForResult(REQUEST_CODE_SIGNIN, SignInOrigin.EVENT_DETAILS)
         unsubscribeFromUpdates()

app/src/main/java/net/squanchy/favorites/FavoritesPageView.kt

@@ -9,6 +9,7 @@ import io.reactivex.Observable
 import io.reactivex.android.schedulers.AndroidSchedulers
 import io.reactivex.disposables.CompositeDisposable
 import io.reactivex.functions.BiFunction
+import io.reactivex.schedulers.Schedulers
 import kotlinx.android.synthetic.main.view_page_favorites.view.*
 import net.squanchy.R
 import net.squanchy.analytics.Analytics
@@ -19,6 +20,7 @@ import net.squanchy.home.Loadable
 import net.squanchy.navigation.Navigator
 import net.squanchy.schedule.domain.view.Event
 import net.squanchy.support.unwrapToActivityContext
+import timber.log.Timber
 
 class FavoritesPageView @JvmOverloads constructor(
     context: Context?,
@@ -63,8 +65,9 @@ class FavoritesPageView @JvmOverloads constructor(
                 favoritesService.currentUserIsSignedIn(),
                 BiFunction<List<FavoritesItem>, Boolean, LoadResult>(::LoadResult)
             )
+                .subscribeOn(Schedulers.io())
                 .observeOn(AndroidSchedulers.mainThread())
-                .subscribe(::handleLoadSchedule)
+                .subscribe(::handleLoadSchedule, Timber::e)
         )
     }
 

app/src/main/java/net/squanchy/schedule/tracksfilter/ScheduleTracksFilter.kt

@@ -24,6 +24,7 @@ import net.squanchy.schedule.domain.view.Track
 import net.squanchy.service.repository.TracksRepository
 import net.squanchy.support.view.setAdapterIfNone
 import net.squanchy.support.widget.OriginCoordinates
+import timber.log.Timber
 import kotlin.math.hypot
 
 class ScheduleTracksFilterActivity : AppCompatActivity() {
@@ -118,11 +119,14 @@ class ScheduleTracksFilterActivity : AppCompatActivity() {
             .distinctUntilChanged()
             .subscribeOn(Schedulers.computation())
             .observeOn(AndroidSchedulers.mainThread())
-            .subscribe { checkableTracks ->
-                trackFiltersList.setAdapterIfNone(trackAdapter)
-                this.checkableTracks = checkableTracks
-                trackAdapter.submitList(checkableTracks)
-            }
+            .subscribe(
+                { checkableTracks ->
+                    trackFiltersList.setAdapterIfNone(trackAdapter)
+                    this.checkableTracks = checkableTracks
+                    trackAdapter.submitList(checkableTracks)
+                },
+                Timber::e
+            )
     }
 
     private fun prepareAppearAnimation() {

app/src/main/java/net/squanchy/settings/SettingsFragment.kt

@@ -24,6 +24,7 @@ import net.squanchy.signin.SignInService
 import net.squanchy.support.lang.getOrThrow
 import net.squanchy.wificonfig.WifiConfigOrigin
 import net.squanchy.wificonfig.WifiConfigService
+import timber.log.Timber
 
 class SettingsFragment : PreferenceFragment() {
 
@@ -131,7 +132,7 @@ class SettingsFragment : PreferenceFragment() {
         subscriptions.add(
             signInService.currentUser()
                 .observeOn(AndroidSchedulers.mainThread())
-                .subscribe(::onUserChanged)
+                .subscribe(::onUserChanged, Timber::e)
         )
     }
 
@@ -157,10 +158,13 @@ class SettingsFragment : PreferenceFragment() {
         accountSignInSignOutPreference.setOnPreferenceClickListener {
             subscriptions.add(
                 signInService.signOut()
-                    .subscribe {
-                        Snackbar.make(viewOrThrow, R.string.settings_message_signed_out, Snackbar.LENGTH_SHORT).show()
-                        analytics.trackUserNotLoggedIn()
-                    }
+                    .subscribe(
+                        {
+                            Snackbar.make(viewOrThrow, R.string.settings_message_signed_out, Snackbar.LENGTH_SHORT).show()
+                            analytics.trackUserNotLoggedIn()
+                        },
+                        Timber::e
+                    )
             )
             return@setOnPreferenceClickListener true
         }

app/src/main/java/net/squanchy/signin/SignInActivity.kt

@@ -19,6 +19,7 @@ import net.squanchy.R
 import net.squanchy.analytics.Analytics
 import net.squanchy.google.GoogleClientId
 import net.squanchy.support.config.DialogLayoutParameters
+import timber.log.Timber
 
 class SignInActivity : AppCompatActivity() {
 
@@ -111,11 +112,14 @@ class SignInActivity : AppCompatActivity() {
 
         subscription = service.signInWithGoogle(account)
             .subscribeOn(AndroidSchedulers.mainThread())
-            .subscribe {
-                analytics.trackUserLoggedInFrom(getSignInOrigin())
-                setResult(RESULT_OK)
-                finish()
-            }
+            .subscribe(
+                {
+                    analytics.trackUserLoggedInFrom(getSignInOrigin())
+                    setResult(RESULT_OK)
+                    finish()
+                },
+                Timber::e
+            )
     }
 
     private fun getSignInOrigin() = intent.getSerializableExtra(EXTRA_SIGN_IN_ORIGIN) as SignInOrigin

app/src/main/java/net/squanchy/venue/VenueInfoPageView.kt

@@ -16,6 +16,7 @@ import net.squanchy.navigation.Navigator
 import net.squanchy.support.text.parseHtml
 import net.squanchy.support.unwrapToActivityContext
 import net.squanchy.venue.domain.view.Venue
+import timber.log.Timber
 
 class VenueInfoPageView @JvmOverloads constructor(
     context: Context,
@@ -66,7 +67,7 @@ class VenueInfoPageView @JvmOverloads constructor(
     override fun startLoading() {
         subscription = service.venue()
             .observeOn(AndroidSchedulers.mainThread())
-            .subscribe(::updateWith)
+            .subscribe(::updateWith, Timber::e)
     }
 
     private fun updateWith(venue: Venue) {