Don't show favourite icon in favourite items

Author: rock3r

app/src/main/java/net/squanchy/favorites/view/FavoritesViewHolders.kt

@@ -19,7 +19,7 @@ sealed class FavoritesViewHolder<T : View>(itemView: T) : RecyclerView.ViewHolde
 class EventViewHolder(itemView: EventItemView) : FavoritesViewHolder<EventItemView>(itemView) {
 
     fun updateWith(event: Event, listener: OnEventClickListener?) {
-        (itemView as EventItemView).updateWith(event, false) // TODO import the feature flag here as well
+        (itemView as EventItemView).updateWith(event, showRoom = true, showFavorite = false)
         itemView.setOnClickListener { listener?.invoke(event) }
     }
 }

app/src/main/java/net/squanchy/schedule/view/EventItemView.kt

@@ -12,5 +12,5 @@ abstract class EventItemView : CardLayout {
 
     constructor(context: Context, attrs: AttributeSet, defStyleAttr: Int) : super(context, attrs, defStyleAttr)
 
-    abstract fun updateWith(event: Event, showRoom: Boolean = false, showDay: Boolean = false)
+    abstract fun updateWith(event: Event, showRoom: Boolean = false, showDay: Boolean = false, showFavorite: Boolean = true)
 }

app/src/main/java/net/squanchy/schedule/view/OtherEventItemView.kt

@@ -14,7 +14,7 @@ class OtherEventItemView @JvmOverloads constructor(
     defStyleAttr: Int = R.attr.cardViewDefaultStyle
 ) : EventItemView(context, attrs, defStyleAttr) {
 
-    override fun updateWith(event: Event, showRoom: Boolean, showDay: Boolean) {
+    override fun updateWith(event: Event, showRoom: Boolean, showDay: Boolean, showFavorite: Boolean) {
         event.type.ensureSupported()
 
         timestamp.text = startTimeAsFormattedString(event)

app/src/main/java/net/squanchy/schedule/view/TalkEventItemView.kt

@@ -20,7 +20,7 @@ class TalkEventItemView @JvmOverloads constructor(
     private val timeFormatter = DateTimeFormat.shortTime()
     private val dateFormatter = DateTimeFormat.forPattern("EEE d")
 
-    override fun updateWith(event: Event, showRoom: Boolean, showDay: Boolean) {
+    override fun updateWith(event: Event, showRoom: Boolean, showDay: Boolean, showFavorite: Boolean) {
         ensureSupportedType(event.type)
 
         timestamp.text = startTimeAsFormattedString(event, showDay)
@@ -40,7 +40,7 @@ class TalkEventItemView @JvmOverloads constructor(
         speaker_container.visibility = if (event.speakers.isEmpty()) View.GONE else View.VISIBLE
         speaker_container.updateWith(event.speakers, null)
 
-        favoriteIcon.isVisible = event.favorite
+        favoriteIcon.isVisible = if (showFavorite) event.favorite else false
     }
 
     private fun Place?.toPlaceLabel(): CharSequence? = if (this != null) " • ${this.name}" else null