Skip to content

Commit 92ffa55

Browse files
committed
better logging for validation
1 parent be58b80 commit 92ffa55

1 file changed

Lines changed: 24 additions & 0 deletions

File tree

.github/workflows/pr-run.yaml

Lines changed: 24 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -49,8 +49,11 @@ jobs:
4949
while IFS= read -r plugin_path; do
5050
echo "Validating ${plugin_path}..."
5151
result=$(squaredup validate "${plugin_path}" --json)
52+
echo "$result" | jq '.'
5253
valid=$(echo "$result" | jq -r '.valid')
5354
55+
echo "$result" | jq --arg path "$plugin_path" '. + {plugin_path: $path}' >> /tmp/validation_results.ndjson
56+
5457
if [ "$valid" = "true" ]; then
5558
plugin_name=$(echo "$result" | jq -r '.pluginName')
5659
echo "[PASS] ${plugin_name} passed validation"
@@ -108,3 +111,24 @@ jobs:
108111
109112
echo "| Validation | ${v_status} |" >> $GITHUB_STEP_SUMMARY
110113
echo "| Deployment | ${d_status} |" >> $GITHUB_STEP_SUMMARY
114+
echo "" >> $GITHUB_STEP_SUMMARY
115+
116+
if [ -f /tmp/validation_results.ndjson ]; then
117+
echo "### 🔍 Validation Details" >> $GITHUB_STEP_SUMMARY
118+
echo "" >> $GITHUB_STEP_SUMMARY
119+
while IFS= read -r line; do
120+
plugin_path=$(echo "$line" | jq -r '.plugin_path')
121+
valid=$(echo "$line" | jq -r '.valid')
122+
plugin_name=$(echo "$line" | jq -r '.pluginName // .plugin_path')
123+
[ "$valid" = "true" ] && icon="✅" || icon="❌"
124+
125+
echo "<details>" >> $GITHUB_STEP_SUMMARY
126+
echo "<summary>${icon} <code>${plugin_name}</code></summary>" >> $GITHUB_STEP_SUMMARY
127+
echo "" >> $GITHUB_STEP_SUMMARY
128+
echo '```json' >> $GITHUB_STEP_SUMMARY
129+
echo "$line" | jq 'del(.plugin_path)' >> $GITHUB_STEP_SUMMARY
130+
echo '```' >> $GITHUB_STEP_SUMMARY
131+
echo "</details>" >> $GITHUB_STEP_SUMMARY
132+
echo "" >> $GITHUB_STEP_SUMMARY
133+
done < /tmp/validation_results.ndjson
134+
fi

0 commit comments

Comments
 (0)