Skip to content

Commit c386367

Browse files
vinbabclaude
andcommitted
Address PR review comments
- metadata.json: add terminal punctuation to description (CodeRabbit) - Repository Status dashboard: map isOnline "false" to error so offline repositories surface as unhealthy (CodeRabbit) - docs/README.md: drop the trailing-slash note and the redundant indexing paragraph (review nits) Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
1 parent 6886123 commit c386367

3 files changed

Lines changed: 3 additions & 5 deletions

File tree

plugins/VeeamBackupReplication/v1/defaultContent/Repository/status.dash.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@
2424
"pluginConfigId": "{{configId}}",
2525
"metadata": [
2626
{
27-
"shape": ["state", { "map": { "unmonitored": [], "unknown": [], "error": [], "warning": [], "success": ["true"] } }],
27+
"shape": ["state", { "map": { "unmonitored": [], "unknown": [], "error": ["false"], "warning": [], "success": ["true"] } }],
2828
"name": "isOnline"
2929
}
3030
],

plugins/VeeamBackupReplication/v1/docs/README.md

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ The plugin authenticates with the **username and password** of a VBR account (OA
2626

2727
| Field | Required | Description |
2828
|---|---|---|
29-
| **Server URL** | Yes | The bare root of your VBR server — scheme, host and REST API port only, e.g. `https://vbr01.contoso.com:9419`. **Do not** add a path such as `/api/v1` or a trailing slash; the plugin appends those itself. |
29+
| **Server URL** | Yes | The bare root of your VBR server — scheme, host and REST API port only, e.g. `https://vbr01.contoso.com:9419`. **Do not** add a path such as `/api/v1`; the plugin appends it. |
3030
| **Username** | Yes | A VBR account with at least the Veeam Backup Viewer role. Domain accounts use `DOMAIN\user`. |
3131
| **Password** | Yes | The password for the account above. |
3232
| **REST API version** | Yes | The `x-api-version` revision sent on every request. Pick the revision matching your server — see [Choosing the REST API version](#choosing-the-rest-api-version). Defaults to `1.3-rev1`. |
@@ -55,8 +55,6 @@ Every request carries an `x-api-version` header. **Choose the highest revision y
5555
| **Veeam Repository** | A backup repository | repository type, description, host, path |
5656
| **Veeam Job** | A backup job | job type, description |
5757

58-
Objects are re‑imported automatically (every 12 hours by default), and are indexed from the job‑ and repository‑*state* endpoints so the same identity powers both the object list and its live status. Use them to scope dashboards, drill down, and search across SquaredUp. In any table, the **Name** column links straight to the matching object.
59-
6058
## Data streams
6159

6260
| Data stream | Scope | Returns |

plugins/VeeamBackupReplication/v1/metadata.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
"name": "SquaredUp Labs",
77
"type": "labs"
88
},
9-
"description": "Monitor backup jobs and repositories",
9+
"description": "Monitor backup jobs and repositories.",
1010
"category": "Infrastructure",
1111
"type": "hybrid",
1212
"schemaVersion": "2.0",

0 commit comments

Comments
 (0)