fix device import again

Author: Deenk

plugins/NinjaOne/v1/dataStreams/devices.json

@@ -24,7 +24,7 @@
         "expandInnerObjects": true,
         "endpointPath": "/v2/devices",
         "postRequestScript": "devices.js",
-        "pathToData": "results",
+        "pathToData": "",
         "getArgs": [],
         "headers": []
     },

plugins/NinjaOne/v1/dataStreams/scripts/devices.js

@@ -1,70 +1,31 @@
-// Handle NinjaOne array or paged response and convert numeric IDs to strings for SquaredUp compatibility
 const items = (data && data.results ? data.results : (Array.isArray(data) ? data : []));
 
-/**
- * Recursively converts NinjaOne Unix timestamps (seconds) to ISO strings.
- * NinjaOne typically returns timestamps as floats/integers in seconds.
- * SquaredUp's date shape/JS Date expects milliseconds or ISO strings.
- * @param {any} obj 
- * @returns {any}
- */
 const convertTimestamps = (obj) => {
     if (!obj || typeof obj !== 'object') return obj;
     for (const key in obj) {
         const val = obj[key];
         if (typeof val === 'number') {
-             // Heuristic: check if key name suggests a timestamp and value is in seconds range (1e9 to 1e10)
-             const lowerKey = key.toLowerCase();
-             if (lowerKey.includes('time') || lowerKey.includes('date') || lowerKey.includes('contact') || lowerKey.includes('update') || lowerKey.includes('start') || lowerKey.includes('end')) {
-                 if (val > 1000000000 && val < 10000000000) {
-                     obj[key] = new Date(val * 1000).toISOString();
-                 }
-             }
+            const lowerKey = key.toLowerCase();
+            if (lowerKey.includes('time') || lowerKey.includes('date') || lowerKey.includes('contact') || lowerKey.includes('update') || lowerKey.includes('start') || lowerKey.includes('end')) {
+                if (val > 1000000000 && val < 10000000000) {
+                    obj[key] = new Date(val * 1000).toISOString();
+                }
+            }
         } else if (typeof val === 'object' && val !== null) {
             convertTimestamps(val);
         }
     }
     return obj;
 };
 
-const processedItems = items.map(item => {
-    // Recursively convert timestamps in the item (modifies in place but we are mapping to a new object)
+result = items.map(item => {
     const converted = convertTimestamps(item);
-    
-    return { 
-        ...converted, 
-        deviceId: converted.id ? converted.id.toString() : null, 
+    return {
+        ...converted,
+        deviceId: converted.id ? converted.id.toString() : null,
         id: converted.id ? converted.id.toString() : null,
-        // Ensure displayName is present for the import engine (maps to systemName if missing)
         displayName: converted.displayName || converted.systemName || converted.dnsName || (converted.id ? `Device ${converted.id}` : 'Unknown Device'),
-        // Add organizationId and locationId as strings if they are there
         organizationId: converted.organizationId ? converted.organizationId.toString() : null,
         locationId: converted.locationId ? converted.locationId.toString() : null
     };
 });
-
-// Always return a consistent wrapped object for SquaredUp compatibility
-// This ensures that pathToData: "results" always works, and paging metadata is consistently located.
-result = {
-    results: processedItems,
-    metadata: (data && data.metadata) ? { ...data.metadata } : {}
-};
-
-// Capture next_page_token from root if present (some endpoints put it there)
-if (data && data.next_page_token) {
-    result.metadata.next_page_token = data.next_page_token;
-}
-
-// Capture cursor from root if present (used by some endpoints)
-if (data && data.cursor) {
-    result.metadata.cursor = data.cursor;
-}
-
-// If the response was a flat array, we can still support paging by providing a next_page_token
-// based on the last item's ID (which is what NinjaOne often expects in 'after' param)
-if (Array.isArray(data) && !result.metadata.next_page_token) {
-    result.metadata.next_page_token = processedItems.length > 0 ? processedItems[processedItems.length - 1].id : null;
-}
-
-// Return the result object
-result;

plugins/NinjaOne/v1/metadata.json

@@ -1,7 +1,7 @@
 {
     "name": "ninja-one",
     "displayName": "NinjaOne",
-    "version": "1.1.2",
+    "version": "1.1.3",
     "author": {
         "name": "SquaredUp Labs",
         "type": "labs"